public inbox for [email protected]
help / color / mirror / Atom feedFrom: Tom Lane <[email protected]>
To: John Naylor <[email protected]>
Cc: Nathan Bossart <[email protected]>
Cc: Junwang Zhao <[email protected]>
Cc: John Naylor <[email protected]>
Cc: PostgreSQL Hackers <[email protected]>
Subject: Re: [dynahash] do not refill the hashkey after hash_search
Date: Wed, 25 Oct 2023 01:21:32 -0400
Message-ID: <[email protected]> (raw)
In-Reply-To: <CANWCAZYc-easGz5sjDxm1iXXM14xs5_NwMu4DA5gr23CMjXmwQ@mail.gmail.com>
References: <CAEG8a3+UPF=R2QGPgJMF2mKh8xPd1H2TmfH77zPuVUFdBpiGUA@mail.gmail.com>
<CAFBsxsGXWZBfPFF_6F6td6Oq5ABJDq-ACAHa7bshDcEEKOD5VQ@mail.gmail.com>
<CAEG8a3KEO_Kdt2Y5hFNWMEX3DpCXi9jtZOJY-GFUEE9QLgF+bw@mail.gmail.com>
<CAFBsxsEr_kz7_Z72ndJ-wEAU2U0UimhAXkXpg9fgC+Y4-A8y9w@mail.gmail.com>
<CAEG8a3+h_P8ZDmQ4FzfRqgGyiDGG+GppwNaymgu_Jaiy=s+nGw@mail.gmail.com>
<20231013030747.GA1314489@nathanxps13>
<CANWCAZYc-easGz5sjDxm1iXXM14xs5_NwMu4DA5gr23CMjXmwQ@mail.gmail.com>
John Naylor <[email protected]> writes:
> I'd prefer just adding "Assert(hentry->event == oldn);" and declaring
> hentry PG_USED_FOR_ASSERTS_ONLY.
I'm not aware of any other places where we have Asserts checking
that hash_search() honored its contract. Why do we need one here?
regards, tom lane
view thread (12+ messages) latest in thread
reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: [email protected]
Cc: [email protected], [email protected], [email protected], [email protected], [email protected], [email protected]
Subject: Re: [dynahash] do not refill the hashkey after hash_search
In-Reply-To: <[email protected]>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox