Message-ID: <908d9ef9-2194-4333-a363-e41e1887de70@joeconway.com>
Date: Thu, 30 Oct 2025 09:29:46 -0400
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: contrib/sepgsql regression tests have been broken for months
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Andrew Dunstan <andrew@dunslane.net>,
 Jacob Champion <jacob.champion@enterprisedb.com>,
 pgsql-hackers@lists.postgresql.org
References: <1613232.1761255361@sss.pgh.pa.us>
 <2e327a21-9954-4d05-aa9e-3b7fe926f39f@joeconway.com>
 <371f0ee1-8507-46e0-9090-6df2b14f0cd8@joeconway.com>
 <081073df-32ff-498c-abeb-2e5590888ad9@joeconway.com>
 <CAOYmi+mppi5iSgyVFv007o6YRh-4oFcP=v3Tv4VjGLxT9R7rWA@mail.gmail.com>
 <b485587f-c3ea-4089-b526-92dcd1809f6e@joeconway.com>
 <66541690-91c2-48e6-9c99-12c9af25012b@joeconway.com>
 <2919479.1761779546@sss.pgh.pa.us> <2922181.1761780963@sss.pgh.pa.us>
Content-Language: en-US
From: Joe Conway <mail@joeconway.com>
In-Reply-To: <2922181.1761780963@sss.pgh.pa.us>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Archived-At: 
 <https://www.postgresql.org/message-id/908d9ef9-2194-4333-a363-e41e1887de70%40joeconway.com>
Precedence: bulk

On 10/29/25 19:36, Tom Lane wrote:
> I poked around in the buildfarm client and was surprised to
> find that the old TestSepgsql.pm module does in fact expect
> to have sudo privileges, and it seems to install, enable,
> and eventually remove the sepgsql-regtest kernel module.
> 
> I thought we were trying to get rid of that requirement though.
> (For sure, you won't ever see me running the buildfarm
> client under a sudo-capable account.)  I think the new idea
> is to leave the module installed and active, which is kind
> of problematic if we want to also use TestSepgsql.pm in the
> back branches.
> 
> I also don't quite understand how 001_sepgsql.pl's "checking for
> sepgsql-regtest policy" test is passing if the previous
> TestSepgsql.pm run removed that module ...

I suppose one solution is to create a new buildfarm animal and then use 
rhino only for <= pg17 and <rhino-prime> only for pg18+

-- 
Joe Conway
PostgreSQL Contributors Team
Amazon Web Services: https://aws.amazon.com