Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1l2O7X-0007cl-Sa for pgsql-hackers@arkaria.postgresql.org; Thu, 21 Jan 2021 00:46:43 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1l2O7W-0006Xu-HV for pgsql-hackers@arkaria.postgresql.org; Thu, 21 Jan 2021 00:46:42 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1l2O7W-0006Xm-9o for pgsql-hackers@lists.postgresql.org; Thu, 21 Jan 2021 00:46:42 +0000 Received: from mail-ej1-x62d.google.com ([2a00:1450:4864:20::62d]) by magus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1l2O7O-0006hf-HI for pgsql-hackers@postgresql.org; Thu, 21 Jan 2021 00:46:41 +0000 Received: by mail-ej1-x62d.google.com with SMTP id gx5so241897ejb.7 for ; Wed, 20 Jan 2021 16:46:33 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=enterprisedb-com.20150623.gappssmtp.com; s=20150623; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=fHnCI5HzjCLYIljguJthSbFFSRh8ZUHALLThHMaR6tQ=; b=R7tu3OOiHRsUz5pmRWtenFBJlawsebyFQOeZMw8Szjoed/vm7zdlMzTCFZoUOW4Qy/ mi1BHMd00Mu9eNzpe/HUzWVG8yfLlek57Fh59I3qfQVjKRrUpquqoDzDrarW3cjcT3xD 2Fqt/sVMGpv/R6IRJd3KcFcPkmO1Zf0+YCKnczuQGZ/giU6fFib03fAmswuSr8ypHhgA x25uUCir7vEYQyQIw5tdDJ4C/yyyQqdO7cGBFBGz/Ft3J0TRXCcH3qqSqWQz8eoreSnI beuVh3sOu6s9oJnoYY72B8WqKGHtP6d+cjaa6FsMtQ3jUnRydW6/iIU6YHiGaUA0lX6W QjAQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=fHnCI5HzjCLYIljguJthSbFFSRh8ZUHALLThHMaR6tQ=; b=U2xuDYGhQfTEJi2bXpCdeGZx660GsrrmuYnlX36LzzQHyQQ+Eo4oiFtwuCaPOZsUJa mNE6kMWv7L1sIW0S+cwGuU9FWIBaA4QL9/WlbxJgyh/uGQ0dpXCV1LpFOwkObD8mnIwe GgyNPsvW0MpJsKR+58eK3vGN8cpxwtcKY+7AFqoRBCUg0ybSnitvbjp9igcywEJ4fa9F aVNNudmhBIoXRGIuZK55j1lmLOypxULKG6q59nFASJK9WU4jQF9GjSGj3JaeFXSF2Bpo CgqpzeW9KgupXBYImUPfL2tvh2lJCbc4uz3lF+Ijb5Yw2FaPl7AAyDaARcaDsv7cQzj3 vKwA== X-Gm-Message-State: AOAM532JOjIXsziWw+152djBjzDGJtgNfs4PbIGyTf3IUcABt0kZu4nL omxGFWn9vRp45Gl3zWIDxDkM/peeVeziL6ZZa4lM+yb/ZhqVX91MIbQBSljjDBj1GoT3dCWG0Lx rjWxfjxJLPAhhvUD8Es1AiJlHiMjll93YDKZHS5ViChFoKmNZQIWoO18VFVf3S+t+szuJfwCG39 ESQ9psbMwz/dGRevYDr4mYsduXYwPLeixYMMqsEAQQA7wWgDMUusCZboYHrLSNUZN7gBxdMUNwU ZVH7zHKpw1HD7s9w0/zDnwvOAtKfYKwywUTLQ== X-Google-Smtp-Source: ABdhPJxVM76k4urdwxwmPxDxxzKT3GZ8AMrjRfiuE5MeTrH+coA/f9Oarpum5S4Tf2rJlGDPRfJXYQ== X-Received: by 2002:a17:906:c9cc:: with SMTP id hk12mr5725805ejb.134.1611189993110; Wed, 20 Jan 2021 16:46:33 -0800 (PST) Received: from [10.137.0.20] (ip-86-49-253-127.net.upcbroadband.cz. [86.49.253.127]) by smtp.gmail.com with ESMTPSA id s12sm1935621edu.28.2021.01.20.16.46.31 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 20 Jan 2021 16:46:32 -0800 (PST) Subject: Re: POC: postgres_fdw insert batching To: Tom Lane Cc: Amit Langote , "tsunakawa.takay@fujitsu.com" , "Andrey V. Lepikhov" , Tomas Vondra , "pgsql-hackers@postgresql.org" References: <20200628151002.7x5laxwpgvkyiu3q@development> <16fcfd4c-2d5e-67f7-fa69-9b5d119bac52@enterprisedb.com> <9d94c863-ce7c-ea7f-6b84-834c98929e2f@enterprisedb.com> <7e70a11e-cf5! d-2e5f-a802-274c5e0e236b@enterprisedb.com> <794439.1611187182@sss.pgh.pa.us> From: Tomas Vondra Message-ID: <90b0e85d-9db9-5e47-7746-5afba5ee8185@enterprisedb.com> Date: Thu, 21 Jan 2021 01:46:29 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.6.0 MIME-Version: 1.0 In-Reply-To: <794439.1611187182@sss.pgh.pa.us> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-CLOUD-SEC-AV-Info: enterprisedb,google_mail,monitor X-CLOUD-SEC-AV-Sent: true X-Gm-Spam: 0 X-Gm-Phishy: 0 List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk On 1/21/21 12:59 AM, Tom Lane wrote: > Tomas Vondra writes: >> OK, pushed after a little bit of additional polishing (mostly comments). >> Thanks everyone! > > florican reports this is seriously broken on 32-bit hardware: > > https://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=florican&dt=2021-01-20%2023%3A08%3A15 > > First guess is incorrect memory-allocation computations ... > I know, although it seems more like an access to unitialized memory. I've already posted a patch that resolves that for me on 64-bits (per valgrind, I suppose it's the same issue). I'm working on reproducing it on 32-bits, hopefully it won't take long. regards -- Tomas Vondra EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company