Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1tnQjf-005Den-Pm for pgsql-hackers@arkaria.postgresql.org; Wed, 26 Feb 2025 23:22:40 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.94.2) (envelope-from ) id 1tnQjd-00Gvfo-D3 for pgsql-hackers@arkaria.postgresql.org; Wed, 26 Feb 2025 23:22:37 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1tnQjd-00Gvej-1i for pgsql-hackers@lists.postgresql.org; Wed, 26 Feb 2025 23:22:37 +0000 Received: from mail-wr1-x42c.google.com ([2a00:1450:4864:20::42c]) by magus.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.96) (envelope-from ) id 1tnQjY-000HZR-1E for pgsql-hackers@lists.postgresql.org; Wed, 26 Feb 2025 23:22:36 +0000 Received: by mail-wr1-x42c.google.com with SMTP id ffacd0b85a97d-38f3ee8a119so146385f8f.0 for ; Wed, 26 Feb 2025 15:22:32 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1740612151; x=1741216951; darn=lists.postgresql.org; h=mime-version:user-agent:content-transfer-encoding:date:to:from :subject:message-id:from:to:cc:subject:date:message-id:reply-to; bh=TKxwqZg1Ex2bRi+q90pPKQM3ZuA8egVw2MuohxzYsyg=; b=TCyK3la0zuLLa97mW68eOdjiljNnBPcJjtubS9L2YC81yXbCxN0LzZr2asGiP3TE6E 4gTld53w3wYzS1BWZBoCXYrq9Vq3GUWkqUVyAxxUwJLBrI28k3l1lz7+4Qaga8GhdgKL v1CpNhCtfz3SOv8wRKY2Ot+xt2HHYbZE0UK/gh+jyiM5qsDAGlKi5CZO6un0tKSFyLte s8aS0wFSNZxmePwEZznCt1XMhfn9o8XzajgBvmRftgr9TswF0uED3dBts3fveksHPdFT fZExR7+apFPGkstKUp1xPGR53toMALRcbu6/nyw2ZoGV+6BMsyC3CtyhpULA7VBUg8+K E9ig== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1740612151; x=1741216951; h=mime-version:user-agent:content-transfer-encoding:date:to:from :subject:message-id:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=TKxwqZg1Ex2bRi+q90pPKQM3ZuA8egVw2MuohxzYsyg=; b=erN07mIpW7YWNBCqI5ls86t2MlHhb5bdy73w2dbrrOFhdTlNehL85kmCaCPpftz7yW q8B9VbdmJ7jKMfe7PC8qBtqR66GCX1bcA/dCu1ebkVETY0m+ZrXyj7mHGPkDap0NPIZZ qBdOjnJivacAd+b4zRndVCeu1k8To3iXM8aeFk6jBJD2MeLyEh0HWDl7UnqAtd1A1gd9 FmMNMSUsJZdDp+zZ7ESGaB1p72l2KrpekrGDNspprkMnvcwOD4qDNI/EVleR212+290P OOxaHwExEPvbGdTZDld6ML7nYJhl37aV0NxKmDslgnX3T1ix2sX/oJM3SrOIVjwAZx9g KHNg== X-Gm-Message-State: AOJu0Yzdp+RLrVWt7Oo07QPfEJHK3SYxQPuEdvpzgDGe2iFcACfcqghn mkvtCEtxUVg6ZLbSSTAX0yLwRYiXZTJMZIwapeWRghiO8CC6R0DHu24TQAwX X-Gm-Gg: ASbGncs+p3BA00YY9pCFX7twhDOMcVbsmR/YSOO6lw+URiJMvNKIn3Jqraa5BO8yBvz OMKuY/6kkxw20yE5htmQELFv7CSaHEqTrZLMbj8pvqUGvGj1yHn4VBmwDVLa/s0dZtvofCicYzO ozCpVWfz61nNv/zwO0cUKGConTFsN/E5+2Vx5Cd2vBgsPfQ+V68KUJ2Xkaq8G1p1FG6oqwQDhsc X5ifl8Tuuf/Gxte1hK61JwOvjOttWGqL/Ql4clpLnDBJHuURALzfhR+ld3uVFlv6eS3tPzxyWRf 3wLEtWhw3Yzpic+dP9hgWmPEbF4= X-Google-Smtp-Source: AGHT+IGTp5m+XPT209esLD0FyTwkvqATgzAFrrZt6uyPzAxSi/zqn+yAY92ntR2pTzg1dIXUleAEmQ== X-Received: by 2002:a05:6000:1f88:b0:38f:2ffc:1e99 with SMTP id ffacd0b85a97d-38f7085d549mr14682507f8f.49.1740612151128; Wed, 26 Feb 2025 15:22:31 -0800 (PST) Received: from [192.168.1.4] ([156.198.226.45]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-390e47b792asm251663f8f.53.2025.02.26.15.22.29 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 26 Feb 2025 15:22:29 -0800 (PST) Message-ID: <90cf2abcb873229a095b017faba52e149df7d1f2.camel@gmail.com> Subject: [PATCH] [52] Review of patch 5381 - Documentation for pgstatindex fragmentation From: ahmedashour To: pgsql-hackers@lists.postgresql.org Date: Thu, 27 Feb 2025 01:23:07 +0200 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.46.4-2 MIME-Version: 1.0 List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk Hi all, I=E2=80=99m a beginner contributor reviewing patch 5381 from Commitfest 52. Here=E2=80=99s my feedback: - Applied the patch to the master branch (as of Feb 26, 2025) using `patch -p1 < 5381.patch`. - It updates doc/src/sgml/pgstattuple.sgml, adding a paragraph about `leaf_fragmentation`. - Built the HTML docs with `make html` in the doc directory and reviewed the output in a browser. - The new text explains that `leaf_fragmentation` is the percentage of fragmented leaf pages in an index, caused by deletions/updates, and mentions performance impacts and REINDEX as maintenance. - The explanation is clear and accurate. No formatting issues or typos found in the HTML output. - Suggestion: Adding a simple example like =E2=80=9CA value of 30% means 30= % of leaf pages have gaps=E2=80=9D could make it even more beginner-friendly. Overall, it looks solid and ready for committer review. Thanks to Fr=C3=A9d=C3=A9ric Yhuel for this useful addition! Regards, [Ahmed Ashour]