To: pgsql-hackers <pgsql-hackers@postgresql.org>
From: Peter Eisentraut <peter.eisentraut@2ndquadrant.com>
Subject: Log the location field before any backtrace
Organization: 2ndQuadrant
Message-ID: <90f5fa04-c410-a54e-9449-aa3749fb7972@2ndquadrant.com>
Date: Thu, 9 Jul 2020 11:17:32 +0200
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.14; rv:52.0)
 Gecko/20100101 Thunderbird/52.9.1
MIME-Version: 1.0
Content-Type: multipart/mixed;
 boundary="------------96DA0C909360F6BB5FD8BBB3"
Content-Language: en-US
Precedence: bulk

This is a multi-part message in MIME format.
--------------96DA0C909360F6BB5FD8BBB3
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 7bit

In PG13, we added the ability to add backtraces to the log output. 
After some practical experience with it, I think the order in which the 
BACKTRACE and the LOCATION fields are printed is wrong.  I propose we 
put the LOCATION field before the BACKTRACE field, not after.  This 
makes more sense because the location is effectively at the lowest level 
of the backtrace.

Patch attached.

-- 
Peter Eisentraut              http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services

--------------96DA0C909360F6BB5FD8BBB3
Content-Type: text/plain; charset=UTF-8; x-mac-type="0"; x-mac-creator="0";
 name="0001-Log-the-location-field-before-any-backtrace.patch"
Content-Transfer-Encoding: base64
Content-Disposition: attachment;
 filename="0001-Log-the-location-field-before-any-backtrace.patch"

RnJvbSBhYWY0YTgxNDZjZjYwYTU5NTllNTA0MzIzNTlmZDk5NzJmNDEwZTFiIE1vbiBTZXAg
MTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBQZXRlciBFaXNlbnRyYXV0IDxwZXRlckBlaXNlbnRy
YXV0Lm9yZz4KRGF0ZTogVGh1LCA5IEp1bCAyMDIwIDExOjAwOjM0ICswMjAwClN1YmplY3Q6
IFtQQVRDSF0gTG9nIHRoZSBsb2NhdGlvbiBmaWVsZCBiZWZvcmUgYW55IGJhY2t0cmFjZQoK
VGhpcyBvcmRlciBtYWtlcyBtb3JlIHNlbnNlIGJlY2F1c2UgdGhlIGxvY2F0aW9uIGlzIGVm
ZmVjdGl2ZWx5IGF0IHRoZQpsb3dlc3QgbGV2ZWwgb2YgdGhlIGJhY2t0cmFjZS4KLS0tCiBz
cmMvYmFja2VuZC91dGlscy9lcnJvci9lbG9nLmMgfCAxNCArKysrKysrLS0tLS0tLQogMSBm
aWxlIGNoYW5nZWQsIDcgaW5zZXJ0aW9ucygrKSwgNyBkZWxldGlvbnMoLSkKCmRpZmYgLS1n
aXQgYS9zcmMvYmFja2VuZC91dGlscy9lcnJvci9lbG9nLmMgYi9zcmMvYmFja2VuZC91dGls
cy9lcnJvci9lbG9nLmMKaW5kZXggZTk3NjIwMTAzMC4uZTRiNzE3Yzc5YSAxMDA2NDQKLS0t
IGEvc3JjL2JhY2tlbmQvdXRpbHMvZXJyb3IvZWxvZy5jCisrKyBiL3NyYy9iYWNrZW5kL3V0
aWxzL2Vycm9yL2Vsb2cuYwpAQCAtMjkzOCwxMyArMjkzOCw2IEBAIHNlbmRfbWVzc2FnZV90
b19zZXJ2ZXJfbG9nKEVycm9yRGF0YSAqZWRhdGEpCiAJCQlhcHBlbmRfd2l0aF90YWJzKCZi
dWYsIGVkYXRhLT5jb250ZXh0KTsKIAkJCWFwcGVuZFN0cmluZ0luZm9DaGFyKCZidWYsICdc
bicpOwogCQl9Ci0JCWlmIChlZGF0YS0+YmFja3RyYWNlKQotCQl7Ci0JCQlsb2dfbGluZV9w
cmVmaXgoJmJ1ZiwgZWRhdGEpOwotCQkJYXBwZW5kU3RyaW5nSW5mb1N0cmluZygmYnVmLCBf
KCJCQUNLVFJBQ0U6ICAiKSk7Ci0JCQlhcHBlbmRfd2l0aF90YWJzKCZidWYsIGVkYXRhLT5i
YWNrdHJhY2UpOwotCQkJYXBwZW5kU3RyaW5nSW5mb0NoYXIoJmJ1ZiwgJ1xuJyk7Ci0JCX0K
IAkJaWYgKExvZ19lcnJvcl92ZXJib3NpdHkgPj0gUEdFUlJPUl9WRVJCT1NFKQogCQl7CiAJ
CQkvKiBhc3N1bWUgbm8gbmV3bGluZXMgaW4gZnVuY25hbWUgb3IgZmlsZW5hbWUuLi4gKi8K
QEAgLTI5NjIsNiArMjk1NSwxMyBAQCBzZW5kX21lc3NhZ2VfdG9fc2VydmVyX2xvZyhFcnJv
ckRhdGEgKmVkYXRhKQogCQkJCQkJCQkgZWRhdGEtPmZpbGVuYW1lLCBlZGF0YS0+bGluZW5v
KTsKIAkJCX0KIAkJfQorCQlpZiAoZWRhdGEtPmJhY2t0cmFjZSkKKwkJeworCQkJbG9nX2xp
bmVfcHJlZml4KCZidWYsIGVkYXRhKTsKKwkJCWFwcGVuZFN0cmluZ0luZm9TdHJpbmcoJmJ1
ZiwgXygiQkFDS1RSQUNFOiAgIikpOworCQkJYXBwZW5kX3dpdGhfdGFicygmYnVmLCBlZGF0
YS0+YmFja3RyYWNlKTsKKwkJCWFwcGVuZFN0cmluZ0luZm9DaGFyKCZidWYsICdcbicpOwor
CQl9CiAJfQogCiAJLyoKLS0gCjIuMjcuMAoK
--------------96DA0C909360F6BB5FD8BBB3--