From: Tom Lane <tgl@sss.pgh.pa.us>
To: Bruce Momjian <bruce@momjian.us>
cc: Alvaro Herrera <alvherre@alvh.no-ip.org>,
        Pg Hackers <pgsql-hackers@lists.postgresql.org>
Subject: Re: pg_upgrade --check fails to warn about abstime
In-reply-to: <ZQzx3Dt8TKhLwxCF@momjian.us>
References: <202309201654.ng4ksea25mti@alvherre.pgsql>
 <ZQzx3Dt8TKhLwxCF@momjian.us>
Comments: In-reply-to Bruce Momjian <bruce@momjian.us>
	message dated "Thu, 21 Sep 2023 21:46:04 -0400"
MIME-Version: 1.0
Content-Type: text/plain; charset="UTF-8"
Content-ID: <910186.1695352721.1@sss.pgh.pa.us>
Content-Transfer-Encoding: 8bit
Date: Thu, 21 Sep 2023 23:18:41 -0400
Message-ID: <910187.1695352721@sss.pgh.pa.us>
Archived-At: 
 <https://www.postgresql.org/message-id/910187.1695352721%40sss.pgh.pa.us>
Precedence: bulk

Bruce Momjian <bruce@momjian.us> writes:
> On Wed, Sep 20, 2023 at 06:54:24PM +0200, Álvaro Herrera wrote:
>> I got a complaint that pg_upgrade --check fails to raise red flags when
>> the source database contains type abstime when upgrading from pg11.  The
>> type (along with reltime and tinterval) was removed by pg12.

> Wow, I never added code to pg_upgrade to check for that, and no one
> complained either.

Yeah, so most people had indeed listened to warnings and moved away
from those datatypes.  I'm inclined to think that adding code for this
at this point is a bit of a waste of time.

			regards, tom lane