Received: from malur.postgresql.org ([2a02:16a8:dc51::56]) by arkaria.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.89) (envelope-from ) id 1fsdIl-0006jR-Jj for pgsql-hackers@arkaria.postgresql.org; Thu, 23 Aug 2018 00:16:39 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.89) (envelope-from ) id 1fsdIj-0000DF-GQ for pgsql-hackers@arkaria.postgresql.org; Thu, 23 Aug 2018 00:16:37 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.89) (envelope-from ) id 1fsdIj-0000Cr-9c for pgsql-hackers@lists.postgresql.org; Thu, 23 Aug 2018 00:16:37 +0000 Received: from sss.pgh.pa.us ([66.207.139.130]) by magus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.89) (envelope-from ) id 1fsdIg-0006UK-89 for pgsql-hackers@lists.postgresql.org; Thu, 23 Aug 2018 00:16:36 +0000 Received: from sss1.sss.pgh.pa.us (localhost [127.0.0.1]) by sss.pgh.pa.us (8.14.4/8.14.4) with ESMTP id w7N0GOki009103; Wed, 22 Aug 2018 20:16:24 -0400 From: Tom Lane To: Andres Freund cc: Sandeep Thakkar , Andrew Dunstan , "Joshua D. Drake" , Peter Eisentraut , Thomas Munro , David Steele , PostgreSQL Hackers , Craig Ringer Subject: Re: Windows vs C99 (was Re: C99 compliance for src/port/snprintf.c) In-reply-to: <20180823000905.fjthfohmczss4fiw@alap3.anarazel.de> References: <97d4b165-192d-3605-749c-f614a0c4e783@2ndquadrant.com> <20532.1534872560@sss.pgh.pa.us> <20180821173123.wliiykscjvtnbxk2@alap3.anarazel.de> <1d5946a3-aa85-a3ec-c8aa-b3e9b66dd5d9@commandprompt.com> <20180821204936.tqdmjolkoo2sv5og@alap3.anarazel.de> <303572b3-89a5-6177-d46a-e23b2b4d6caa@2ndQuadrant.com> <20180821232952.ixj6kgccoqcjp5gf@alap3.anarazel.de> <20180822120211.prl6uxspai4lahfs@alap3.anarazel.de> <20180823000905.fjthfohmczss4fiw@alap3.anarazel.de> Comments: In-reply-to Andres Freund message dated "Wed, 22 Aug 2018 17:09:05 -0700" MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <9101.1534983384.1@sss.pgh.pa.us> Date: Wed, 22 Aug 2018 20:16:24 -0400 Message-ID: <9102.1534983384@sss.pgh.pa.us> List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk Andres Freund writes: > There's a few further potential cleanups due to relying on c99: > - Use __func__ unconditionally, rather than having configure test for it > - Use inline unconditionally, rather than having configure test for it > - Remove tests for AC_TYPE_INTPTR_T, AC_TYPE_UINTPTR_T, > AC_TYPE_LONG_LONG_INT, we can rely on them being present. > - probably more in that vein I wouldn't be in too much of a hurry to do that, particularly not the third item. You are confusing "compiler is c99" with "system headers are c99". Moreover, I don't see that we're buying much with such changes. regards, tom lane