Message-ID: <91643cfa-16f4-1bc2-e235-0dfa6d285b3a@gmail.com>
Date: Sun, 19 May 2024 11:00:00 +0300
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.4.2
Subject: Re: Avoid orphaned objects dependencies, take 3
Content-Language: en-US
To: Bertrand Drouvot <bertranddrouvot.pg@gmail.com>,
 Michael Paquier <michael@paquier.xyz>
Cc: pgsql-hackers@lists.postgresql.org
References: <ZidAHRJyMzPZ5JtJ@ip-10-97-1-34.eu-west-3.compute.internal>
 <Ziff3vGRKv1LUjY7@ip-10-97-1-34.eu-west-3.compute.internal>
 <ZijE6UBCo02U2TXJ@ip-10-97-1-34.eu-west-3.compute.internal>
 <62310067-6dc4-97ab-6724-7d3602b5056d@gmail.com>
 <ZinjZmaMEEkOSfZ0@ip-10-97-1-34.eu-west-3.compute.internal>
 <403075e1-4d60-09e2-a06a-749cd9d88f66@gmail.com>
 <ZioEJafHC95wjfMk@ip-10-97-1-34.eu-west-3.compute.internal>
 <d815344e-a6a2-617a-d35f-012e5e89f29f@gmail.com>
 <Zjy/o3t/26exwj5Z@ip-10-97-1-34.eu-west-3.compute.internal>
 <ZkQMYVxbOxFD0519@paquier.xyz>
 <ZkRy73Q2NDBT0Avq@ip-10-97-1-34.eu-west-3.compute.internal>
From: Alexander Lakhin <exclusion@gmail.com>
In-Reply-To: <ZkRy73Q2NDBT0Avq@ip-10-97-1-34.eu-west-3.compute.internal>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
Archived-At: <https://www.postgresql.org/message-id/91643cfa-16f4-1bc2-e235-0dfa6d285b3a%40gmail.com>
Precedence: bulk

Hello Bertrand,

15.05.2024 11:31, Bertrand Drouvot wrote:
> On Wed, May 15, 2024 at 10:14:09AM +0900, Michael Paquier wrote:
>
>> +            if (object_description)
>> +                ereport(ERROR, errmsg("%s does not exist", object_description));
>> +            else
>> +                ereport(ERROR, errmsg("a dependent object does not ex
>>
>> This generates an internal error code.  Is that intended?
> Yes, it's like when say you want to create an object in a schema that does not
> exist (see get_namespace_oid()).

AFAICS, get_namespace_oid() throws not ERRCODE_INTERNAL_ERROR,
but ERRCODE_UNDEFINED_SCHEMA:

# SELECT regtype('unknown_schema.type');
ERROR:  schema "unknown_schema" does not exist
LINE 1: SELECT regtype('unknown_schema.type');
                        ^
# \echo :LAST_ERROR_SQLSTATE
3F000

Probably, it's worth to avoid ERRCODE_INTERNAL_ERROR here in light of [1]
and [2], as these errors are not that abnormal (not Assert-like).

[1] https://www.postgresql.org/message-id/Zic_GNgos5sMxKoa%40paquier.xyz
[2] https://commitfest.postgresql.org/48/4735/

Best regards,
Alexander