Message-ID: <91659fe70489aa6864bd6989b07304bd8d1c7606.camel@j-davis.com>
Subject: Re: Fix search_path for all maintenance commands
From: Jeff Davis <pgsql@j-davis.com>
To: Noah Misch <noah@leadboat.com>
Cc: Nathan Bossart <nathandbossart@gmail.com>, "David G. Johnston"
 <david.g.johnston@gmail.com>, Gurjeet Singh <gurjeet@singh.im>, 
 pgsql-hackers@postgresql.org, Robert Haas <robertmhaas@gmail.com>, Greg
 Stark <stark@mit.edu>, Tom Lane <tgl@sss.pgh.pa.us>
Date: Sat, 22 Jul 2023 11:52:15 -0700
In-Reply-To: <20230722140438.GA50610@rfd.leadboat.com>
References: <b701501541a424111ffe47be055e0ccefefd7745.camel@j-davis.com>
	 <2cf41c8edeaaf7acb757095e6eceab8ae926f3da.camel@j-davis.com>
	 <CABwTF4XWKqx06UxApH8pnBdp_w2iL6VEbGKxDyjCW7-FNhLCBQ@mail.gmail.com>
	 <CAKFQuwbcUv9QmrfQKRRi1aq4E68xHD9N05_VZ2TLbMpxMV9Opg@mail.gmail.com>
	 <CABwTF4W5mZ+5fJEEh2vp7trGzwn-gnG6o13hAALmLjHdpeUn2g@mail.gmail.com>
	 <CAKFQuwZmswfTKtx6oUY0N7UB62cO_nABMgQgdcvrD8r4qjvUJg@mail.gmail.com>
	 <20230715211333.GB3675150@rfd.leadboat.com>
	 <20230717175813.GA717781@nathanxps13>
	 <2ad1dd4e5be5567c0d75676b348eab33b529e974.camel@j-davis.com>
	 <a5960b98b7d8b655f46b4b69387f1290f5848ad4.camel@j-davis.com>
	 <20230722140438.GA50610@rfd.leadboat.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
User-Agent: Evolution 3.44.4-0ubuntu1 
MIME-Version: 1.0
Archived-At: <https://www.postgresql.org/message-id/91659fe70489aa6864bd6989b07304bd8d1c7606.camel%40j-davis.com>
Precedence: bulk

On Sat, 2023-07-22 at 07:04 -0700, Noah Misch wrote:
> Commit a117ceb added that, and it added some test cases that behaved
> differently without that.

Thank you. The reasoning there seems to apply to search_path
restriction as well, so I will leave it as-is.

I'll wait a few more days for comment since I made some changes (also
it's the weekend), but I plan to commit something like the latest
version soon.

I might adjust the CREATE MATERIALIZED VIEW changes to be more minimal,
but that path is not important for security (see pre-existing comment)
so it's probably fine either way.

Regards,
	Jeff Davis