Received: from malur.postgresql.org ([217.196.149.56])
	by arkaria.postgresql.org with esmtps
 (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256)
	(Exim 4.92)
	(envelope-from <pgsql-hackers-owner+archive@lists.postgresql.org>)
	id 1jLpke-0004Xr-JL
	for pgsql-hackers@arkaria.postgresql.org; Tue, 07 Apr 2020 15:02:56 +0000
Received: from localhost ([127.0.0.1] helo=malur.postgresql.org)
	by malur.postgresql.org with esmtp (Exim 4.92)
	(envelope-from <pgsql-hackers-owner+archive@lists.postgresql.org>)
	id 1jLpkd-0004LR-6h
	for pgsql-hackers@arkaria.postgresql.org; Tue, 07 Apr 2020 15:02:55 +0000
Received: from makus.postgresql.org ([2001:4800:3e1:1::229])
	by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256)
	(Exim 4.92)
	(envelope-from <tgl@sss.pgh.pa.us>)
	id 1jLpkd-0004LK-0T
	for pgsql-hackers@lists.postgresql.org; Tue, 07 Apr 2020 15:02:55 +0000
Received: from sss.pgh.pa.us ([66.207.139.130])
	by makus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
	(Exim 4.92)
	(envelope-from <tgl@sss.pgh.pa.us>)
	id 1jLpkW-000530-G2
	for pgsql-hackers@lists.postgresql.org; Tue, 07 Apr 2020 15:02:53 +0000
Received: from sss1.sss.pgh.pa.us (localhost [127.0.0.1])
	by sss.pgh.pa.us (8.14.4/8.14.4) with ESMTP id 037F2hpm009173;
	Tue, 7 Apr 2020 11:02:44 -0400
From: Tom Lane <tgl@sss.pgh.pa.us>
To: "movead.li@highgo.ca" <movead.li@highgo.ca>
cc: "Daniel Verite" <daniel@manitou-mail.org>,
        pgsql-hackers <pgsql-hackers@lists.postgresql.org>,
        "ashutosh.bapat" <ashutosh.bapat@2ndquadrant.com>
Subject: Re: A bug when use get_bit() function for a long bytea string
In-reply-to: <2020040713393391866468@highgo.ca>
References: <3ae0e84f-1d80-4f98-b36e-235ebcae4ff6@manitou-mail.org>,
 <2020040709294706977061@highgo.ca> <2020040713393391866468@highgo.ca>
Comments: In-reply-to "movead.li@highgo.ca" <movead.li@highgo.ca>
	message dated "Tue, 07 Apr 2020 13:39:37 +0800"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <9171.1586271763.1@sss.pgh.pa.us>
Date: Tue, 07 Apr 2020 11:02:43 -0400
Message-ID: <9172.1586271763@sss.pgh.pa.us>
List-Id: <pgsql-hackers.lists.postgresql.org>
List-Help: <https://lists.postgresql.org/manage/>
List-Subscribe: <https://lists.postgresql.org/manage/>
List-Post: <mailto:pgsql-hackers@lists.postgresql.org>
List-Owner: <mailto:pgsql-hackers-owner@lists.postgresql.org>
List-Archive: <https://www.postgresql.org/list/pgsql-hackers>
Precedence: bulk

"movead.li@highgo.ca" <movead.li@highgo.ca> writes:
> After several patch change by hacker's proposal, I think it's ready to
> commit, can we commit it before doing the code freeze for pg-13?

It would be easier to get this done if you had addressed any of the
objections to the patch as given.  Integer-overflow handling is still
missing, and you still are assuming that it's okay to change catalog
entries in released branches.

			regards, tom lane