From: Tom Lane <tgl@sss.pgh.pa.us>
To: Peter Eisentraut <peter_e@gmx.net>
cc: Robert Haas <robertmhaas@gmail.com>,
 Andres Freund <andres@2ndquadrant.com>, Peter Geoghegan <pg@heroku.com>,
 Pg Hackers <pgsql-hackers@postgresql.org>, Ants Aasma <ants@cybertec.at>
Subject: Re: better atomics - v0.2
In-reply-to: <528B801D.5010609@gmx.net>
References: 
 <CA+TgmoYBW+ux5-8Ja=Mcyuy8=VXAnVRHp3Kess6Pn3DMXAPAEA@mail.gmail.com>
 <20131115200416.GH5489@awork2.anarazel.de>
 <CA+Tgmobhd5hwC+NzCfn2p1MO8EHZjhNgFQyLcA-cjRtSJzZJ6Q@mail.gmail.com>
 <8392.1384873040@sss.pgh.pa.us> <528B801D.5010609@gmx.net>
Comments: In-reply-to Peter Eisentraut <peter_e@gmx.net>
 message dated "Tue, 19 Nov 2013 10:13:33 -0500"
Date: Tue, 19 Nov 2013 10:30:24 -0500
Message-ID: <9178.1384875024@sss.pgh.pa.us>
Precedence: bulk
Sender: pgsql-hackers-owner@postgresql.org

Peter Eisentraut <peter_e@gmx.net> writes:
> On 11/19/13, 9:57 AM, Tom Lane wrote:
>> Hm.  Now that I think about it, isn't Peter proposing to break systems
>> without working "inline" over here?
>> http://www.postgresql.org/message-id/1384257026.8059.5.camel@vanquo.pezone.net

> No, that's about const, volatile, #, and memcmp.

Ah, sorry, not enough caffeine absorbed yet.  Still, we should stop
to think about whether this represents an undesirable move of the
portability goalposts.  The first three of these are certainly
compiler issues, and I personally don't have a problem with blowing
off compilers that still haven't managed to implement all of C89 :-(.
I'm not clear on which systems had the memcmp issue --- do we have
the full story on that?

> I don't have an informed opinion about requiring inline support
> (although it would surely be nice).

inline is C99, and we've generally resisted requiring C99 features.
Maybe it's time to move that goalpost, and maybe not.

			regards, tom lane


-- 
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers