Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1rA5kH-004geG-7m for pgsql-hackers@arkaria.postgresql.org; Mon, 04 Dec 2023 10:00:09 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.94.2) (envelope-from ) id 1rA5kF-00Fwnv-4x for pgsql-hackers@arkaria.postgresql.org; Mon, 04 Dec 2023 10:00:07 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1rA5kE-00Fwnn-Sm for pgsql-hackers@lists.postgresql.org; Mon, 04 Dec 2023 10:00:06 +0000 Received: from mail-lf1-x12a.google.com ([2a00:1450:4864:20::12a]) by magus.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.94.2) (envelope-from ) id 1rA5kD-00A1nH-B3 for pgsql-hackers@lists.postgresql.org; Mon, 04 Dec 2023 10:00:06 +0000 Received: by mail-lf1-x12a.google.com with SMTP id 2adb3069b0e04-50bfa7f7093so629614e87.0 for ; Mon, 04 Dec 2023 02:00:05 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1701684004; x=1702288804; darn=lists.postgresql.org; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=cEXFkv9i4r2lNtYJeVHOdNdDXuiIjy4JSFeDf3kzNCE=; b=ToTIakkUAnGIN45wOIKKTD924/r05aeMIrZ/iM1AvBM7wEGxv1cOVd/K202H+JiKDP OqEBijNUO88+fHI02CIduDfeyylY3qUYVQNSYwhV1wldue3+hv37PGFg8Q3qBDgS8Ce5 KhQXmlP4bMeiUn2QxwGL0Z8dGmGxSJSG4UzXLtGOu1gD8afpcj+qZ9vNkaN7w9/v1jbz T3YaAqUNyn8QFKgWkpdmuGzCB9k19vHLqZCzjbETtsullRroF482XyF+XmsWlM5CjNHd n52CGtU9vfLQzxhPMStMsVHFMOCdV4L9BNt0N1ejtgwViKXSPrC6IJ/q446/T/h2t5FJ aTBw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1701684004; x=1702288804; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=cEXFkv9i4r2lNtYJeVHOdNdDXuiIjy4JSFeDf3kzNCE=; b=BkrlfX7JZ0jPz/lm8XZxPd84+pqWLJN9edlxA3Ho7T/JqOJtopNufjFqjoeeuZUZzC YANoqh8Wr9smo4G9J0rwN9J7y2VqYEPNnDBB8wdsYZuf42QEO1n4wDh3zCOsCUrsvFTO 36HIoXyiSJxaRg6c/ThmRLTeYnV/K4rDc8ARnSzwdDXgnOhZLF52l2OVXNtMcYToHqFo StbtKFtrqLW4I9ii76ErnTrCRhD66FZVVC9jXzFopVXc59fiPynr2cFazYMSFXKAwvsL fCWDXgBCsm9zuom7Ou3CK6nq5QD9xTBeJuFVOab1C9PcPvV0rVdvi9hN5bCYzAcb5rNp XVJw== X-Gm-Message-State: AOJu0YxtProEiJF0MLgeKZ9+rIctR8sbX5vYsrvG72PKb/Q7kZZizo5+ ndMuF2C38zk2Uj6S+sczPNw= X-Google-Smtp-Source: AGHT+IExhtgCnTgWZWNGfkmpDkoRp7jbxS0QkbGA3oxKVDTpCLO7LpYWdKL8jgIMqFuWynZPgdl8/w== X-Received: by 2002:a05:6512:e9a:b0:50b:fe29:7595 with SMTP id bi26-20020a0565120e9a00b0050bfe297595mr151602lfb.65.1701684004236; Mon, 04 Dec 2023 02:00:04 -0800 (PST) Received: from [1.0.0.7] ([178.155.18.102]) by smtp.gmail.com with ESMTPSA id i3-20020a0565123e0300b005068d6de988sm1216093lfv.226.2023.12.04.02.00.01 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 04 Dec 2023 02:00:02 -0800 (PST) Message-ID: <918b9dc0-9af0-a62a-19cc-cb858b163299@gmail.com> Date: Mon, 4 Dec 2023 13:00:00 +0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.4.2 Subject: Re: collect_corrupt_items_vacuum.patch Content-Language: en-US To: Alexander Korotkov Cc: Daniel Gustafsson , Daniel Shelepanov , Nikita Malakhov , Michael Paquier , Robert Haas , Tom Lane , PostgreSQL Hackers , Andres Freund References: <1649062270.289865713@f403.i.mail.ru> <3107109.1658958956@sss.pgh.pa.us> <8e6bd629-fa69-371c-966d-aaf071aafeb8@gmail.com> From: Alexander Lakhin In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk Hi Alexander, 04.12.2023 03:23, Alexander Korotkov wrote: > I managed to reproduce this on a Linux VM. This problem should arise > because in extension I don't have access to ProcArrayStruct. So, my > code is iterating the whole PGPROC's array. I reimplemented the new > horizon calculation function in the core with usage of > ProcArrayStruct. Now it doesn't fall for me. Please, recheck. Yes, v4 works for me as well (thousands of iterations passed). Thank you! Though the test passes even without manipulations with the PROC_IN_VACUUM flag in pg_visibility.c (maybe the test is not good enough to show why those manipulations are needed). I also couldn't see where VISHORIZON_DATA_STRICT comes into play... Best regards, Alexander