Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bfp0T-0007TP-CH for pgsql-hackers@arkaria.postgresql.org; Fri, 02 Sep 2016 13:59:45 +0000 Received: from localhost ([127.0.0.1] helo=postgresql.org) by malur.postgresql.org with smtp (Exim 4.84_2) (envelope-from ) id 1bfp0S-0002tP-Pp for pgsql-hackers@arkaria.postgresql.org; Fri, 02 Sep 2016 13:59:44 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1bfp0S-0002tJ-EH for pgsql-hackers@postgresql.org; Fri, 02 Sep 2016 13:59:44 +0000 Received: from sss.pgh.pa.us ([66.207.139.130]) by magus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1bfp0P-0001VA-PA for pgsql-hackers@postgresql.org; Fri, 02 Sep 2016 13:59:43 +0000 Received: from sss1.sss.pgh.pa.us (localhost [127.0.0.1]) by sss.pgh.pa.us (8.14.4/8.14.4) with ESMTP id u82DxNd6009195; Fri, 2 Sep 2016 09:59:23 -0400 From: Tom Lane To: Michael Paquier cc: Heikki Linnakangas , David Steele , Robert Haas , David Fetter , Alvaro Herrera , Magnus Hagander , Peter Eisentraut , Julian Markwort , Stephen Frost , PostgreSQL mailing lists , Valery Popov Subject: Re: Password identifiers, protocol aging and SCRAM protocol In-reply-to: References: <20160720181257.GA686053@alvherre.pgsql> <20160720202524.GA16111@fetter.org> <88f35221-2abd-6a31-a75d-28a3dc3a5b30@pgmasters.net> <29704.1469122290@sss.pgh.pa.us> <19611.1469144923@sss.pgh.pa.us> <20190.1469145748@sss.pgh.pa.us> <69938195-9c76-8523-0af8-eb718ea5b36e@iki.fi> <7fccb99f-8465-7ac8-72d5-3f41e90ae280@iki.fi> <47be24f5-12a5-7af8-efc0-9486a7dbd413@iki.fi> Comments: In-reply-to Michael Paquier message dated "Fri, 02 Sep 2016 22:23:46 +0900" Date: Fri, 02 Sep 2016 09:59:23 -0400 Message-ID: <9194.1472824763@sss.pgh.pa.us> X-Pg-Spam-Score: -3.4 (---) List-Archive: List-Help: List-ID: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: X-Mailing-List: pgsql-hackers Precedence: bulk Sender: pgsql-hackers-owner@postgresql.org Michael Paquier writes: > Before I send a new series of patches... There is one thing that I am > still troubled with: the compilation of pgcrypto. First from > contrib/pgcrypto/Makefile I am noticing the following issue with this > block: > CF_SRCS = $(if $(subst no,,$(with_openssl)), $(OSSL_SRCS), $(INT_SRCS)) > CF_TESTS = $(if $(subst no,,$(with_openssl)), $(OSSL_TESTS), $(INT_TESTS)) > CF_PGP_TESTS = $(if $(subst no,,$(with_zlib)), $(ZLIB_TST), $(ZLIB_OFF_TST)) > How is that correct if src/Makefile.global is not loaded first? > Variables like with_openssl are still not loaded at that point. Um, you do know that Make treats "=" definitions of variables as, essentially, macro definitions? The fact that with_openssl isn't set yet doesn't necessarily mean these definitions are wrong. Is it actually not working for you, or are you just not understanding why it works? regards, tom lane -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers