Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1uOOJH-002yQ2-RP for pgsql-hackers@arkaria.postgresql.org; Sun, 08 Jun 2025 22:16:11 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.94.2) (envelope-from ) id 1uOOJF-003h8g-Uz for pgsql-hackers@arkaria.postgresql.org; Sun, 08 Jun 2025 22:16:10 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1uOOJF-003h8Y-LT for pgsql-hackers@lists.postgresql.org; Sun, 08 Jun 2025 22:16:10 +0000 Received: from relay7-d.mail.gandi.net ([217.70.183.200]) by makus.postgresql.org with smtp (Exim 4.96) (envelope-from ) id 1uOOJD-000yPo-1n for pgsql-hackers@lists.postgresql.org; Sun, 08 Jun 2025 22:16:09 +0000 Received: by mail.gandi.net (Postfix) with ESMTPSA id 4D18C431D8; Sun, 8 Jun 2025 22:16:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=vondra.me; s=gm1; t=1749420965; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=mv9lf9PAR7GsstPG3ZlCx5CdYk1Xs4YTmRbCLu65mNk=; b=MIeEU+gnp8yeDnwGJGvvLsw58RPG+l4yCPGzKfPSbDZB3PLlXIQfQt5wY0ojzCZ9M6fYlE xnexJDNoB8J6+ZjZPHpyqDu2kddEfnd6WGhblX6BcLjDQpuZ1h/3g5YSbf+UWaul7xyDdl 864snm2YvmgrFOn8iEGuZUIj0mitZ9Ft+1W03LHQeM2EgZArC6CYjyM7v8pkB+DN+mb9Ag 1NloMj9F69vjOadzDbYmXCspPvCrC2u5urTpEkp0oWwtT92XB1MWp3GQMQURxxxJIisspu rzBhMq+Vja9YLt3r7OHuizv8/E6Xln3O+hTx50U5g9nIsSfZKSxY8ax64bn7GQ== Message-ID: <91940217-2b88-4590-8e77-6c7555d07db5@vondra.me> Date: Mon, 9 Jun 2025 00:16:04 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: amcheck support for BRIN indexes To: Arseniy Mukhin , PostgreSQL Hackers References: Content-Language: en-US From: Tomas Vondra In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-GND-State: clean X-GND-Score: -100 X-GND-Cause: gggruggvucftvghtrhhoucdtuddrgeeffedrtddugdekgeegucetufdoteggodetrfdotffvucfrrhhofhhilhgvmecuifetpfffkfdpucggtfgfnhhsuhgsshgtrhhisggvnecuuegrihhlohhuthemuceftddunecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenucfjughrpefkffggfgfuvfhfhfgjtgfgsehtjeertddtvdejnecuhfhrohhmpefvohhmrghsucggohhnughrrgcuoehtohhmrghssehvohhnughrrgdrmhgvqeenucggtffrrghtthgvrhhnpeduteekueelffegueffveeigeekvdeluefgvefgffeugfekheeufeeitefhlefhkeenucfkphepkeeirdegledrvdeftddrvddtieenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepihhnvghtpeekiedrgeelrddvfedtrddvtdeipdhhvghloheplgdutddrudefjedrtddrvdgnpdhmrghilhhfrhhomhepthhomhgrshesvhhonhgurhgrrdhmvgdpnhgspghrtghpthhtohepvddprhgtphhtthhopegrrhhsvghnihihrdhmuhhkhhhinhdruggvvhesghhmrghilhdrtghomhdprhgtphhtthhopehpghhsqhhlqdhhrggtkhgvrhhssehlihhsthhsrdhpohhsthhgrhgvshhqlhdrohhrgh X-GND-Sasl: tomas@vondra.me List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk On 6/8/25 14:39, Arseniy Mukhin wrote: > Hi, > > Here is a new version. > > TAP tests were added. Tried to reproduce more or less every violation. > I don't include 2 tests where disk representation ItemIdData needs to > be changed: it works locally, but I don't think these tests are > portable. While writing tests some minor issues were found and fixed. > Also ci compiler warnings were fixed. > Thanks. I've added myself as a reviewer, so that I don't forget about this for the next CF. regards -- Tomas Vondra