Message-ID: <91f7c1b8-c102-afc4-eb85-9d929141c645@dunslane.net>
Date: Sun, 15 Jan 2023 08:21:21 -0500
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.5.0
Subject: Re: Extracting cross-version-upgrade knowledge from buildfarm client
Content-Language: en-US
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Michael Paquier <michael@paquier.xyz>, pgsql-hackers@lists.postgresql.org
References: <891521.1673657296@sss.pgh.pa.us>
 <700055c2-e5e9-6d00-09cf-5b9666a1d17b@dunslane.net>
 <1004356.1673711255@sss.pgh.pa.us> <1199696.1673726766@sss.pgh.pa.us>
From: Andrew Dunstan <andrew@dunslane.net>
In-Reply-To: <1199696.1673726766@sss.pgh.pa.us>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
Archived-At: <https://www.postgresql.org/message-id/91f7c1b8-c102-afc4-eb85-9d929141c645%40dunslane.net>
Precedence: bulk


On 2023-01-14 Sa 15:06, Tom Lane wrote:
> I wrote:
>> OK, I'll take a look at that and make a new draft.
> Here's version 2, incorporating your suggestions and with some
> further work to make it handle 9.2 fully.  I think this could
> be committable so far as HEAD is concerned, though I still
> need to make versions of AdjustUpgrade.pm for the back branches.


This looks pretty good to me.

I'll probably change this line

   my $adjust_cmds = adjust_database_contents($oversion, %dbnames);

so it's only called if the old and new versions are different. Is there
any case where a repo shouldn't be upgradeable to its own version
without adjustment?


cheers


andrew

--
Andrew Dunstan
EDB: https://www.enterprisedb.com