From: Tom Lane <tgl@sss.pgh.pa.us>
To: Robert Haas <robertmhaas@gmail.com>
cc: Hao Zhang <zhrt1446384557@gmail.com>, Andres Freund <andres@anarazel.de>,
        pgsql-hackers@lists.postgresql.org
Subject: Re: [PATCH] plpython function causes server panic
In-reply-to: <CA+TgmoZpk+dXtNDLvfO9MdJzMh-RCjJS3_SE7+jT0URCdSGeVg@mail.gmail.com>
References: <CALY6Dr-2yLVeVPhNMhuBnRgOZo1UjoTETgtKBx1B2gUi8yy+3g@mail.gmail.com> <301509.1701479055@sss.pgh.pa.us> <307441.1701481871@sss.pgh.pa.us> <CALY6Dr8fPasw5DP3FFD2YjRZMKeX9_Ank14tz_bmPjjqLB1U7g@mail.gmail.com> <976744.1701813393@sss.pgh.pa.us> <3224351.1703872552@sss.pgh.pa.us> <CA+TgmoZpk+dXtNDLvfO9MdJzMh-RCjJS3_SE7+jT0URCdSGeVg@mail.gmail.com>
Comments: In-reply-to Robert Haas <robertmhaas@gmail.com>
	message dated "Fri, 22 Mar 2024 11:39:43 -0400"
MIME-Version: 1.0
Content-Type: text/plain; charset="UTF-8"
Content-ID: <920166.1711122660.1@sss.pgh.pa.us>
Content-Transfer-Encoding: 8bit
Date: Fri, 22 Mar 2024 11:51:00 -0400
Message-ID: <920167.1711122660@sss.pgh.pa.us>
Archived-At: <https://www.postgresql.org/message-id/920167.1711122660%40sss.pgh.pa.us>
Precedence: bulk

Robert Haas <robertmhaas@gmail.com> writes:
> On Fri, Dec 29, 2023 at 12:56 PM Tom Lane <tgl@sss.pgh.pa.us> wrote:
>> Here's a draft patch along this line.  Basically the idea is that
>> subtransactions used for error control are now legal in parallel
>> mode (including in parallel workers) so long as they don't try to
>> acquire their own XIDs.  I had to clean up some error handling
>> in xact.c, but really this is a pretty simple patch.

> I agree with the general direction. A few comments:

Thanks for looking at this!  I was hoping you'd review it, because
I thought there was a pretty significant chance that I'd missed some
fundamental reason it couldn't work.  I feel better now about it
being worth pursuing.

I consider the patch draft quality at this point: I didn't spend
much effort on docs or comments, and none on test cases.  I'll
work on those issues and come back with a v2.

			regards, tom lane