Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1muGVI-0006lN-9b for pgsql-hackers@arkaria.postgresql.org; Mon, 06 Dec 2021 16:06:12 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1muGVH-0003X2-4P for pgsql-hackers@arkaria.postgresql.org; Mon, 06 Dec 2021 16:06:11 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1muGVG-0003Ws-F6 for pgsql-hackers@lists.postgresql.org; Mon, 06 Dec 2021 16:06:10 +0000 Received: from mail-pj1-x102d.google.com ([2607:f8b0:4864:20::102d]) by magus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1muGVC-0002bs-45 for pgsql-hackers@lists.postgresql.org; Mon, 06 Dec 2021 16:06:09 +0000 Received: by mail-pj1-x102d.google.com with SMTP id fv9-20020a17090b0e8900b001a6a5ab1392so235932pjb.1 for ; Mon, 06 Dec 2021 08:06:05 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=enterprisedb.com; s=google; h=mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; bh=YwW7fikneBdAoIAdjxsxzQ2fr17DZwtLxBz+9oeIElI=; b=WLW4in3hnOD353/tiRh0tj4OGHylcMku5Fv8aZczFWLKG+XUqmHCWiJ5wl9UW7tc5Y DtAWF+DMfkWflYq4D5+J5LaTYjmoRoPynzYZQDSvd/CMJH7GtXsj/B1kpIzdO7TnuwNL RG0z4FOSOrq6H3qSpCAyqirRouEfxyLutW44KFbOTNjpOOep6OXgVGhYwE39zWyxeNaL T+mgS5VnO1lsR6p11AHZFq1K1U+KoIHuL0w1EOqM2UBL1B++2X1D/RSIm91YjGYK9qOZ t2iJAW7i+CGsQdnzF9DuBMU/xjPByqqBYikxKSbw0vy7PoSi/updL7XNLZv1mHR33GB4 J8dw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; bh=YwW7fikneBdAoIAdjxsxzQ2fr17DZwtLxBz+9oeIElI=; b=E9iK0jsn6UG7764o+FXlya00RfXw/kqRmke6Z+zdFoSqMVib6yZO9K23qSRO+s+2LH GWdvuLgOqs9S0e3FFmGsDbf92/cU9irAxjrXnodOl2orkR84Wyqi6izmlOQgMiW6aDtH XVA7Ncnvm7VJDso+V3nUsmcrIGnfEzZCMJy0kcdWzXdh1A76A0YW+D/5QfP0WV9V6Mbf mFvwAtjaemsu4z1Kp7jwrge1ZfjJbeE8NMRpHe+Xr8FiQqMgD4JQWSiux73EGrqnqehD /itiDNR/9SG69shG7oS4R4lgRmqgewZyUA+obFhe09I+2mUrC5gb8QnEwOhL8lLbruT4 i5ng== X-Gm-Message-State: AOAM5332yE5YJ5iu751WEkzPw6Nj3bxBOSegmIkTQiH+6Tk+JO12EhfU a3nmLSDBcBF0wjENh3xC/xO1j4f3QVIakz9HPzT836i/0xQgUu2NmEEWiXrR/oAR56FJYK6XjJm X9cYlseo2ySQYhsjSIZ3RAUkjQDQsianWGMgnv4iwS91dyHyS9VelZqdbhkH/xzjN4grHKAJFKC GGxlXDMjeSgndgnKMItJY/8e/+zvippOTV9wHc4ur4QCpaj2xfPcIt X-Google-Smtp-Source: ABdhPJx1DKUna2OltE7rhAKZD2NPacBARNLVPLeyYclJU2xm+6Fz/zv2Xyl47wXBkepOAFyrJ3x3dg== X-Received: by 2002:a17:902:c3cc:b0:141:be17:405e with SMTP id j12-20020a170902c3cc00b00141be17405emr44562361plj.76.1638806763647; Mon, 06 Dec 2021 08:06:03 -0800 (PST) Received: from laptop280-ma-us.hitronhub.home (24-113-193-150.wavecable.com. [24.113.193.150]) by smtp.gmail.com with ESMTPSA id h186sm12893873pfg.64.2021.12.06.08.06.02 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Mon, 06 Dec 2021 08:06:03 -0800 (PST) Content-Type: text/plain; charset=utf-8 Mime-Version: 1.0 (Mac OS X Mail 13.4 \(3608.120.23.2.7\)) Subject: Re: Optionally automatically disable logical replication subscriptions on error From: Mark Dilger In-Reply-To: Date: Mon, 6 Dec 2021 08:06:02 -0800 Cc: Amit Kapila , vignesh C , Greg Nancarrow , Masahiko Sawada , "Smith, Peter" , PostgreSQL Hackers Content-Transfer-Encoding: quoted-printable Message-Id: <92A72C94-42DC-4873-8CBD-95518154E4B3@enterprisedb.com> References: To: "osumi.takamichi@fujitsu.com" X-Mailer: Apple Mail (2.3608.120.23.2.7) X-CLOUD-SEC-AV-Info: enterprisedb,google_mail,monitor X-CLOUD-SEC-AV-Sent: true X-Gm-Spam: 0 X-Gm-Phishy: 0 List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk > On Dec 5, 2021, at 10:56 PM, osumi.takamichi@fujitsu.com wrote: >=20 > In my humble opinion, I felt the original purpose of the patch was to = partially remedy > the situation that during the failure of apply, the apply process = keeps going > into the infinite error loop. I agree. > I'd say that in this sense, if we include such resource errors, we = fail to achieve > the purpose in some cases, because of some left possibilities of = infinite loop. > Disabling the subscription with even one any error excludes this = irregular possibility, > since there's no room to continue the infinite loop. I don't think there is any right answer here. It's a question of policy = preferences. My concern about disabling a subscription in response to *any* error is = that people may find the feature does more harm than good. Disabling = the subscription in response to an occasional deadlock against other = database users, or occasional resource pressure, might annoy people and = lead to the feature simply not being used. I am happy to defer to your policy preference. Thanks for your work on = the patch! =E2=80=94 Mark Dilger EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company