Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1wUtuO-001WiE-2l for pgsql-hackers@arkaria.postgresql.org; Wed, 03 Jun 2026 22:17:57 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.96) (envelope-from ) id 1wUtuN-003fzS-20 for pgsql-hackers@arkaria.postgresql.org; Wed, 03 Jun 2026 22:17:55 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1wUtuN-003fzK-0Y for pgsql-hackers@lists.postgresql.org; Wed, 03 Jun 2026 22:17:55 +0000 Received: from mail-pj1-x1031.google.com ([2607:f8b0:4864:20::1031]) by magus.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.98.2) (envelope-from ) id 1wUtuK-0000000180G-2lC8 for pgsql-hackers@lists.postgresql.org; Wed, 03 Jun 2026 22:17:54 +0000 Received: by mail-pj1-x1031.google.com with SMTP id 98e67ed59e1d1-36b903567fdso14748a91.1 for ; Wed, 03 Jun 2026 15:17:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1780525070; x=1781129870; darn=lists.postgresql.org; h=references:to:cc:in-reply-to:date:subject:mime-version:message-id :from:from:to:cc:subject:date:message-id:reply-to; bh=WQmTCSW/ND2sZS7sWOK4ia0b6eQJKbCN/DxTnUCjl6M=; b=I7xFRpGMx4yBu9GGrAJNHXnkcBJPagNALxHN6CIN0BfmylWxjtCMyUBXvrflrzmjQD 0xekoFUrD153IdndZup3gxA+FPhenHgMv47CpcYvdxMJq7kInw9bAVycOyThq3qYOLkM OvdEHlr4wznqMKyflh/ts/j3382tM/xcvrh3L+nZ5CrpfgYSmc/q4zgHtANiB+jXAvwJ Esx9c4R5/eqq9V3VKa/lP6cutbsNy6jnK2ABPuHmv3EvNIIZvEcBKK8HwCsLVeBrgJHh 6BmMypRHJJRCmkzAtdtCRKP/e8JPqWwIKQo7vQpmK4k7EgZIujn5pIq3S4q1T1jmcIDO x5YA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1780525070; x=1781129870; h=references:to:cc:in-reply-to:date:subject:mime-version:message-id :from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=WQmTCSW/ND2sZS7sWOK4ia0b6eQJKbCN/DxTnUCjl6M=; b=CeKL/TLSe61hvdxq4ENmtm44Phgr4m6I4P7dsSdY1D5nvzIUw663adJSepMWhmAV6x sCDFnjmSxrYZvu304B9cAwPN4j8rLC/2avEjPqJVB0+ByANcg9BBOuAvuZfPJlP7ZscW Yovwz4Wg2kH1ptSnwYy8zHK73roLmtgT+jLxw8RWjPJ+CVxv6uhjgfyS/WOI/5AEpvNV RyDp0wo2OLXc4bUnalMBfEzqGeeoZnoXmLZ2neXJQ6HqRcTPx7Kpf2ZvenHooTapsatm x0LvlBMfahLc9+apSIYOi/T4aqi3oVusAuCsCOlAJT6Aq6OniuXHjC/vDBXrO2hKyTP5 855w== X-Gm-Message-State: AOJu0YwVyuCXbx56y6cKoD/uoPzgntJPrqKym6unMm4VaKfk5ASfRGti oOFeoVLFDaBzGPHyZ4OD8oYht/+/fRRPZMXF8/zLeiTeSd1F/HhBCEqz8KApzk/m X-Gm-Gg: Acq92OHqeCXrV1545Volu1vjVJFbyoNxnPl2NfvC13MhK6Q8nADdFt6kFffrSpgKn2J HjN3hJx2889Mtw9WPxnWyK6CgbLOTfsSuiGcy/cPWF3glK9pPZ/HfmDkC1Kz4TG0j9NX+yIgP1m H0nw3EdFkgMxMN5zeSELafwANSek59tF4mK+wB2dCS8jp9/rpsi6j/S9JhrmV/H3SJfvlTHt05T Ri+CdLmopIhvnnl9/LCbFoBDEUp22rb3Lteej0r62+WbsXNr17hF9a1cX2FB82V0ZFaVv/cqFAy YRfnapDJzbAJj/yIDNV1V2w12cVWmSF+X//ya61YIk/6XXVUflv5QyDZw93GrMLxIdv17ac8/pv /5sUO1oJDThy6RC2tKGrTJV61IcPw0oIlh+IqEWVMtPy0eSRbMiPGWkxaNA441mK3qjJCw4brm5 3uQaVxqARuUVcbpzXznd720QmKthiVVQaHmbSxHcTfJ2yjX5hYutQc X-Received: by 2002:a17:90a:f947:b0:368:ea0c:1b75 with SMTP id 98e67ed59e1d1-36e2eee0c89mr5043040a91.6.1780525070467; Wed, 03 Jun 2026 15:17:50 -0700 (PDT) Received: from smtpclient.apple ([45.32.121.103]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-36f6dba8573sm814256a91.14.2026.06.03.15.17.47 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Wed, 03 Jun 2026 15:17:49 -0700 (PDT) From: Chao Li Message-Id: <92CAD935-5ECE-46D8-B7D7-D8E3C991CC10@gmail.com> Content-Type: multipart/mixed; boundary="Apple-Mail=_902DCE80-2EFF-4B61-B809-51AF6AB0BAEA" Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3864.600.51.1.1\)) Subject: Re: Fix bug of CHECK constraint enforceability recursion Date: Thu, 4 Jun 2026 06:17:09 +0800 In-Reply-To: Cc: pgsql-hackers@lists.postgresql.org, jian he , Andrew Dunstan , =?utf-8?Q?=C3=81lvaro_Herrera?= To: Zsolt Parragi References: <33E9C4C2-B6A8-4FCC-BEEA-461EA5FB98C8@gmail.com> <7F0EA98A-6DBC-436A-8FF4-4A511A05ABE6@gmail.com> <7B7172F4-DB02-4259-997B-6AEF5ADF7FCE@gmail.com> <14E223D8-8425-446A-A36C-6B62BC334656@gmail.com> <9A3D388C-1DF4-4C43-9AB6-83529A8F48C8@gmail.com> X-Mailer: Apple Mail (2.3864.600.51.1.1) List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk --Apple-Mail=_902DCE80-2EFF-4B61-B809-51AF6AB0BAEA Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=utf-8 > On Jun 3, 2026, at 22:36, Zsolt Parragi = wrote: >=20 > Hello >=20 > After a bit more testing, I think there's still a remaining issue with > the latest patch: >=20 > create table root_t (a int constraint c check (a > 0) enforced); > create table p2 (a int constraint c check (a > 0) enforced); > create table d () inherits (root_t, p2); > create table e () inherits (d); > create table f () inherits (e); > alter table root_t alter constraint c not enforced; > insert into e values (-5); -- succeeds >=20 > d remains enforced as it should, but e and f doesn't. >=20 >=20 Thanks for your testing. Yeah, inheritance cases are really complicated. = find_all_inheritors() returns a list of the root plus its descendants, = but it cannot ensure that a parent always appears before its child. For = example: ``` create table gp(a int constraint c check (a > 0) enforced); create table d() inherits (gp); create table p1() inherits (gp); alter table d inherit p1; ``` In this case, d is a child of both gp and p1. But because d is created = before p1, d has a smaller OID than p1. So even though p1 is a parent of = d, d can still appear before p1 in the list, like gp -> d -> p1. That=E2=80=99s why I built the changing_conids list in the = implementation. But I wrongly assumed that all constraints in the list = would be updated to NOT ENFORCED. Your test case uncovered that this = assumption is wrong. So when a parent appears in changing_conids, we = have to recurse upward to see if there is a parent outside the current = ALTER TABLE that may affect the result. The fix is in = ATCheckCheckConstrHasEnforcedParent(). See attached v7 for details. With v7, your test case passes. I have = added this test case to the regression tests, and made it even more = complicated. ``` evantest=3D# create table root_t (a int constraint c check (a > 0) = enforced); CREATE TABLE evantest=3D# create table p2 (a int constraint c check (a > 0) = enforced); CREATE TABLE evantest=3D# create table d () inherits (root_t, p2); NOTICE: merging multiple inherited definitions of column "a" CREATE TABLE evantest=3D# create table e () inherits (d); CREATE TABLE evantest=3D# create table f () inherits (e); CREATE TABLE evantest=3D# alter table root_t alter constraint c not enforced; ALTER TABLE evantest=3D# evantest=3D# select conrelid::regclass as tbl, conenforced from = pg_constraint where conname =3D 'c'; tbl | conenforced --------+------------- d | YES e | YES f | YES root_t | NO p2 | YES (5 rows) ``` Now, both e and f remain ENFORCE. Best regards, -- Chao Li (Evan) HighGo Software Co., Ltd. https://www.highgo.com/ --Apple-Mail=_902DCE80-2EFF-4B61-B809-51AF6AB0BAEA Content-Disposition: attachment; filename=v7-0001-Prevent-inherited-CHECK-constraints-from-being-we.patch Content-Type: application/octet-stream; x-unix-mode=0644; name="v7-0001-Prevent-inherited-CHECK-constraints-from-being-we.patch" Content-Transfer-Encoding: quoted-printable =46rom=20eab7a1f5a038328cb2f688256db967ff7abd5d9a=20Mon=20Sep=2017=20= 00:00:00=202001=0AFrom:=20"Chao=20Li=20(Evan)"=20=0A= Date:=20Wed,=2027=20May=202026=2013:49:29=20+0800=0ASubject:=20[PATCH=20= v7=201/3]=20Prevent=20inherited=20CHECK=20constraints=20from=20being=0A=20= weakened=0A=0ADisallow=20marking=20an=20inherited=20CHECK=20constraint=20= as=20NOT=20ENFORCED=20when=20an=0Aequivalent=20parent=20constraint=20= remains=20ENFORCED.=20This=20prevents=20ALTER=0ACONSTRAINT=20from=20= producing=20a=20child=20constraint=20that=20is=20weaker=20than=20one=20= of=0Aits=20inherited=20parent=20definitions.=0A=0AWhen=20recursively=20= altering=20a=20CHECK=20constraint=20to=20NOT=20ENFORCED,=20collect=20the=0A= corresponding=20constraints=20in=20the=20affected=20inheritance=20= subtree=20and=20ignore=0Athose=20parent=20constraints=20while=20checking=20= descendants.=20If=20a=20descendant=20also=0Ainherits=20an=20equivalent=20= ENFORCED=20constraint=20from=20a=20parent=20outside=20the=0Acurrent=20= ALTER,=20keep=20the=20descendant=20ENFORCED=20by=20merging=20to=20the=20= stricter=0Astate.=0A=0AAdd=20regression=20coverage=20for=20direct=20= child=20ALTER,=20ONLY=20ALTER,=20mixed-parent=0Ainheritance,=20and=20a=20= common-ancestor=20diamond=20where=20all=20equivalent=20inherited=0A= constraints=20can=20be=20changed=20together.=0A=0AAuthor:=20Chao=20Li=20= =0AReviewed-by:=20Jian=20He=20= =0AReviewed-by:=20Zsolt=20Parragi=20= =0ADiscussion:=20= https://postgr.es/m/E74C57FA-1DD0-4C8E-8FB1-538034752592@gmail.com=0A---=0A= =20src/backend/commands/tablecmds.c=20=20=20=20=20=20=20=20=20=20|=20242=20= ++++++++++++++++++++--=0A=20src/test/regress/expected/constraints.out=20= |=20=2012=20+-=0A=20src/test/regress/expected/inherit.out=20=20=20=20=20= |=20=2090=20++++++++=0A=20src/test/regress/sql/constraints.sql=20=20=20=20= =20=20|=20=20=205=20+-=0A=20src/test/regress/sql/inherit.sql=20=20=20=20=20= =20=20=20=20=20|=20=2052=20+++++=0A=205=20files=20changed,=20376=20= insertions(+),=2025=20deletions(-)=0A=0Adiff=20--git=20= a/src/backend/commands/tablecmds.c=20b/src/backend/commands/tablecmds.c=0A= index=20a1845240a98..35afff39da9=20100644=0A---=20= a/src/backend/commands/tablecmds.c=0A+++=20= b/src/backend/commands/tablecmds.c=0A@@=20-437,6=20+437,7=20@@=20static=20= bool=20ATExecAlterFKConstrEnforceability(List=20**wqueue,=20= ATAlterConstraint=20*=0A=20static=20bool=20= ATExecAlterCheckConstrEnforceability(List=20**wqueue,=20= ATAlterConstraint=20*cmdcon,=0A=20=09=09=09=09=09=09=09=09=09=09=09=09=20= Relation=20conrel,=20HeapTuple=20contuple,=0A=20=09=09=09=09=09=09=09=09=09= =09=09=09=20bool=20recurse,=20bool=20recursing,=0A+=09=09=09=09=09=09=09=09= =09=09=09=09=20List=20*changing_conids,=0A=20=09=09=09=09=09=09=09=09=09=09= =09=09=20LOCKMODE=20lockmode);=0A=20static=20bool=20= ATExecAlterConstrDeferrability(List=20**wqueue,=20ATAlterConstraint=20= *cmdcon,=0A=20=09=09=09=09=09=09=09=09=09=09=20=20=20Relation=20conrel,=20= Relation=20tgrel,=20Relation=20rel,=0A@@=20-459,6=20+460,7=20@@=20static=20= void=20AlterFKConstrEnforceabilityRecurse(List=20**wqueue,=20= ATAlterConstraint=0A=20static=20void=20= AlterCheckConstrEnforceabilityRecurse(List=20**wqueue,=20= ATAlterConstraint=20*cmdcon,=0A=20=09=09=09=09=09=09=09=09=09=09=09=09=20= =20Relation=20conrel,=20Oid=20conrelid,=0A=20=09=09=09=09=09=09=09=09=09=09= =09=09=20=20bool=20recurse,=20bool=20recursing,=0A+=09=09=09=09=09=09=09=09= =09=09=09=09=20=20List=20*changing_conids,=0A=20=09=09=09=09=09=09=09=09=09= =09=09=09=20=20LOCKMODE=20lockmode);=0A=20static=20void=20= AlterConstrDeferrabilityRecurse(List=20**wqueue,=20ATAlterConstraint=20= *cmdcon,=0A=20=09=09=09=09=09=09=09=09=09=09=09Relation=20conrel,=20= Relation=20tgrel,=20Relation=20rel,=0A@@=20-466,6=20+468,10=20@@=20= static=20void=20AlterConstrDeferrabilityRecurse(List=20**wqueue,=20= ATAlterConstraint=20*cm=0A=20=09=09=09=09=09=09=09=09=09=09=09List=20= **otherrelids,=20LOCKMODE=20lockmode);=0A=20static=20void=20= AlterConstrUpdateConstraintEntry(ATAlterConstraint=20*cmdcon,=20Relation=20= conrel,=0A=20=09=09=09=09=09=09=09=09=09=09=09=20HeapTuple=20contuple);=0A= +static=20bool=20ATCheckCheckConstrHasEnforcedParent(Relation=20conrel,=20= Relation=20rel,=0A+=09=09=09=09=09=09=09=09=09=09=09=09HeapTuple=20= contuple,=0A+=09=09=09=09=09=09=09=09=09=09=09=09List=20= *changing_conids,=0A+=09=09=09=09=09=09=09=09=09=09=09=09Oid=20= *enforced_parentoid);=0A=20static=20ObjectAddress=20= ATExecValidateConstraint(List=20**wqueue,=0A=20=09=09=09=09=09=09=09=09=09= =09=09=20=20Relation=20rel,=20char=20*constrName,=0A=20=09=09=09=09=09=09= =09=09=09=09=09=20=20bool=20recurse,=20bool=20recursing,=20LOCKMODE=20= lockmode);=0A@@=20-477,6=20+483,7=20@@=20static=20void=20= QueueCheckConstraintValidation(List=20**wqueue,=20Relation=20conrel,=20= Relat=0A=20static=20void=20QueueNNConstraintValidation(List=20**wqueue,=20= Relation=20conrel,=20Relation=20rel,=0A=20=09=09=09=09=09=09=09=09=09=09= HeapTuple=20contuple,=20bool=20recurse,=20bool=20recursing,=0A=20=09=09=09= =09=09=09=09=09=09=09LOCKMODE=20lockmode);=0A+static=20bool=20= constraints_equivalent(HeapTuple=20a,=20HeapTuple=20b,=20TupleDesc=20= tupleDesc);=0A=20static=20int=09transformColumnNameList(Oid=20relId,=20= List=20*colList,=0A=20=09=09=09=09=09=09=09=09=09int16=20*attnums,=20Oid=20= *atttypids,=20Oid=20*attcollids);=0A=20static=20int=09= transformFkeyGetPrimaryKey(Relation=20pkrel,=20Oid=20*indexOid,=0A@@=20= -12484,7=20+12491,7=20@@=20ATExecAlterConstraintInternal(List=20= **wqueue,=20ATAlterConstraint=20*cmdcon,=0A=20=09=09else=20if=20= (currcon->contype=20=3D=3D=20CONSTRAINT_CHECK)=0A=20=09=09=09changed=20=3D= =20ATExecAlterCheckConstrEnforceability(wqueue,=20cmdcon,=20conrel,=0A=20= =09=09=09=09=09=09=09=09=09=09=09=09=09=09=20=20=20contuple,=20recurse,=20= false,=0A-=09=09=09=09=09=09=09=09=09=09=09=09=09=09=20=20=20lockmode);=0A= +=09=09=09=09=09=09=09=09=09=09=09=09=09=09=20=20=20NIL,=20lockmode);=0A=20= =09}=0A=20=09else=20if=20(cmdcon->alterDeferrability=20&&=0A=20=09=09=09=20= ATExecAlterConstrDeferrability(wqueue,=20cmdcon,=20conrel,=20tgrel,=20= rel,=0A@@=20-12671,12=20+12678,16=20@@=20= ATExecAlterFKConstrEnforceability(List=20**wqueue,=20ATAlterConstraint=20= *cmdcon,=0A=20static=20bool=0A=20= ATExecAlterCheckConstrEnforceability(List=20**wqueue,=20= ATAlterConstraint=20*cmdcon,=0A=20=09=09=09=09=09=09=09=09=09=20Relation=20= conrel,=20HeapTuple=20contuple,=0A-=09=09=09=09=09=09=09=09=09=20bool=20= recurse,=20bool=20recursing,=20LOCKMODE=20lockmode)=0A+=09=09=09=09=09=09= =09=09=09=20bool=20recurse,=20bool=20recursing,=0A+=09=09=09=09=09=09=09=09= =09=20List=20*changing_conids,=0A+=09=09=09=09=09=09=09=09=09=20LOCKMODE=20= lockmode)=0A=20{=0A=20=09Form_pg_constraint=20currcon;=0A=20=09Relation=09= rel;=0A=20=09bool=09=09changed=20=3D=20false;=0A=20=09List=09=20=20=20= *children=20=3D=20NIL;=0A+=09bool=09=09target_enforced=20=3D=20= cmdcon->is_enforced;=0A+=09Oid=09=09=09enforced_parentoid=20=3D=20= InvalidOid;=0A=20=0A=20=09/*=20Since=20this=20function=20recurses,=20it=20= could=20be=20driven=20to=20stack=20overflow=20*/=0A=20=09= check_stack_depth();=0A@@=20-12693,16=20+12704,56=20@@=20= ATExecAlterCheckConstrEnforceability(List=20**wqueue,=20= ATAlterConstraint=20*cmdcon,=0A=20=09=20*/=0A=20=09rel=20=3D=20= table_open(currcon->conrelid,=20NoLock);=0A=20=0A-=09if=20= (currcon->conenforced=20!=3D=20cmdcon->is_enforced)=0A+=09/*=0A+=09=20*=20= When=20setting=20a=20constraint=20to=20NOT=20ENFORCED,=20check=20whether=20= any=20matching=0A+=09=20*=20parent=20constraint=20remains=20ENFORCED=20= and=20is=20not=20part=20of=20this=20ALTER.=0A+=09=20*=0A+=09=20*=20For=20= a=20direct=20ALTER=20of=20an=20inherited=20constraint,=20reject=20the=20= command,=0A+=09=20*=20because=20the=20child=20cannot=20be=20weakened=20= while=20its=20parent=20remains=20enforced.=0A+=09=20*=0A+=09=20*=20= During=20recursion,=20another=20parent=20outside=20this=20ALTER=20may=20= still=20enforce=0A+=09=20*=20the=20same=20constraint=20in=20a=20regular=20= inheritance=20hierarchy.=20In=20that=20case,=0A+=09=20*=20keep=20the=20= child=20constraint=20ENFORCED=20so=20that=20its=20merged=20= enforceability=0A+=09=20*=20still=20reflects=20the=20remaining=20= enforced=20parent.=20Partitions=20do=20not=20need=0A+=09=20*=20this=20= recursive=20parent=20check=20because=20a=20partition=20can=20have=20only=20= one=0A+=09=20*=20direct=20parent.=0A+=09=20*/=0A+=09if=20= (!cmdcon->is_enforced=20&&=0A+=09=09(!recursing=20||=20= !rel->rd_rel->relispartition)=20&&=0A+=09=09= ATCheckCheckConstrHasEnforcedParent(conrel,=20rel,=20contuple,=0A+=09=09=09= =09=09=09=09=09=09=09=09changing_conids,=0A+=09=09=09=09=09=09=09=09=09=09= =09&enforced_parentoid))=0A=20=09{=0A-=09=09= AlterConstrUpdateConstraintEntry(cmdcon,=20conrel,=20contuple);=0A+=09=09= if=20(!recursing)=0A+=09=09=09ereport(ERROR,=0A+=09=09=09=09=09= errcode(ERRCODE_INVALID_OBJECT_DEFINITION),=0A+=09=09=09=09=09= errmsg("cannot=20mark=20inherited=20constraint=20\"%s\"=20as=20NOT=20= ENFORCED=20because=20"=0A+=09=09=09=09=09=09=20=20=20"matching=20= constraint=20on=20parent=20table=20\"%s\"=20is=20ENFORCED",=0A+=09=09=09=09= =09=09=20=20=20NameStr(currcon->conname),=0A+=09=09=09=09=09=09=20=20=20= get_rel_name(enforced_parentoid)));=0A+=0A+=09=09target_enforced=20=3D=20= true;=0A+=09}=0A+=0A+=09/*=0A+=09=20*=20Update=20to=20the=20merged=20= enforceability=20if=20needed.=20This=20may=20differ=20from=20the=0A+=09=20= *=20requested=20enforceability=20when=20another=20matching=20parent=20= constraint=0A+=09=20*=20remains=20enforced.=0A+=09=20*/=0A+=09if=20= (currcon->conenforced=20!=3D=20target_enforced)=0A+=09{=0A+=09=09= ATAlterConstraint=20updatecon=20=3D=20*cmdcon;=0A+=0A+=09=09= updatecon.is_enforced=20=3D=20target_enforced;=0A+=09=09= AlterConstrUpdateConstraintEntry(&updatecon,=20conrel,=20contuple);=0A=20= =09=09changed=20=3D=20true;=0A=20=09}=0A=20=0A=20=09/*=0A=20=09=20*=20= Note=20that=20we=20must=20recurse=20even=20when=20trying=20to=20change=20= a=20check=20constraint=0A=20=09=20*=20to=20not=20enforced=20if=20it=20is=20= already=20not=20enforced,=20in=20case=20descendant=0A-=09=20*=20= constraints=20might=20be=20enforced=20and=20need=20to=20be=20changed=20= to=20not=20enforced.=0A+=09=20*=20constraints=20might=20be=20enforced=20= and=20need=20to=20be=20changed=20to=20not=20enforced,=0A+=09=20*=20= unless=20they=20still=20inherit=20an=20enforced=20constraint=20from=20= another=20parent.=0A=20=09=20*=20Conversely,=20we=20should=20do=20= nothing=20if=20a=20constraint=20is=20being=20set=20to=0A=20=09=20*=20= enforced=20and=20is=20already=20enforced,=20as=20descendant=20= constraints=20cannot=20be=0A=20=09=20*=20different=20in=20that=20case.=0A= @@=20-12715,28=20+12766,62=20@@=20= ATExecAlterCheckConstrEnforceability(List=20**wqueue,=20= ATAlterConstraint=20*cmdcon,=0A=20=09=09=20*=20try=20to=20look=20for=20= it=20in=20the=20children.=0A=20=09=09=20*/=0A=20=09=09if=20(!recursing=20= &&=20!currcon->connoinherit)=0A+=09=09{=0A+=09=09=09= Assert(changing_conids=20=3D=3D=20NIL);=0A+=0A=20=09=09=09children=20=3D=20= find_all_inheritors(RelationGetRelid(rel),=0A=20=09=09=09=09=09=09=09=09=09= =09=20=20=20lockmode,=20NULL);=0A=20=0A+=09=09=09/*=0A+=09=09=09=20*=20= When=20setting=20NOT=20ENFORCED,=20build=20the=20set=20of=20equivalent=20= CHECK=0A+=09=09=09=20*=20constraints=20that=20this=20command=20will=20= attempt=20to=20change=20before=0A+=09=09=09=20*=20visiting=20= descendants.=20The=20root=20itself=20has=20already=20been=20checked=0A+=09= =09=09=20*=20above.=0A+=09=09=09=20*/=0A+=09=09=09if=20= (!cmdcon->is_enforced)=0A+=09=09=09=09changing_conids=20=3D=20= list_make1_oid(currcon->oid);=0A+=0A+=09=09=09foreach_oid(childoid,=20= children)=0A+=09=09=09{=0A+=09=09=09=09if=20(childoid=20=3D=3D=20= RelationGetRelid(rel))=0A+=09=09=09=09=09continue;=0A+=0A+=09=09=09=09/*=0A= +=09=09=09=09=20*=20If=20we=20are=20told=20not=20to=20recurse,=20there=20= had=20better=20not=20be=20any=0A+=09=09=09=09=20*=20child=20tables,=20= because=20we=20can't=20change=20constraint=0A+=09=09=09=09=20*=20= enforceability=20on=20the=20parent=20unless=20we=20have=20changed=0A+=09=09= =09=09=20*=20enforceability=20for=20all=20child.=0A+=09=09=09=09=20*/=0A= +=09=09=09=09if=20(!recurse)=0A+=09=09=09=09=09ereport(ERROR,=0A+=09=09=09= =09=09=09=09errcode(ERRCODE_INVALID_TABLE_DEFINITION),=0A+=09=09=09=09=09= =09=09errmsg("constraint=20must=20be=20altered=20on=20child=20tables=20= too"),=0A+=09=09=09=09=09=09=09errhint("Do=20not=20specify=20the=20ONLY=20= keyword."));=0A+=0A+=09=09=09=09/*=0A+=09=09=09=09=20*=20It=20is=20= sufficient=20to=20look=20up=20the=20constraint=20by=20name=20here.=0A+=09= =09=09=09=20*=20Supported=20DDL=20ensures=20that=20inheritable=20CHECK=20= constraints=0A+=09=09=09=09=20*=20with=20the=20same=20name=20have=20= equivalent=20definitions=20when=20they=0A+=09=09=09=09=20*=20are=20= propagated=20to=20children=20or=20when=20inheritance=20is=0A+=09=09=09=09= =20*=20established.=0A+=09=09=09=09=20*/=0A+=09=09=09=09if=20= (!cmdcon->is_enforced)=0A+=09=09=09=09=09changing_conids=20=3D=0A+=09=09=09= =09=09=09list_append_unique_oid(changing_conids,=0A+=09=09=09=09=09=09=09= =09=09=09=09=20=20=20get_relation_constraint_oid(childoid,=0A+=09=09=09=09= =09=09=09=09=09=09=09=09=09=09=09=09=09=09=20=20=20cmdcon->conname,=0A+=09= =09=09=09=09=09=09=09=09=09=09=09=09=09=09=09=09=09=20=20=20false));=0A+=09= =09=09}=0A+=09=09}=0A+=0A=20=09=09foreach_oid(childoid,=20children)=0A=20= =09=09{=0A=20=09=09=09if=20(childoid=20=3D=3D=20RelationGetRelid(rel))=0A= =20=09=09=09=09continue;=0A=20=0A-=09=09=09/*=0A-=09=09=09=20*=20If=20we=20= are=20told=20not=20to=20recurse,=20there=20had=20better=20not=20be=20any=0A= -=09=09=09=20*=20child=20tables,=20because=20we=20can't=20change=20= constraint=20enforceability=0A-=09=09=09=20*=20on=20the=20parent=20= unless=20we=20have=20changed=20enforceability=20for=20all=0A-=09=09=09=20= *=20child.=0A-=09=09=09=20*/=0A-=09=09=09if=20(!recurse)=0A-=09=09=09=09= ereport(ERROR,=0A-=09=09=09=09=09=09= errcode(ERRCODE_INVALID_TABLE_DEFINITION),=0A-=09=09=09=09=09=09= errmsg("constraint=20must=20be=20altered=20on=20child=20tables=20too"),=0A= -=09=09=09=09=09=09errhint("Do=20not=20specify=20the=20ONLY=20= keyword."));=0A-=0A=20=09=09=09= AlterCheckConstrEnforceabilityRecurse(wqueue,=20cmdcon,=20conrel,=0A=20=09= =09=09=09=09=09=09=09=09=09=09=09=20=20childoid,=20false,=20true,=0A+=09=09= =09=09=09=09=09=09=09=09=09=09=20=20changing_conids,=0A=20=09=09=09=09=09= =09=09=09=09=09=09=09=20=20lockmode);=0A=20=09=09}=0A=20=09}=0A@@=20= -12748,7=20+12833,7=20@@=20ATExecAlterCheckConstrEnforceability(List=20= **wqueue,=20ATAlterConstraint=20*cmdcon,=0A=20=09=20*/=0A=20=09if=20= (rel->rd_rel->relkind=20=3D=3D=20RELKIND_RELATION=20&&=0A=20=09=09= !currcon->conenforced=20&&=0A-=09=09cmdcon->is_enforced)=0A+=09=09= target_enforced)=0A=20=09{=0A=20=09=09AlteredTableInfo=20*tab;=0A=20=09=09= NewConstraint=20*newcon;=0A@@=20-12788,6=20+12873,7=20@@=20static=20void=0A= =20AlterCheckConstrEnforceabilityRecurse(List=20**wqueue,=20= ATAlterConstraint=20*cmdcon,=0A=20=09=09=09=09=09=09=09=09=09=20=20= Relation=20conrel,=20Oid=20conrelid,=0A=20=09=09=09=09=09=09=09=09=09=20=20= bool=20recurse,=20bool=20recursing,=0A+=09=09=09=09=09=09=09=09=09=20=20= List=20*changing_conids,=0A=20=09=09=09=09=09=09=09=09=09=20=20LOCKMODE=20= lockmode)=0A=20{=0A=20=09SysScanDesc=20pscan;=0A@@=20-12817,11=20= +12903,129=20@@=20AlterCheckConstrEnforceabilityRecurse(List=20**wqueue,=20= ATAlterConstraint=20*cmdcon,=0A=20=09=09=09=09=09=20=20=20= cmdcon->conname,=20get_rel_name(conrelid)));=0A=20=0A=20=09= ATExecAlterCheckConstrEnforceability(wqueue,=20cmdcon,=20conrel,=20= childtup,=0A-=09=09=09=09=09=09=09=09=09=09=20recurse,=20recursing,=20= lockmode);=0A+=09=09=09=09=09=09=09=09=09=09=20recurse,=20recursing,=20= changing_conids,=0A+=09=09=09=09=09=09=09=09=09=09=20lockmode);=0A=20=0A=20= =09systable_endscan(pscan);=0A=20}=0A=20=0A+/*=0A+=20*=20When=20setting=20= an=20inherited=20CHECK=20constraint=20to=20NOT=20ENFORCED,=20look=20for=20= a=0A+=20*=20matching=20parent=20constraint=20that=20remains=20ENFORCED=20= and=20is=20not=20part=20of=20the=20same=0A+=20*=20ALTER.=0A+=20*/=0A= +static=20bool=0A+ATCheckCheckConstrHasEnforcedParent(Relation=20conrel,=20= Relation=20rel,=0A+=09=09=09=09=09=09=09=09=09HeapTuple=20contuple,=0A+=09= =09=09=09=09=09=09=09=09List=20*changing_conids,=0A+=09=09=09=09=09=09=09= =09=09Oid=20*enforced_parentoid)=0A+{=0A+=09Form_pg_constraint=20= currcon;=0A+=09Relation=09inhrel;=0A+=09SysScanDesc=20scan;=0A+=09= ScanKeyData=20skey;=0A+=09HeapTuple=09inheritsTuple;=0A+=0A+=09currcon=20= =3D=20(Form_pg_constraint)=20GETSTRUCT(contuple);=0A+=09= Assert(currcon->contype=20=3D=3D=20CONSTRAINT_CHECK);=0A+=0A+=09if=20= (currcon->coninhcount=20<=3D=200)=0A+=09=09return=20false;=0A+=0A+=09= inhrel=20=3D=20table_open(InheritsRelationId,=20AccessShareLock);=0A+=0A= +=09ScanKeyInit(&skey,=0A+=09=09=09=09Anum_pg_inherits_inhrelid,=0A+=09=09= =09=09BTEqualStrategyNumber,=20F_OIDEQ,=0A+=09=09=09=09= ObjectIdGetDatum(RelationGetRelid(rel)));=0A+=09scan=20=3D=20= systable_beginscan(inhrel,=20InheritsRelidSeqnoIndexId,=0A+=09=09=09=09=09= =09=09=20=20true,=20NULL,=201,=20&skey);=0A+=0A+=09while=20= (HeapTupleIsValid(inheritsTuple=20=3D=20systable_getnext(scan)))=0A+=09{=0A= +=09=09Oid=09=09=09parentoid;=0A+=09=09SysScanDesc=20pscan;=0A+=09=09= ScanKeyData=20pkey[3];=0A+=09=09HeapTuple=09parenttup;=0A+=0A+=09=09= parentoid=20=3D=20((Form_pg_inherits)=20= GETSTRUCT(inheritsTuple))->inhparent;=0A+=0A+=09=09ScanKeyInit(&pkey[0],=0A= +=09=09=09=09=09Anum_pg_constraint_conrelid,=0A+=09=09=09=09=09= BTEqualStrategyNumber,=20F_OIDEQ,=0A+=09=09=09=09=09= ObjectIdGetDatum(parentoid));=0A+=09=09ScanKeyInit(&pkey[1],=0A+=09=09=09= =09=09Anum_pg_constraint_contypid,=0A+=09=09=09=09=09= BTEqualStrategyNumber,=20F_OIDEQ,=0A+=09=09=09=09=09= ObjectIdGetDatum(InvalidOid));=0A+=09=09ScanKeyInit(&pkey[2],=0A+=09=09=09= =09=09Anum_pg_constraint_conname,=0A+=09=09=09=09=09= BTEqualStrategyNumber,=20F_NAMEEQ,=0A+=09=09=09=09=09= NameGetDatum(&currcon->conname));=0A+=0A+=09=09pscan=20=3D=20= systable_beginscan(conrel,=20ConstraintRelidTypidNameIndexId,=0A+=09=09=09= =09=09=09=09=09=20=20=20true,=20NULL,=203,=20pkey);=0A+=0A+=09=09while=20= (HeapTupleIsValid(parenttup=20=3D=20systable_getnext(pscan)))=0A+=09=09{=0A= +=09=09=09Form_pg_constraint=20parentcon;=0A+=0A+=09=09=09parentcon=20=3D=20= (Form_pg_constraint)=20GETSTRUCT(parenttup);=0A+=0A+=09=09=09if=20= (parentcon->contype=20!=3D=20CONSTRAINT_CHECK=20||=0A+=09=09=09=09= parentcon->connoinherit=20||=0A+=09=09=09=09!parentcon->conenforced)=0A+=09= =09=09=09continue;=0A+=0A+=09=09=09if=20= (constraints_equivalent(parenttup,=20contuple,=0A+=09=09=09=09=09=09=09=09= =09=20=20=20RelationGetDescr(conrel)))=0A+=09=09=09{=0A+=09=09=09=09/*=0A= +=09=09=09=09=20*=20A=20parent=20listed=20in=20changing_conids=20is=20= being=20changed=20by=20the=0A+=09=09=09=09=20*=20same=20ALTER,=20but=20= it=20may=20not=20have=20been=20updated=20yet.=20=20For=0A+=09=09=09=09=20= *=20regular=20inheritance,=20recurse=20upward=20to=20check=20whether=20= an=0A+=09=09=09=09=20*=20equivalent=20enforced=20parent=20outside=20the=20= ALTER=20will=20make=20it=0A+=09=09=09=09=20*=20remain=20enforced.=20=20= Partitions=20cannot=20have=20multiple=20parents,=0A+=09=09=09=09=20*=20= so=20they=20do=20not=20need=20this=20check.=0A+=09=09=09=09=20*/=0A+=09=09= =09=09if=20(!rel->rd_rel->relispartition=20&&=0A+=09=09=09=09=09= list_member_oid(changing_conids,=20parentcon->oid))=0A+=09=09=09=09{=0A+=09= =09=09=09=09Relation=09parentrel;=0A+=09=09=09=09=09Oid=09=09=09= parent_enforced_parentoid=20=3D=20InvalidOid;=0A+=0A+=09=09=09=09=09= parentrel=20=3D=20table_open(parentoid,=20NoLock);=0A+=0A+=09=09=09=09=09= if=20(!ATCheckCheckConstrHasEnforcedParent(conrel,=0A+=09=09=09=09=09=09=09= =09=09=09=09=09=09=09=09=20parentrel,=0A+=09=09=09=09=09=09=09=09=09=09=09= =09=09=09=09=20parenttup,=0A+=09=09=09=09=09=09=09=09=09=09=09=09=09=09=09= =20changing_conids,=0A+=09=09=09=09=09=09=09=09=09=09=09=09=09=09=09=20= &parent_enforced_parentoid))=0A+=09=09=09=09=09{=0A+=09=09=09=09=09=09= table_close(parentrel,=20NoLock);=0A+=09=09=09=09=09=09continue;=0A+=09=09= =09=09=09}=0A+=0A+=09=09=09=09=09table_close(parentrel,=20NoLock);=0A+=09= =09=09=09}=0A+=0A+=09=09=09=09*enforced_parentoid=20=3D=20parentoid;=0A+=09= =09=09=09systable_endscan(pscan);=0A+=09=09=09=09systable_endscan(scan);=0A= +=09=09=09=09table_close(inhrel,=20AccessShareLock);=0A+=09=09=09=09= return=20true;=0A+=09=09=09}=0A+=09=09}=0A+=0A+=09=09= systable_endscan(pscan);=0A+=09}=0A+=0A+=09systable_endscan(scan);=0A+=09= table_close(inhrel,=20AccessShareLock);=0A+=0A+=09return=20false;=0A+}=0A= +=0A=20/*=0A=20=20*=20Returns=20true=20if=20the=20constraint's=20= deferrability=20is=20altered.=0A=20=20*=0Adiff=20--git=20= a/src/test/regress/expected/constraints.out=20= b/src/test/regress/expected/constraints.out=0Aindex=20= e54fec7fb57..dada27a4cba=20100644=0A---=20= a/src/test/regress/expected/constraints.out=0A+++=20= b/src/test/regress/expected/constraints.out=0A@@=20-446,8=20+446,12=20@@=20= alter=20table=20parted_ch_2=20alter=20constraint=20cc_2=20enforced;=20= --error=0A=20ERROR:=20=20check=20constraint=20"cc_2"=20of=20relation=20= "parted_ch_2"=20is=20violated=20by=20some=20row=0A=20delete=20from=20= parted_ch=20where=20a=20=3D=2016;=0A=20alter=20table=20parted_ch_2=20= alter=20constraint=20cc_2=20enforced;=0A-alter=20table=20parted_ch_2=20= alter=20constraint=20cc=20not=20enforced;=0A-alter=20table=20parted_ch_2=20= alter=20constraint=20cc_1=20not=20enforced;=0A+alter=20table=20= parted_ch_2=20alter=20constraint=20cc=20not=20enforced;=20--error=0A= +ERROR:=20=20cannot=20mark=20inherited=20constraint=20"cc"=20as=20NOT=20= ENFORCED=20because=20matching=20constraint=20on=20parent=20table=20= "parted_ch"=20is=20ENFORCED=0A+alter=20table=20only=20parted_ch_2=20= alter=20constraint=20cc=20not=20enforced;=20--error=0A+ERROR:=20=20= cannot=20mark=20inherited=20constraint=20"cc"=20as=20NOT=20ENFORCED=20= because=20matching=20constraint=20on=20parent=20table=20"parted_ch"=20is=20= ENFORCED=0A+alter=20table=20parted_ch_2=20alter=20constraint=20cc_1=20= not=20enforced;=20--error=0A+ERROR:=20=20cannot=20mark=20inherited=20= constraint=20"cc_1"=20as=20NOT=20ENFORCED=20because=20matching=20= constraint=20on=20parent=20table=20"parted_ch"=20is=20ENFORCED=0A=20= alter=20table=20parted_ch_2=20alter=20constraint=20cc_2=20not=20= enforced;=0A=20--check=20these=20CHECK=20constraint=20status=20again=0A=20= select=20*=20from=20check_constraint_status;=0A@@=20-457,12=20+461,12=20= @@=20select=20*=20from=20check_constraint_status;=0A=20=20cc=20=20=20=20=20= =20|=20parted_ch_1=20=20|=20t=20=20=20=20=20=20=20=20=20=20=20|=20t=0A=20= =20cc=20=20=20=20=20=20|=20parted_ch_11=20|=20t=20=20=20=20=20=20=20=20=20= =20=20|=20t=0A=20=20cc=20=20=20=20=20=20|=20parted_ch_12=20|=20t=20=20=20= =20=20=20=20=20=20=20=20|=20t=0A-=20cc=20=20=20=20=20=20|=20parted_ch_2=20= =20|=20f=20=20=20=20=20=20=20=20=20=20=20|=20f=0A+=20cc=20=20=20=20=20=20= |=20parted_ch_2=20=20|=20t=20=20=20=20=20=20=20=20=20=20=20|=20t=0A=20=20= cc_1=20=20=20=20|=20parted_ch=20=20=20=20|=20t=20=20=20=20=20=20=20=20=20= =20=20|=20t=0A=20=20cc_1=20=20=20=20|=20parted_ch_1=20=20|=20t=20=20=20=20= =20=20=20=20=20=20=20|=20t=0A=20=20cc_1=20=20=20=20|=20parted_ch_11=20|=20= t=20=20=20=20=20=20=20=20=20=20=20|=20t=0A=20=20cc_1=20=20=20=20|=20= parted_ch_12=20|=20t=20=20=20=20=20=20=20=20=20=20=20|=20t=0A-=20cc_1=20=20= =20=20|=20parted_ch_2=20=20|=20f=20=20=20=20=20=20=20=20=20=20=20|=20f=0A= +=20cc_1=20=20=20=20|=20parted_ch_2=20=20|=20t=20=20=20=20=20=20=20=20=20= =20=20|=20t=0A=20=20cc_2=20=20=20=20|=20parted_ch_2=20=20|=20f=20=20=20=20= =20=20=20=20=20=20=20|=20f=0A=20(11=20rows)=0A=20=0Adiff=20--git=20= a/src/test/regress/expected/inherit.out=20= b/src/test/regress/expected/inherit.out=0Aindex=20= 3d8e8d8afd2..4c17a96cce0=20100644=0A---=20= a/src/test/regress/expected/inherit.out=0A+++=20= b/src/test/regress/expected/inherit.out=0A@@=20-1479,6=20+1479,96=20@@=20= NOTICE:=20=20drop=20cascades=20to=203=20other=20objects=0A=20DETAIL:=20=20= drop=20cascades=20to=20table=20p1_c1=0A=20drop=20cascades=20to=20table=20= p1_c2=0A=20drop=20cascades=20to=20table=20p1_c3=0A+--=20an=20inherited=20= CHECK=20constraint=20cannot=20be=20NOT=20ENFORCED=20under=20an=20= ENFORCED=20parent=0A+create=20table=20p1(f1=20int=20constraint=20= p1_a_check=20check=20(f1=20>=200)=20enforced);=0A+create=20table=20= p1_c1()=20inherits(p1);=0A+alter=20table=20p1_c1=20alter=20constraint=20= p1_a_check=20not=20enforced;=20--error=0A+ERROR:=20=20cannot=20mark=20= inherited=20constraint=20"p1_a_check"=20as=20NOT=20ENFORCED=20because=20= matching=20constraint=20on=20parent=20table=20"p1"=20is=20ENFORCED=0A= +alter=20table=20p1=20alter=20constraint=20p1_a_check=20not=20enforced;=20= --ok=0A+alter=20table=20p1_c1=20alter=20constraint=20p1_a_check=20not=20= enforced;=20--ok=0A+drop=20table=20p1=20cascade;=0A+NOTICE:=20=20drop=20= cascades=20to=20table=20p1_c1=0A+--=20recursive=20NOT=20ENFORCED=20= merges=20with=20ENFORCED=20constraints=20from=20other=20parents=0A= +create=20table=20p1(a=20int=20constraint=20p1_a_check=20check=20(a=20>=20= 0)=20enforced);=0A+create=20table=20p2(a=20int=20constraint=20p1_a_check=20= check=20(a=20>=200)=20enforced);=0A+create=20table=20p1_c1()=20inherits=20= (p1,=20p2);=0A+NOTICE:=20=20merging=20multiple=20inherited=20definitions=20= of=20column=20"a"=0A+--=20make=20p1_c1_g2's=20oid=20smaller=20than=20= p1_c1_g1's,=20to=20ensure=20ordering=20of=0A+--=20pg_constraint=20rows=20= to=20not=20impact=20the=20test=20results.=0A+create=20table=20p1_c1_g2()=20= inherits=20(p1_c1);=0A+create=20table=20p1_c1_g1()=20inherits=20(p1_c1);=0A= +alter=20table=20p1_c1_g2=20inherit=20p1_c1_g1;=0A+create=20table=20= p1_c2()=20inherits=20(p1);=0A+alter=20table=20p1=20alter=20constraint=20= p1_a_check=20not=20enforced;=20--ok=0A+select=20=20conname,=20= conenforced,=20convalidated,=20conrelid::regclass=0A+from=20=20=20=20= pg_constraint=0A+where=20=20=20conname=20=3D=20'p1_a_check'=20and=20= contype=20=3D=20'c'=0A+order=20by=20conrelid::regclass::text=20collate=20= "C";=0A+=20=20conname=20=20=20|=20conenforced=20|=20convalidated=20|=20= conrelid=20=0A+------------+-------------+--------------+----------=0A+=20= p1_a_check=20|=20f=20=20=20=20=20=20=20=20=20=20=20|=20f=20=20=20=20=20=20= =20=20=20=20=20=20|=20p1=0A+=20p1_a_check=20|=20t=20=20=20=20=20=20=20=20= =20=20=20|=20t=20=20=20=20=20=20=20=20=20=20=20=20|=20p1_c1=0A+=20= p1_a_check=20|=20t=20=20=20=20=20=20=20=20=20=20=20|=20t=20=20=20=20=20=20= =20=20=20=20=20=20|=20p1_c1_g1=0A+=20p1_a_check=20|=20t=20=20=20=20=20=20= =20=20=20=20=20|=20t=20=20=20=20=20=20=20=20=20=20=20=20|=20p1_c1_g2=0A+=20= p1_a_check=20|=20f=20=20=20=20=20=20=20=20=20=20=20|=20f=20=20=20=20=20=20= =20=20=20=20=20=20|=20p1_c2=0A+=20p1_a_check=20|=20t=20=20=20=20=20=20=20= =20=20=20=20|=20t=20=20=20=20=20=20=20=20=20=20=20=20|=20p2=0A+(6=20= rows)=0A+=0A+alter=20table=20p1_c1=20alter=20constraint=20p1_a_check=20= not=20enforced;=20--error=0A+ERROR:=20=20cannot=20mark=20inherited=20= constraint=20"p1_a_check"=20as=20NOT=20ENFORCED=20because=20matching=20= constraint=20on=20parent=20table=20"p2"=20is=20ENFORCED=0A+alter=20table=20= p2=20alter=20constraint=20p1_a_check=20not=20enforced;=20--ok=0A+alter=20= table=20p1_c1=20alter=20constraint=20p1_a_check=20not=20enforced;=20--ok=0A= +drop=20table=20p1,=20p2=20cascade;=0A+NOTICE:=20=20drop=20cascades=20to=20= 4=20other=20objects=0A+DETAIL:=20=20drop=20cascades=20to=20table=20p1_c1=0A= +drop=20cascades=20to=20table=20p1_c1_g1=0A+drop=20cascades=20to=20table=20= p1_c1_g2=0A+drop=20cascades=20to=20table=20p1_c2=0A+--=20recursive=20NOT=20= ENFORCED=20can=20change=20all=20matching=20enforced=20parents=20together=0A= +create=20table=20gp(a=20int=20constraint=20gp_a_check=20check=20(a=20>=20= 0)=20enforced);=0A+create=20table=20p1()=20inherits=20(gp);=0A+create=20= table=20p2()=20inherits=20(gp);=0A+create=20table=20p1_c1()=20inherits=20= (p1,=20p2);=0A+NOTICE:=20=20merging=20multiple=20inherited=20definitions=20= of=20column=20"a"=0A+alter=20table=20gp=20alter=20constraint=20= gp_a_check=20not=20enforced;=20--ok=0A+select=20=20conname,=20= conenforced,=20convalidated,=20conrelid::regclass=0A+from=20=20=20=20= pg_constraint=0A+where=20=20=20conname=20=3D=20'gp_a_check'=20and=20= contype=20=3D=20'c'=0A+order=20by=20conrelid::regclass::text=20collate=20= "C";=0A+=20=20conname=20=20=20|=20conenforced=20|=20convalidated=20|=20= conrelid=20=0A+------------+-------------+--------------+----------=0A+=20= gp_a_check=20|=20f=20=20=20=20=20=20=20=20=20=20=20|=20f=20=20=20=20=20=20= =20=20=20=20=20=20|=20gp=0A+=20gp_a_check=20|=20f=20=20=20=20=20=20=20=20= =20=20=20|=20f=20=20=20=20=20=20=20=20=20=20=20=20|=20p1=0A+=20= gp_a_check=20|=20f=20=20=20=20=20=20=20=20=20=20=20|=20f=20=20=20=20=20=20= =20=20=20=20=20=20|=20p1_c1=0A+=20gp_a_check=20|=20f=20=20=20=20=20=20=20= =20=20=20=20|=20f=20=20=20=20=20=20=20=20=20=20=20=20|=20p2=0A+(4=20= rows)=0A+=0A+drop=20table=20gp=20cascade;=0A+NOTICE:=20=20drop=20= cascades=20to=203=20other=20objects=0A+DETAIL:=20=20drop=20cascades=20to=20= table=20p1=0A+drop=20cascades=20to=20table=20p2=0A+drop=20cascades=20to=20= table=20p1_c1=0A+--=20recursive=20NOT=20ENFORCED=20can=20change=20a=20= direct-plus-indirect=20diamond=20together=0A+create=20table=20gp(a=20int=20= constraint=20gp_a_check=20check=20(a=20>=200)=20enforced);=0A+create=20= table=20p1_c1()=20inherits=20(gp);=0A+create=20table=20p1()=20inherits=20= (gp);=0A+alter=20table=20p1_c1=20inherit=20p1;=0A+alter=20table=20gp=20= alter=20constraint=20gp_a_check=20not=20enforced;=20--ok=0A+select=20=20= conname,=20conenforced,=20convalidated,=20conrelid::regclass=0A+from=20=20= =20=20pg_constraint=0A+where=20=20=20conname=20=3D=20'gp_a_check'=20and=20= contype=20=3D=20'c'=0A+order=20by=20conrelid::regclass::text=20collate=20= "C";=0A+=20=20conname=20=20=20|=20conenforced=20|=20convalidated=20|=20= conrelid=20=0A+------------+-------------+--------------+----------=0A+=20= gp_a_check=20|=20f=20=20=20=20=20=20=20=20=20=20=20|=20f=20=20=20=20=20=20= =20=20=20=20=20=20|=20gp=0A+=20gp_a_check=20|=20f=20=20=20=20=20=20=20=20= =20=20=20|=20f=20=20=20=20=20=20=20=20=20=20=20=20|=20p1=0A+=20= gp_a_check=20|=20f=20=20=20=20=20=20=20=20=20=20=20|=20f=20=20=20=20=20=20= =20=20=20=20=20=20|=20p1_c1=0A+(3=20rows)=0A+=0A+drop=20table=20gp=20= cascade;=0A+NOTICE:=20=20drop=20cascades=20to=202=20other=20objects=0A= +DETAIL:=20=20drop=20cascades=20to=20table=20p1=0A+drop=20cascades=20to=20= table=20p1_c1=0A=20--for=20"no=20inherit"=20check=20constraint,=20it=20= will=20not=20recurse=20to=20child=20table=0A=20create=20table=20p1(f1=20= int=20constraint=20p1_a_check=20check=20(f1=20>=200)=20no=20inherit=20= not=20enforced);=0A=20create=20table=20p1_c1(f1=20int=20constraint=20= p1_a_check=20check=20(f1=20>=200)=20not=20enforced);=0Adiff=20--git=20= a/src/test/regress/sql/constraints.sql=20= b/src/test/regress/sql/constraints.sql=0Aindex=20= dc133b124bb..9705962eb9f=20100644=0A---=20= a/src/test/regress/sql/constraints.sql=0A+++=20= b/src/test/regress/sql/constraints.sql=0A@@=20-309,8=20+309,9=20@@=20= select=20*=20from=20check_constraint_status;=0A=20alter=20table=20= parted_ch_2=20alter=20constraint=20cc_2=20enforced;=20--error=0A=20= delete=20from=20parted_ch=20where=20a=20=3D=2016;=0A=20alter=20table=20= parted_ch_2=20alter=20constraint=20cc_2=20enforced;=0A-alter=20table=20= parted_ch_2=20alter=20constraint=20cc=20not=20enforced;=0A-alter=20table=20= parted_ch_2=20alter=20constraint=20cc_1=20not=20enforced;=0A+alter=20= table=20parted_ch_2=20alter=20constraint=20cc=20not=20enforced;=20= --error=0A+alter=20table=20only=20parted_ch_2=20alter=20constraint=20cc=20= not=20enforced;=20--error=0A+alter=20table=20parted_ch_2=20alter=20= constraint=20cc_1=20not=20enforced;=20--error=0A=20alter=20table=20= parted_ch_2=20alter=20constraint=20cc_2=20not=20enforced;=0A=20=0A=20= --check=20these=20CHECK=20constraint=20status=20again=0Adiff=20--git=20= a/src/test/regress/sql/inherit.sql=20b/src/test/regress/sql/inherit.sql=0A= index=208f986904389..072fca13c13=20100644=0A---=20= a/src/test/regress/sql/inherit.sql=0A+++=20= b/src/test/regress/sql/inherit.sql=0A@@=20-535,6=20+535,58=20@@=20where=20= =20=20conname=20=3D=20'inh_check_constraint3'=20and=20contype=20=3D=20= 'c'=0A=20order=20by=20conrelid::regclass::text=20collate=20"C";=0A=20= drop=20table=20p1=20cascade;=0A=20=0A+--=20an=20inherited=20CHECK=20= constraint=20cannot=20be=20NOT=20ENFORCED=20under=20an=20ENFORCED=20= parent=0A+create=20table=20p1(f1=20int=20constraint=20p1_a_check=20check=20= (f1=20>=200)=20enforced);=0A+create=20table=20p1_c1()=20inherits(p1);=0A= +alter=20table=20p1_c1=20alter=20constraint=20p1_a_check=20not=20= enforced;=20--error=0A+alter=20table=20p1=20alter=20constraint=20= p1_a_check=20not=20enforced;=20--ok=0A+alter=20table=20p1_c1=20alter=20= constraint=20p1_a_check=20not=20enforced;=20--ok=0A+drop=20table=20p1=20= cascade;=0A+=0A+--=20recursive=20NOT=20ENFORCED=20merges=20with=20= ENFORCED=20constraints=20from=20other=20parents=0A+create=20table=20p1(a=20= int=20constraint=20p1_a_check=20check=20(a=20>=200)=20enforced);=0A= +create=20table=20p2(a=20int=20constraint=20p1_a_check=20check=20(a=20>=20= 0)=20enforced);=0A+create=20table=20p1_c1()=20inherits=20(p1,=20p2);=0A= +--=20make=20p1_c1_g2's=20oid=20smaller=20than=20p1_c1_g1's,=20to=20= ensure=20ordering=20of=0A+--=20pg_constraint=20rows=20to=20not=20impact=20= the=20test=20results.=0A+create=20table=20p1_c1_g2()=20inherits=20= (p1_c1);=0A+create=20table=20p1_c1_g1()=20inherits=20(p1_c1);=0A+alter=20= table=20p1_c1_g2=20inherit=20p1_c1_g1;=0A+create=20table=20p1_c2()=20= inherits=20(p1);=0A+alter=20table=20p1=20alter=20constraint=20p1_a_check=20= not=20enforced;=20--ok=0A+select=20=20conname,=20conenforced,=20= convalidated,=20conrelid::regclass=0A+from=20=20=20=20pg_constraint=0A= +where=20=20=20conname=20=3D=20'p1_a_check'=20and=20contype=20=3D=20'c'=0A= +order=20by=20conrelid::regclass::text=20collate=20"C";=0A+alter=20table=20= p1_c1=20alter=20constraint=20p1_a_check=20not=20enforced;=20--error=0A= +alter=20table=20p2=20alter=20constraint=20p1_a_check=20not=20enforced;=20= --ok=0A+alter=20table=20p1_c1=20alter=20constraint=20p1_a_check=20not=20= enforced;=20--ok=0A+drop=20table=20p1,=20p2=20cascade;=0A+=0A+--=20= recursive=20NOT=20ENFORCED=20can=20change=20all=20matching=20enforced=20= parents=20together=0A+create=20table=20gp(a=20int=20constraint=20= gp_a_check=20check=20(a=20>=200)=20enforced);=0A+create=20table=20p1()=20= inherits=20(gp);=0A+create=20table=20p2()=20inherits=20(gp);=0A+create=20= table=20p1_c1()=20inherits=20(p1,=20p2);=0A+alter=20table=20gp=20alter=20= constraint=20gp_a_check=20not=20enforced;=20--ok=0A+select=20=20conname,=20= conenforced,=20convalidated,=20conrelid::regclass=0A+from=20=20=20=20= pg_constraint=0A+where=20=20=20conname=20=3D=20'gp_a_check'=20and=20= contype=20=3D=20'c'=0A+order=20by=20conrelid::regclass::text=20collate=20= "C";=0A+drop=20table=20gp=20cascade;=0A+=0A+--=20recursive=20NOT=20= ENFORCED=20can=20change=20a=20direct-plus-indirect=20diamond=20together=0A= +create=20table=20gp(a=20int=20constraint=20gp_a_check=20check=20(a=20>=20= 0)=20enforced);=0A+create=20table=20p1_c1()=20inherits=20(gp);=0A+create=20= table=20p1()=20inherits=20(gp);=0A+alter=20table=20p1_c1=20inherit=20p1;=0A= +alter=20table=20gp=20alter=20constraint=20gp_a_check=20not=20enforced;=20= --ok=0A+select=20=20conname,=20conenforced,=20convalidated,=20= conrelid::regclass=0A+from=20=20=20=20pg_constraint=0A+where=20=20=20= conname=20=3D=20'gp_a_check'=20and=20contype=20=3D=20'c'=0A+order=20by=20= conrelid::regclass::text=20collate=20"C";=0A+drop=20table=20gp=20= cascade;=0A+=0A=20--for=20"no=20inherit"=20check=20constraint,=20it=20= will=20not=20recurse=20to=20child=20table=0A=20create=20table=20p1(f1=20= int=20constraint=20p1_a_check=20check=20(f1=20>=200)=20no=20inherit=20= not=20enforced);=0A=20create=20table=20p1_c1(f1=20int=20constraint=20= p1_a_check=20check=20(f1=20>=200)=20not=20enforced);=0A--=20=0A2.50.1=20= (Apple=20Git-155)=0A=0A= --Apple-Mail=_902DCE80-2EFF-4B61-B809-51AF6AB0BAEA Content-Disposition: attachment; filename=v7-0002-doc-Clarify-inherited-constraint-behavior.patch Content-Type: application/octet-stream; x-unix-mode=0644; name="v7-0002-doc-Clarify-inherited-constraint-behavior.patch" Content-Transfer-Encoding: quoted-printable =46rom=20b07641f79871ab5a1e4a6a9bcabaece677a40de3=20Mon=20Sep=2017=20= 00:00:00=202001=0AFrom:=20"Chao=20Li=20(Evan)"=20=0A= Date:=20Fri,=2029=20May=202026=2006:47:07=20+0800=0ASubject:=20[PATCH=20= v7=202/3]=20doc:=20Clarify=20inherited=20constraint=20behavior=0A=0A= Update=20the=20table=20inheritance=20documentation=20to=20mention=20= not-null=20constraints=0Aalongside=20check=20constraints=20where=20= inherited=20constraints=20are=20discussed.=0A=0AAlso=20clarify=20that=20= some=20properties=20of=20inherited=20constraints=20can=20now=20be=20= altered=0Adirectly=20on=20child=20tables,=20while=20the=20resulting=20= constraint=20must=20remain=20compatible=0Awith=20its=20inherited=20= parent=20constraints.=20=20For=20multiple=20inheritance,=20say=20= explicitly=0Athat=20when=20a=20column=20or=20constraint=20is=20inherited=20= from=20more=20than=20one=20parent,=20the=0Astricter=20definition=20= applies.=0A=0AAuthor:=20Chao=20Li=20=0A---=0A=20= doc/src/sgml/ddl.sgml=20|=2027=20++++++++++++++++-----------=0A=201=20= file=20changed,=2016=20insertions(+),=2011=20deletions(-)=0A=0Adiff=20= --git=20a/doc/src/sgml/ddl.sgml=20b/doc/src/sgml/ddl.sgml=0Aindex=20= 747f929aee3..afcc642bcb7=20100644=0A---=20a/doc/src/sgml/ddl.sgml=0A+++=20= b/doc/src/sgml/ddl.sgml=0A@@=20-4104,8=20+4104,9=20@@=20VALUES=20= ('Albany',=20NULL,=20NULL,=20'NY');=0A=20=20=20=20To=20do=20this=20the=20= new=20child=20table=20must=20already=20include=20columns=20with=0A=20=20=20= =20the=20same=20names=20and=20types=20as=20the=20columns=20of=20the=20= parent.=20It=20must=20also=20include=0A=20=20=20=20check=20constraints=20= with=20the=20same=20names=20and=20check=20expressions=20as=20those=20of=20= the=0A-=20=20=20parent.=20Similarly=20an=20inheritance=20link=20can=20be=20= removed=20from=20a=20child=20using=20the=0A-=20=20=20NO=20= INHERIT=20variant=20of=20ALTER=20TABLE.=0A+=20= =20=20parent,=20as=20well=20as=20matching=20not-null=20constraints.=20= Similarly=20an=20inheritance=0A+=20=20=20link=20can=20be=20removed=20= from=20a=20child=20using=20the=20NO=20INHERIT=0A+=20=20= =20variant=20of=20ALTER=20TABLE.=0A=20=20=20=20= Dynamically=20adding=20and=20removing=20inheritance=20links=20like=20= this=20can=20be=20useful=0A=20=20=20=20when=20the=20inheritance=20= relationship=20is=20being=20used=20for=20table=0A=20=20=20=20= partitioning=20(see=20).=0A@@=20= -4124,21=20+4125,25=20@@=20VALUES=20('Albany',=20NULL,=20NULL,=20'NY');=0A= =20=0A=20=20=20=0A=20=20=20=20A=20parent=20table=20cannot=20be=20= dropped=20while=20any=20of=20its=20children=20remain.=20Neither=0A-=20=20= =20can=20columns=20or=20check=20constraints=20of=20child=20tables=20be=20= dropped=20or=20altered=0A-=20=20=20if=20they=20are=20inherited=0A-=20=20=20= from=20any=20parent=20tables.=20If=20you=20wish=20to=20remove=20a=20= table=20and=20all=20of=20its=0A-=20=20=20descendants,=20one=20easy=20way=20= is=20to=20drop=20the=20parent=20table=20with=20the=0A-=20=20=20= CASCADE=20option=20(see=20).=0A+=20=20=20can=20inherited=20columns=20or=20= inherited=20check=20and=20not-null=20constraints=20of=20child=0A+=20=20=20= tables=20be=20dropped=20directly.=20=20Some=20properties=20of=20= inherited=20constraints=20can=0A+=20=20=20be=20altered,=20but=20each=20= resulting=20constraint=20must=20remain=20compatible=20with=20all=0A+=20=20= =20parent=20constraints=20from=20which=20it=20is=20inherited.=20=20If=20= you=20wish=20to=20remove=20a=0A+=20=20=20table=20and=20all=20of=20its=20= descendants,=20one=20easy=20way=20is=20to=20drop=20the=20parent=20table=0A= +=20=20=20with=20the=20CASCADE=20option=20(see=20= ).=0A=20=20=20=0A=20=0A=20=20=20= =0A=20=20=20=20ALTER=20TABLE=20will=0A-=20=20=20= propagate=20any=20changes=20in=20column=20data=20definitions=20and=20= check=0A-=20=20=20constraints=20down=20the=20inheritance=20hierarchy.=20=20= Again,=20dropping=0A+=20=20=20propagate=20changes=20in=20column=20= definitions=20and=20in=20inheritable=20constraints=0A+=20=20=20(check=20= and=20not-null=20constraints)=20down=20the=20inheritance=20hierarchy.=20=20= With=0A+=20=20=20multiple=20inheritance,=20if=20a=20column=20or=20= constraint=20is=20inherited=20from=20more=0A+=20=20=20than=20one=20= parent,=20the=20stricter=20definition=20applies.=20=20Again,=20dropping=0A= =20=20=20=20columns=20that=20are=20depended=20on=20by=20other=20tables=20= is=20only=20possible=20when=20using=0A=20=20=20=20the=20= CASCADE=20option.=20ALTER=0A-=20=20=20= TABLE=20follows=20the=20same=20rules=20for=20duplicate=20= column=20merging=0A-=20=20=20and=20rejection=20that=20apply=20during=20= CREATE=20TABLE.=0A+=20=20=20TABLE=20follows=20= the=20same=20rules=20for=20merging=20or=20rejecting=20duplicate=0A+=20=20= =20inherited=20column=20and=20constraint=20definitions=20that=20apply=20= during=0A+=20=20=20CREATE=20TABLE.=0A=20=20=20=0A= =20=0A=20=20=20=0A--=20=0A2.50.1=20(Apple=20Git-155)=0A=0A= --Apple-Mail=_902DCE80-2EFF-4B61-B809-51AF6AB0BAEA Content-Disposition: attachment; filename=v7-0003-doc-Clarify-ALTER-CONSTRAINT-enforceability-behav.patch Content-Type: application/octet-stream; x-unix-mode=0644; name="v7-0003-doc-Clarify-ALTER-CONSTRAINT-enforceability-behav.patch" Content-Transfer-Encoding: quoted-printable =46rom=2057caac73371508e40545a6b69195e07ffd1c2102=20Mon=20Sep=2017=20= 00:00:00=202001=0AFrom:=20"Chao=20Li=20(Evan)"=20=0A= Date:=20Mon,=2025=20May=202026=2016:59:21=20+0800=0ASubject:=20[PATCH=20= v7=203/3]=20doc:=20Clarify=20ALTER=20CONSTRAINT=20enforceability=20= behavior=0A=0AThe=20ALTER=20TABLE=20documentation=20said=20that=20= FOREIGN=20KEY=20and=20CHECK=0Aconstraints=20may=20be=20altered,=20but=20= did=20not=20distinguish=20between=0Adeferrability=20and=20enforceability=20= attributes.=0A=0AClarify=20that=20deferrability=20attributes=20can=20= currently=20be=20altered=20only=20for=0AFOREIGN=20KEY=20constraints,=20= while=20enforceability=20can=20be=20altered=20for=20both=0AFOREIGN=20KEY=20= and=20CHECK=20constraints.=20=20Also=20document=20that=20setting=20a=0A= constraint=20to=20ENFORCED=20verifies=20existing=20rows=20and=20resumes=20= checking=20new=0Aor=20updated=20rows.=0A=0AAuthor:=20Chao=20Li=20= =0A---=0A=20doc/src/sgml/ref/alter_table.sgml=20|=2014=20= ++++++++++++--=0A=201=20file=20changed,=2012=20insertions(+),=202=20= deletions(-)=0A=0Adiff=20--git=20a/doc/src/sgml/ref/alter_table.sgml=20= b/doc/src/sgml/ref/alter_table.sgml=0Aindex=20dec34337d1a..af247d82902=20= 100644=0A---=20a/doc/src/sgml/ref/alter_table.sgml=0A+++=20= b/doc/src/sgml/ref/alter_table.sgml=0A@@=20-586,8=20+586,18=20@@=20WITH=20= (=20MODULUS=20numeric_literal,=20REM=0A=20=20=20=20=20= =0A=20=20=20=20=20=20=0A=20=20=20=20=20=20=20This=20form=20= alters=20the=20attributes=20of=20a=20constraint=20that=20was=20= previously=0A-=20=20=20=20=20=20created.=20Currently=20FOREIGN=20= KEY=20and=20CHECK=0A-=20=20=20=20=20=20= constraints=20may=20be=20altered=20in=20this=20fashion,=20but=20see=20= below.=0A+=20=20=20=20=20=20created.=20=20Currently,=20the=20= deferrability=20attributes=20can=20be=20altered=20only=0A+=20=20=20=20=20= =20for=20FOREIGN=20KEY=20constraints.=20=20The=20= enforceability=0A+=20=20=20=20=20=20attribute=20can=20be=20altered=20for=20= FOREIGN=20KEY=20and=0A+=20=20=20=20=20=20= CHECK=20constraints.=0A+=20=20=20=20=20=0A+=0A= +=20=20=20=20=20=0A+=20=20=20=20=20=20Setting=20a=20constraint=20= to=20NOT=20ENFORCED=20causes=20the=0A+=20=20=20=20=20=20= database=20system=20to=20stop=20checking=20it=20for=20new=20or=20updated=20= rows.=20=20Setting=0A+=20=20=20=20=20=20a=20constraint=20to=20= ENFORCED=20causes=20the=20database=20system=0A+=20=20=20= =20=20=20to=20verify=20that=20existing=20rows=20satisfy=20the=20= constraint=20and=20to=20check=20it=0A+=20=20=20=20=20=20for=20new=20or=20= updated=20rows.=0A=20=20=20=20=20=20=0A=20=20=20=20=20=0A= =20=20=20=20=0A--=20=0A2.50.1=20(Apple=20Git-155)=0A=0A= --Apple-Mail=_902DCE80-2EFF-4B61-B809-51AF6AB0BAEA--