Received: from malur.postgresql.org ([217.196.149.56])
	by arkaria.postgresql.org with esmtps
 (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256)
	(Exim 4.92)
	(envelope-from <pgsql-hackers-owner+archive@lists.postgresql.org>)
	id 1ltgc4-0004Sc-S7
	for pgsql-hackers@arkaria.postgresql.org; Thu, 17 Jun 2021 01:14:32 +0000
Received: from localhost ([127.0.0.1] helo=malur.postgresql.org)
	by malur.postgresql.org with esmtp (Exim 4.92)
	(envelope-from <pgsql-hackers-owner+archive@lists.postgresql.org>)
	id 1ltgc3-0004hl-ES
	for pgsql-hackers@arkaria.postgresql.org; Thu, 17 Jun 2021 01:14:31 +0000
Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29])
	by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256)
	(Exim 4.92)
	(envelope-from <tgl@sss.pgh.pa.us>)
	id 1ltgc3-0004hd-6i
	for pgsql-hackers@lists.postgresql.org; Thu, 17 Jun 2021 01:14:31 +0000
Received: from sss.pgh.pa.us ([66.207.139.130])
	by magus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256)
	(Exim 4.92)
	(envelope-from <tgl@sss.pgh.pa.us>)
	id 1ltgc1-0006Ii-AR
	for pgsql-hackers@postgresql.org; Thu, 17 Jun 2021 01:14:30 +0000
Received: from sss1.sss.pgh.pa.us (localhost [127.0.0.1])
	by sss.pgh.pa.us (8.15.2/8.15.2) with ESMTP id 15H1EPKx930426;
	Wed, 16 Jun 2021 21:14:25 -0400
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Thomas Munro <thomas.munro@gmail.com>
cc: Zhihong Yu <zyu@yugabyte.com>, Andres Freund <andres@anarazel.de>,
        Daniel Gustafsson <daniel@yesql.se>,
        pgsql-hackers <pgsql-hackers@postgresql.org>
Subject: Re: A qsort template
In-reply-to: 
 <CA+hUKG+=Vw9dz4kVxFRUSBkUak43jUyD8UV5yaY_Z9PKThiePA@mail.gmail.com>
References: 
 <CA+hUKGJ2-eaDqAum5bxhpMNhvuJmRDZxB_Tow0n-gse+HG0Yig@mail.gmail.com>
 <0F9ECBA9-1DF2-4C38-BB58-B17EEE6C7B3A@yesql.se>
 <CA+hUKGJhOtjQH+wjCodtJzHAFCAPYyt6Qm9E1mUoJph42qo1hg@mail.gmail.com>
 <20210311185847.zwb2rf3n4wzelkba@alap3.anarazel.de>
 <CA+hUKGLqmksGRKQRF6qkih6jV_d9qVrrk4wh5F_EgTXyRGeCyw@mail.gmail.com>
 <CA+hUKGKztHEWm676csTFjYzortziWmOcf8HDss2Zr0muZ2xfEg@mail.gmail.com>
 <CALNJ-vRSvudAbdY-DChFv8C0-dJYD3FamX4FpW9A2xivKuB83A@mail.gmail.com>
 <CA+hUKGKWR3_-sqTE8BSrSy0kp0WJeKQ1ffyYxEKuykA7vmG9uQ@mail.gmail.com>
 <CA+hUKGLAfouP-rUpik45Z_KPM5+oxrX_564bLfiZPX4f25MYbA@mail.gmail.com>
 <CALNJ-vQjQ_Kj0dLOeYFApbdbS2r8hW=VtYdan-vZ==H6uom_fA@mail.gmail.com>
 <CA+hUKGKCV5w-9oJHE1+Aowwr1kp-A7UtF_2YKbRPDAUCHj0nxg@mail.gmail.com>
 <870660.1623886818@sss.pgh.pa.us>
 <CA+hUKG+=Vw9dz4kVxFRUSBkUak43jUyD8UV5yaY_Z9PKThiePA@mail.gmail.com>
Comments: In-reply-to Thomas Munro <thomas.munro@gmail.com>
	message dated "Thu, 17 Jun 2021 13:07:38 +1200"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <930424.1623892465.1@sss.pgh.pa.us>
Date: Wed, 16 Jun 2021 21:14:25 -0400
Message-ID: <930425.1623892465@sss.pgh.pa.us>
List-Id: <pgsql-hackers.lists.postgresql.org>
List-Help: <https://lists.postgresql.org/manage/>
List-Subscribe: <https://lists.postgresql.org/manage/>
List-Post: <mailto:pgsql-hackers@lists.postgresql.org>
List-Owner: <mailto:pgsql-hackers-owner@lists.postgresql.org>
List-Archive: <https://www.postgresql.org/list/pgsql-hackers>
Archived-At: 
 <https://www.postgresql.org/message-id/930425.1623892465%40sss.pgh.pa.us>
Precedence: bulk

Thomas Munro <thomas.munro@gmail.com> writes:
> Perhaps one day we could add a
> secondary file, not updated by that mechanism, that holds a manually
> maintained list for cases like this.

Yeah, the comments in pgindent already speculate about that.  For
now, those include and exclude lists are short enough that keeping
them inside the script seems a lot easier than building tooling
to get them from somewhere else.

The big problem in my mind, which would not be alleviated in the
slightest by having a separate file, is that it'd be easy to miss
removing entries if they ever become obsolete.

			regards, tom lane