Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1vuLWI-00GSBN-12 for pgsql-hackers@arkaria.postgresql.org; Mon, 23 Feb 2026 02:17:58 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.96) (envelope-from ) id 1vuLWH-00BhDe-0l for pgsql-hackers@arkaria.postgresql.org; Mon, 23 Feb 2026 02:17:57 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1vuLWG-00BhDW-2f for pgsql-hackers@lists.postgresql.org; Mon, 23 Feb 2026 02:17:56 +0000 Received: from smtp.outgoing.loopia.se ([93.188.3.37]) by magus.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.98.2) (envelope-from ) id 1vuLWD-00000000n15-38BI for pgsql-hackers@postgresql.org; Mon, 23 Feb 2026 02:17:56 +0000 Received: from s807.loopia.se (localhost [127.0.0.1]) by s807.loopia.se (Postfix) with ESMTP id DDD4C55D69F for ; Mon, 23 Feb 2026 03:17:53 +0100 (CET) Received: from s980.loopia.se (unknown [172.22.191.5]) by s807.loopia.se (Postfix) with ESMTP id CE59855DB22; Mon, 23 Feb 2026 03:17:53 +0100 (CET) Received: from localhost (unknown [172.22.191.6]) by s980.loopia.se (Postfix) with ESMTP id CC6F322015A7; Mon, 23 Feb 2026 03:17:53 +0100 (CET) X-Virus-Scanned: amavis at amavis.loopia.se X-Spam-Flag: NO X-Spam-Score: -1.2 X-Spam-Level: X-Spam-Status: No, score=-1.2 tagged_above=-999 required=6.2 tests=[ALL_TRUSTED=-1, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1] autolearn=disabled Authentication-Results: s472.loopia.se (amavis); dkim=pass (2048-bit key) header.d=proxel.se Received: from s979.loopia.se ([172.22.191.6]) by localhost (s472.loopia.se [172.22.190.12]) (amavis, port 10024) with LMTP id uYrKEbeb4OOX; Mon, 23 Feb 2026 03:17:53 +0100 (CET) X-Loopia-Auth: user X-Loopia-User: andreas@proxel.se X-Loopia-Originating-IP: 147.28.75.140 Received: from [192.168.0.121] (customer-147-28-75-140.stosn.net [147.28.75.140]) (Authenticated sender: andreas@proxel.se) by s979.loopia.se (Postfix) with ESMTPSA id 29BB410BC456; Mon, 23 Feb 2026 03:17:53 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=proxel.se; s=loopiadkim1707418970; t=1771813073; bh=zBem+lJ/7SxkDJXjWIYM7uMaxgxn71SZaIztyx7YjQ4=; h=Date:Subject:To:References:From:In-Reply-To; b=K8G+p/P3GfBzAl2Ip4Cl94MroZdCJ18nqyqxrr20LlreJTMjShHG3FCA33WXgqAqw qmfFM2FURSBOAqkEtZfwl9MUzrmi5UK4Z9bqeknP6KNzxOZjFRVkDgNZ9T4oRgWJPk ouauiI3wPX4CVulbFSp1J5yYKhMfgzZ1zLLnEmbyn8LfYRGA7Gluz9/Mo72V02XzLP uorPQZXD5YQsnZC+sRwg6K1CVEomWTN1YMg4S2u45/S5PVb9lnbvf05KKlT9PvSGBF Q3QzpK40xLT1Z0LcCIPREaWnP21nu079dLVjx85dxEhMYr9v6ADAf6a25S0q552lbi uOPfpZWmfuZrw== Message-ID: <93102cd4-5e35-4392-8700-e6e2fee847fd@proxel.se> Date: Mon, 23 Feb 2026 03:17:52 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: Use pg_malloc macros in src/fe_utils To: Henrik TJ , PostgreSQL Hackers References: <6df1b64e-1314-9afd-41a3-3fefb76225e1@0x48.dk> From: Andreas Karlsson Content-Language: en-US In-Reply-To: <6df1b64e-1314-9afd-41a3-3fefb76225e1@0x48.dk> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk On 2/18/26 4:05 PM, Henrik TJ wrote: > Inspired by [1], I took a stab at converting src/fe_utils to the new > pg_malloc macros. Thanks for the patch! Looks like a nice change but why not just fix all instances of it in one swoop? It cannot be that many as there are 166 calls to pg_malloc() and 62 calls to pg_malloc0() after your patch that need to be looked at. -- Andreas Karlsson Percona