Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1v4QeF-00F889-Sk for pgsql-hackers@arkaria.postgresql.org; Thu, 02 Oct 2025 21:15:36 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.94.2) (envelope-from ) id 1v4QeD-009VQS-8b for pgsql-hackers@arkaria.postgresql.org; Thu, 02 Oct 2025 21:15:33 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1v4QeC-009VQK-RU for pgsql-hackers@lists.postgresql.org; Thu, 02 Oct 2025 21:15:33 +0000 Received: from smtp.outgoing.loopia.se ([93.188.3.37]) by magus.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1v4Qe9-0005Kl-0K for pgsql-hackers@lists.postgresql.org; Thu, 02 Oct 2025 21:15:33 +0000 Received: from s807.loopia.se (localhost [127.0.0.1]) by s807.loopia.se (Postfix) with ESMTP id C7C7F43C400 for ; Thu, 02 Oct 2025 23:15:27 +0200 (CEST) Received: from s899.loopia.se (unknown [172.22.191.6]) by s807.loopia.se (Postfix) with ESMTP id B3C9143BBD8; Thu, 02 Oct 2025 23:15:27 +0200 (CEST) Received: from s472.loopia.se (unknown [172.22.191.5]) by s899.loopia.se (Postfix) with ESMTP id AF1612C8BAA4; Thu, 02 Oct 2025 23:15:27 +0200 (CEST) X-Virus-Scanned: amavisd-new at amavis.loopia.se X-Spam-Flag: NO X-Spam-Score: -1.2 X-Spam-Level: X-Spam-Status: No, score=-1.2 tagged_above=-999 required=6.2 tests=[ALL_TRUSTED=-1, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1] autolearn=disabled Authentication-Results: s472.loopia.se (amavisd-new); dkim=pass (2048-bit key) header.d=yesql.se Received: from s979.loopia.se ([172.22.191.5]) by s472.loopia.se (s472.loopia.se [172.22.190.12]) (amavisd-new, port 10024) with LMTP id dgy7brFru8t9; Thu, 2 Oct 2025 23:15:27 +0200 (CEST) X-Loopia-Auth: user X-Loopia-User: daniel@yesql.se X-Loopia-Originating-IP: 89.255.232.236 Received: from smtpclient.apple (customer-89-255-232-236.stosn.net [89.255.232.236]) (Authenticated sender: daniel@yesql.se) by s979.loopia.se (Postfix) with ESMTPSA id 1786910BC406; Thu, 02 Oct 2025 23:15:27 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yesql.se; s=loopiadkim1707475645; t=1759439727; bh=ihAvtetMWMlOjucPhGdvAZe3n/a6VoP3/mJxP3gMBUs=; h=Subject:From:In-Reply-To:Date:Cc:References:To; b=hjHGXUDmuab71YS6UNTOfY0cWpkFAlg7u3jc2vBjjbINXqoILI7GiJWHz6pUk4B3e 2M+2DcRggwfIXUixYqOYv+dIvjicQLb2mDRnB8BKcOzYI8SC6p8iN21fbtjDkBhQOJ OBP2+KRvOAB0GqJVKaV4gLT03O6XQUGzznjwgEr+3+z8yc9IDJENz/2DDIKN9ttBb1 jdtTre739dqWqh0+hpos/gyj4oL8Z9TvbnOyzwTS74zimQMshYwOrQu1xxC/FZ9jrp KtQ7zbaMBuo6CPTstwviTC/4j0pl0m2unP4BL/j8aw3vNK3dThpfg6/YuF2bIuxw+i cPVPET2+37n/A== Content-Type: text/plain; charset=us-ascii Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3776.700.51.11.2\)) Subject: Re: [PATCH] Add tests for Bitmapset From: Daniel Gustafsson In-Reply-To: Date: Thu, 2 Oct 2025 23:15:15 +0200 Cc: Michael Paquier , Greg Burd , PostgreSQL Hackers Content-Transfer-Encoding: quoted-printable Message-Id: <931B78E3-7608-4A14-A3DD-E83B4396E8C2@yesql.se> References: <76DBEF5D-EA47-4C30-8D28-97B3B88E2E2D@greg.burd.me> <978D21E8-9D3B-40EA-A4B1-F87BABE7868C@yesql.se> To: David Rowley X-Mailer: Apple Mail (2.3776.700.51.11.2) List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk > On 2 Oct 2025, at 23:00, David Rowley wrote: >=20 > On Fri, 3 Oct 2025 at 01:33, Daniel Gustafsson = wrote: >> Another nitpick would be to remove the test for NULL in = test_bms_make_singleton >> since that is a STRICT function, making the test for NULL superfluous = code: >=20 > I didn't notice that was marked as strict. It would be good to get rid > of those lines in that case. Done, comment cleanup and nullness check pushed. -- Daniel Gustafsson