Feedback-ID: i7c334307:Fastmail
Content-Type: multipart/signed;
	boundary="Apple-Mail=_AA299301-2ED9-48E0-8EE2-7656E5F83AA5";
	protocol="application/pgp-signature";
	micalg=pgp-sha256
Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3826.700.81.1.4\))
Subject: Re: PATCH: jsonpath string methods: lower, upper, initcap, l/r/btrim,
 replace, split_part
From: "David E. Wheeler" <david@justatheory.com>
In-Reply-To: <CA+v5N40aRmC3DYzWDxTbQKMKohkTdMZJ92Nuaj_NniKS7RHpEA@mail.gmail.com>
Date: Sat, 31 Jan 2026 11:31:08 -0500
Cc: pgsql-hackers <pgsql-hackers@lists.postgresql.org>,
 Chao Li <li.evan.chao@gmail.com>,
 =?utf-8?Q?=C3=81lvaro_Herrera?= <alvherre@kurilemu.de>,
 Tom Lane <tgl@sss.pgh.pa.us>,
 Peter Eisentraut <peter@eisentraut.org>,
 Robert Haas <robertmhaas@gmail.com>,
 Alexander Korotkov <aekorotkov@gmail.com>,
 Andrew Dunstan <andrew@dunslane.net>,
 jian he <jian.universality@gmail.com>
Message-Id: <931F201B-FF38-486E-BDEE-DF9692A01E1D@justatheory.com>
References: <202510210803.3b3vfvygxtjl@alvherre.pgsql>
 <87530674-E6B6-4C97-A704-78C7E07CF01F@gmail.com>
 <3DC56A6A-9525-4C05-B45A-9A135A66BC34@justatheory.com>
 <CACJufxGAmcwq33nr_MmgnGdGo7E10c55kCA22DQ4n9FBUOZmTA@mail.gmail.com>
 <A654130B-16AF-4E37-9D73-B3CDC80C751C@justatheory.com>
 <CACJufxEphbmEWLKzYNfzsyEB5+bkbMAMUHJq2LxpDdcSZn98BA@mail.gmail.com>
 <CACJufxGdgxyRLd03wM=GtJzUskXnXxEBGGtwA2vsTvkV827SxA@mail.gmail.com>
 <CACJufxHxWKhNcTsmYz428yxUikeUVZz=o6mLNRXpB7F_1oDEng@mail.gmail.com>
 <CECA8C06-755C-4550-88C8-0E1E0CB03D64@justatheory.com>
 <DB26FD47-DF09-4A92-AA15-08F012ED0DE2@justatheory.com>
 <CA+v5N40aRmC3DYzWDxTbQKMKohkTdMZJ92Nuaj_NniKS7RHpEA@mail.gmail.com>
To: Florents Tselai <florents.tselai@gmail.com>
Archived-At: <https://www.postgresql.org/message-id/931F201B-FF38-486E-BDEE-DF9692A01E1D%40justatheory.com>
Precedence: bulk


--Apple-Mail=_AA299301-2ED9-48E0-8EE2-7656E5F83AA5
Content-Transfer-Encoding: quoted-printable
Content-Type: text/plain;
	charset=utf-8

On Jan 31, 2026, at 11:23, Florents Tselai <florents.tselai@gmail.com> =
wrote:

> I think your attachment was left behind. Attaching it myself (that's =
v17, right? ) checked out from your PR

Bah! Yes, thank you.

> With the refactoring you=E2=80=99ve done across the parser and =
executor,=20
> I=E2=80=99m already tempted to slip in a few more string methods - but =
I think we should leave that for a future iteration.
> Functionally, it=E2=80=99d just mean adding another branch in =
executeStringInternalMethod,=20
> and I=E2=80=99d rather keep this patch focused. =20

Agreed.

> At this point, I=E2=80=99d say it=E2=80=99s ready for committer =
review.=20
>=20
> That said, I do expect someone to raise (again) the question of=20
> how we want to handle potential future conflicts with the SQL/JSON =
standard.=20
> That=E2=80=99s a broader design topic, and it=E2=80=99s going to come =
up every time we extend the JSONPath language.

Yup, continual challenge, part of the deal IME.

> And yes, I=E2=80=99m obviously biased here - I already have two other =
patches in the same spirit queued up, namely
> https://commitfest.postgresql.org/patch/6429/=20
> https://commitfest.postgresql.org/patch/6436/

Ha! Message received, I=E2=80=99ll try to find some time to look at =
them.

D


--Apple-Mail=_AA299301-2ED9-48E0-8EE2-7656E5F83AA5
Content-Transfer-Encoding: 7bit
Content-Disposition: attachment;
	filename=signature.asc
Content-Type: application/pgp-signature;
	name=signature.asc
Content-Description: Message signed with OpenPGP

-----BEGIN PGP SIGNATURE-----

iQIzBAEBCAAdFiEEd+KfmbOQis6ZycGGkt9idPjIgfEFAml+LkwACgkQkt9idPjI
gfHSog//WPJMYWj1TRxBTBXISmSHdcVHQoVyAQBbnzJueULdeW07R4Gtf6LOcaam
IW4aK1qJOoEo/wTlYVC4BZhe2xQeutVT6joW/tzs8TTWht3PdNuZ5T3xAY13PGg4
YXVl2h0wjKRzA1V8p/xzynjl1fq3Hlj+AX9igF7otyXYnRktB+v7+K7Qcbf+M7C1
VeQs/zgGWNBA3ajKuRKNQP1MBFeDKsip40reUyfHHINzvPtssBGHjAuUefGjAmu4
3GL/q0HqwKU3jTN8HfexeJGoHlkJOH+dpxww1VZn5X6gCWNj7MHB+6yk8kJcPRzJ
0eegqgA4zK6HYPZaOfJb26BEbErdZyXeabATIsNz3qUXxoD/1kxLJqGpu3vjQfQ/
WPoCE1XyIhal9tb4YjDX4mglaU6QRO1zw+efqnWr3PG+tR8y5RLPyzIZ43vIb9Cd
EI1ob1FH+S+xns2WydIOwCZ2YsDwp97B2hlbOmHNC5/xwdeENcGSWNHXePsomOhU
fY9aHbuItvhsTwmNejzEn5KK7OCbiXoEWIG9El7dipxrFfmfWTTowEPZIo3ZV3vM
4hGjynuqVifEzEyrFuoRSvoRndEBrIIIyE28eUYRAs/mX32EJMGwalOmIW92utCt
gA/CTZui7ksYeacPX7rhdgMfcSOq++bC9VYbbj3+CXY5CiiiFGk=
=Zope
-----END PGP SIGNATURE-----

--Apple-Mail=_AA299301-2ED9-48E0-8EE2-7656E5F83AA5--