MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII;
 format=flowed
Content-Transfer-Encoding: 7bit
Date: Fri, 05 Mar 2021 18:47:52 +0900
From: torikoshia <torikoshia@oss.nttdata.com>
To: Bharath Rupireddy <bharath.rupireddyforpostgres@gmail.com>
Cc: vignesh C <vignesh21@gmail.com>, Andres Freund <andres@anarazel.de>, Tom
 Lane <tgl@sss.pgh.pa.us>, Craig Ringer <craig.ringer@enterprisedb.com>,
 Robert Haas <robertmhaas@gmail.com>, Peter Eisentraut
 <peter.eisentraut@enterprisedb.com>, PostgreSQL Hackers
 <pgsql-hackers@lists.postgresql.org>
Subject: Re: Printing backtrace of postgres processes
In-Reply-To: 
 <CALj2ACUJGmc_kj=rLn4PPH9XyGXP9gFkX5uZCbnRd4kQb67NKA@mail.gmail.com>
References: <20210115201011.noomcygirzge43ir@alap3.anarazel.de>
 <CALDaNm2wjFrizmy+yvNbedYKxorZBcGYXNMaoPC6zwSaLsmwLg@mail.gmail.com>
 <3537.1610828491@sss.pgh.pa.us>
 <CA+TgmobpOhhm0poFsShjoM=sOxkbzc78f2TdNyZpGz4GSJHh6g@mail.gmail.com>
 <492025.1611078655@sss.pgh.pa.us>
 <CA+TgmoZ8XeQVCCqfq826kAr804a1ZnYy46FnQB9r2n_iOofh8Q@mail.gmail.com>
 <523589.1611091371@sss.pgh.pa.us>
 <CAGRY4nxmyaGs4-o4JSMwsUmqe++y-9zPEmJTeRn5ZOOdNzxi5w@mail.gmail.com>
 <799340.1611194209@sss.pgh.pa.us>
 <CALDaNm1ig4dKFW1658YBH9338Oysc-MT6-YzeKU-ojv87MhhMQ@mail.gmail.com>
 <20210127170958.vzo33jzmqwhmn7z6@alap3.anarazel.de>
 <CALDaNm1uWKn8KGD0q8HqCPhxSUDKWCEW55aidOiJwd+vfaB+gg@mail.gmail.com>
 <CALj2ACXfXefmdUWiF0twoYEfgJ6Xk4saXctoYyzXtzkjizCdBw@mail.gmail.com>
 <CALDaNm0aEUNLZeiDAXvPsgm4nFUjUhtfeztGofmVJU--irSD8Q@mail.gmail.com>
 <CALj2ACXybys_tzWeatb9htVTuxKp29VErc6iJQYJBbdBZXv2fg@mail.gmail.com>
 <CALDaNm3aBt1hw+Q=achUxfQgyu3b6DmdxewvMVx5DEikNayAFA@mail.gmail.com>
 <979ee93ab2e5d7d51836ced0c38b445c@oss.nttdata.com>
 <CALj2ACUJGmc_kj=rLn4PPH9XyGXP9gFkX5uZCbnRd4kQb67NKA@mail.gmail.com>
Message-ID: <93324693b1ac21e4e1b7d4ed40ea3447@oss.nttdata.com>
User-Agent: Roundcube Webmail/1.1.9
Archived-At: 
 <https://www.postgresql.org/message-id/93324693b1ac21e4e1b7d4ed40ea3447%40oss.nttdata.com>
Precedence: bulk

On 2021-03-04 21:55, Bharath Rupireddy wrote:
> On Mon, Mar 1, 2021 at 10:43 AM torikoshia <torikoshia@oss.nttdata.com> 
> wrote:
>> Since the current patch use BackendPidGetProc(), it does not
>> support this feature not only postmaster, logging, and
>> statistics but also checkpointer, background writer, and
>> walwriter.
>> 
>> And when I specify pid of these PostgreSQL processes, it
>> says "PID xxxx is not a PostgreSQL server process".
>> 
>> I think it may confuse users, so it might be worth
>> changing messages for those PostgreSQL processes.
>> AuxiliaryPidGetProc() may help to do it.
> 
> Exactly this was the doubt I got when I initially reviewed this patch.
> And I felt it should be discussed in a separate thread, you may want
> to update your thoughts there [1].
> 
> [1] -
> https://www.postgresql.org/message-id/CALj2ACW7Rr-R7mBcBQiXWPp%3DJV5chajjTdudLiF5YcpW-BmHhg%40mail.gmail.com

Thanks!
I'm going to join the discussion there.


Regards,

--
Atsushi Torikoshi
NTT DATA CORPORATION