Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1sZT6f-001DtZ-7O for pgsql-hackers@arkaria.postgresql.org; Thu, 01 Aug 2024 10:32:25 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.94.2) (envelope-from ) id 1sZT6d-007GjF-PY for pgsql-hackers@arkaria.postgresql.org; Thu, 01 Aug 2024 10:32:23 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1sZT6c-007GiN-Cl for pgsql-hackers@lists.postgresql.org; Thu, 01 Aug 2024 10:32:23 +0000 Received: from fout5-smtp.messagingengine.com ([103.168.172.148]) by makus.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1sZT6Z-002Wv1-Jm for pgsql-hackers@postgresql.org; Thu, 01 Aug 2024 10:32:21 +0000 Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailfout.nyi.internal (Postfix) with ESMTP id 55B511387B2F; Thu, 1 Aug 2024 06:32:17 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute5.internal (MEProxy); Thu, 01 Aug 2024 06:32:17 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=eisentraut.org; h=cc:cc:content-transfer-encoding:content-type:content-type :date:date:from:from:in-reply-to:in-reply-to:message-id :mime-version:references:reply-to:subject:subject:to:to; s=fm2; t=1722508337; x=1722594737; bh=uhXGYhHXA4BGzAqWOtZcliIhh4x/IOqs mcx7P0BapFU=; b=4eMXkDUzKTY+gZGXwYqOCd07cWoNQNebMaT64ftyQdDPl/0L 5KhgFCLKn4rj46FhKdD5isUdm/UCWySh1FOC9zEUxeJsOkLqokfhSNFlKeSXXgmj KnCx8y0Ppnr0HDWeYmJ5vHcaGnn2pTf/BkKsE5uxQahhQJLrVtYQTgp7uVUzCgEG 9ge1GbUnaZO8RBXJHOXfCc/U6sFKO2nDAQ9cnogtVK2HXK0duq1AB9hev3YUXFS9 +8LkK6gjqWLQ1z9oGQJhfgf5SeE0R1siBug0iUx2qQ29ZRLYQ0BgA0W/I2AscchC rtqHk3XF9eQxzEviP7mQnwV4fEa5N2hxNxq0FQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm3; t=1722508337; x= 1722594737; bh=uhXGYhHXA4BGzAqWOtZcliIhh4x/IOqsmcx7P0BapFU=; b=P sVbOGYuCP5D3ef6oh15A1uwnJGSMJv/Cz+s9MArs/YJ2p3JT40pTb4E7hMifAZ2m YSqOBWVbthLUVdsbSjWbDH1EeZkY6toM9DVaO5EHbTEVg7JGUb3QLapn3tteAdp6 VTFfHCwSpsu4mY6dG1xraW3RL9J7pZ06mnNdk7bLoc72TEJOaf0DhYFi+AZpccE2 AQXyNeFM0TB1yOeGPd1YbsWmMMwPURJ0YFAgNYt3FlOVADR93KYYNpXZXG87Gx6Z 0v61z4LFV4q+EEA34bXDojJygze2C75nWj+rvfvhxd1HzzvgOhEFt1MaIpbmZOXE zU0wWDhDpLqEfMaT6yNAg== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeeftddrjeekgddvlecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefkffggfgfuvfevfhfhjggtgfesthejredttddvjeenucfhrhhomheprfgvthgv rhcugfhishgvnhhtrhgruhhtuceophgvthgvrhesvghishgvnhhtrhgruhhtrdhorhhgqe enucggtffrrghtthgvrhhnpefgjedthfekfedtuefgieelheetleejgefhueeltdfhueet vdffudekfeejhfegheenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrih hlfhhrohhmpehpvghtvghrsegvihhsvghnthhrrghuthdrohhrghdpnhgspghrtghpthht oheptd X-ME-Proxy: Feedback-ID: ie0a040ee:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Thu, 1 Aug 2024 06:32:16 -0400 (EDT) Message-ID: <93452f9f-7634-4e36-99e2-c8453c4ac862@eisentraut.org> Date: Thu, 1 Aug 2024 12:32:14 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: make pg_createsubscriber option names more consistent To: "Hayato Kuroda (Fujitsu)" Cc: pgsql-hackers References: <1ed82b9b-8e20-497d-a2f8-aebdd793d595@eisentraut.org> Content-Language: en-US From: Peter Eisentraut In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk On 31.07.24 11:15, Hayato Kuroda (Fujitsu) wrote: > Dear Peter, > >> I propose to rename the pg_createsubscriber option --socket-directory to >> --socketdir. This would make it match the equivalent option in >> pg_upgrade. (It even has the same short option '-s'.) >> pg_createsubscriber and pg_upgrade have a lot of common terminology and >> a similar operating mode, so it would make sense to keep this consistent. > > +1. If so, should we say "default current dir." instead of "default current directory" in usage() > because pg_upgrade says like that? Committed with that change. Thanks.