Content-Type: multipart/mixed; boundary="------------mAr0qQ7CZPUDz6kGLVBSL6j7"
Message-ID: <93464dd6-d484-4021-b71f-e82928bf6758@gmail.com>
Date: Tue, 3 Sep 2024 11:52:55 +0200
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: POC, WIP: OR-clause support for indexes
To: Alena Rybakina <a.rybakina@postgrespro.ru>,
 jian he <jian.universality@gmail.com>,
 Alexander Korotkov <aekorotkov@gmail.com>
Cc: Nikolay Shaplov <dhyan@nataraj.su>, pgsql-hackers@lists.postgresql.org,
 Robert Haas <robertmhaas@gmail.com>, pgsql-hackers@postgresql.org,
 Peter Geoghegan <pg@bowt.ie>, Marcos Pegoraro <marcos@f10.com.br>,
 teodor@sigaev.ru, Peter Eisentraut <peter@eisentraut.org>,
 Ranier Vilela <ranier.vf@gmail.com>
References: <567ED6CA.2040504@sigaev.ru>
 <CAPpHfdvUEjkuFNUbg7GuLkXotwvpDgBYz4S8YcE=LRf9aBQh-Q@mail.gmail.com>
 <531fc0ab-371e-4235-97e3-dd2d077b6995@postgrespro.ru>
 <CAPpHfdu5iQOjF93vGbjidsQkhHvY2NSm29duENYH_cbhC6x+Mg@mail.gmail.com>
 <CAPpHfdv9GrXfCOdPsMszBrORig+nW2+JBuMD-np_keVuKJ7bdQ@mail.gmail.com>
 <cf2c669f-93ec-4e35-a521-cecac67def73@postgrespro.ru>
 <CAPpHfduTM2W3kmiN1=5fvgcu6yA5=ghq82OkvLvZC8Mh9PpEuA@mail.gmail.com>
 <c3c490e2-1f04-420b-bd5c-f4840d6a7198@postgrespro.ru>
 <e657e536-f10b-4131-a3f2-667c73c86588@postgrespro.ru>
 <CAPpHfduFJHTNGCTFWt4GFs-E6Ts8xS5mCsKOYKBsZAmoOr8ZSA@mail.gmail.com>
 <65bfdcb6-0f0c-4d4c-a721-cb38a0ba91c7@postgrespro.ru>
 <CAPpHfdtR3cBKCSj_7dd7EDF_pa-rUUQBx3-guK6kZZ=_hSeMfg@mail.gmail.com>
 <670d1dc2-a280-4cf6-bc29-e2eafb107081@gmail.com>
 <CAPpHfdvF864n=Lzmjd2XBi9TwboZvrhRtLSt2hCP+JVUv6XKzg@mail.gmail.com>
 <CACJufxHCJvC3X8nUK-jRvRru-ZEXp16EBPADOwTGaqmOYM1Raw@mail.gmail.com>
 <fe11e5c9-877e-4306-a6a9-122125c7d2e5@postgrespro.ru>
Content-Language: en-US
From: Andrei Lepikhov <lepihov@gmail.com>
In-Reply-To: <fe11e5c9-877e-4306-a6a9-122125c7d2e5@postgrespro.ru>
Archived-At: <https://www.postgresql.org/message-id/93464dd6-d484-4021-b71f-e82928bf6758%40gmail.com>
Precedence: bulk

This is a multi-part message in MIME format.
--------------mAr0qQ7CZPUDz6kGLVBSL6j7
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit

On 26/8/2024 12:41, Alena Rybakina wrote:
> On 26.08.2024 06:12, jian he wrote:
>> On Fri, Aug 23, 2024 at 8:58 PM Alexander Korotkov<aekorotkov@gmail.com>  wrote:
>> + int indexnum; /* index of the matching index */
>> + int colnum; /* index of the matching column */
>>
>> I am not 100% sure about the comments.
>> indexnum:  index of the matching index reside in rel->indexlist that
>> matches (counting from 0)
>> colnum: the column number of the matched index (counting from 0)
Hmm, it is not easy to invent an alternative variant. What are you 
proposing exactly?

> If OR constants have different types, then they belong to different 
> groups, and I think that's unfair. I think that conversion to a single 
> type should be used here - while I’m working on this, I’ll send the code 
> in the next letter.
IMO, that means additional overhead, isn't it? It is an improvement and 
I suggest to discuss it in a separate thread if current feature will be 
applied.
> 
> And I noticed that there were some tests missing on this, so I added this.
> 
> I've updated the patch file to include my and Jian's suggestions, as 
> well as the diff file if there's no objection.
I doubt if you really need additional index on the tenk1 table. What is 
the case you can't reproduce with current indexes, playing, let's say, 
with casting to numeric and integer data types?
See in attachment minor fixes to the v38 version of the patch set.

-- 
regards, Andrei Lepikhov

--------------mAr0qQ7CZPUDz6kGLVBSL6j7
Content-Type: text/plain; charset=UTF-8; name="minor-fix.no-cfbot"
Content-Disposition: attachment; filename="minor-fix.no-cfbot"
Content-Transfer-Encoding: base64

ZGlmZiAtLWdpdCBhL3NyYy9iYWNrZW5kL29wdGltaXplci9wYXRoL2luZHhwYXRoLmMgYi9z
cmMvYmFja2VuZC9vcHRpbWl6ZXIvcGF0aC9pbmR4cGF0aC5jCmluZGV4IGNkZTYzNWQ5Y2Iu
LmQ1NDQ2MmYwZmMgMTAwNjQ0Ci0tLSBhL3NyYy9iYWNrZW5kL29wdGltaXplci9wYXRoL2lu
ZHhwYXRoLmMKKysrIGIvc3JjL2JhY2tlbmQvb3B0aW1pemVyL3BhdGgvaW5keHBhdGguYwpA
QCAtMzM0NSwxMCArMzM0NSw4IEBAIG1hdGNoX29yY2xhdXNlX3RvX2luZGV4Y29sKFBsYW5u
ZXJJbmZvICpyb290LAogCQlnZXRfdHlwbGVuYnl2YWxhbGlnbihjb25zdHR5cGUsICZ0eXBs
ZW4sICZ0eXBieXZhbCwgJnR5cGFsaWduKTsKIAogCQllbGVtcyA9IChEYXR1bSAqKSBwYWxs
b2Moc2l6ZW9mKERhdHVtKSAqIGxpc3RfbGVuZ3RoKGNvbnN0cykpOwotCQlmb3JlYWNoKGxj
LCBjb25zdHMpCisJCWZvcmVhY2hfbm9kZShDb25zdCwgdmFsdWUsIGNvbnN0cykKIAkJewot
CQkJQ29uc3QgKnZhbHVlID0gKENvbnN0ICopIGxmaXJzdChsYyk7Ci0KIAkJCUFzc2VydCgh
dmFsdWUtPmNvbnN0aXNudWxsICYmIHZhbHVlLT5jb25zdHZhbHVlKTsKIAogCQkJZWxlbXNb
aSsrXSA9IHZhbHVlLT5jb25zdHZhbHVlOwpkaWZmIC0tZ2l0IGEvc3JjL3Rlc3QvcmVncmVz
cy9leHBlY3RlZC9jcmVhdGVfaW5kZXgub3V0IGIvc3JjL3Rlc3QvcmVncmVzcy9leHBlY3Rl
ZC9jcmVhdGVfaW5kZXgub3V0CmluZGV4IDU2MjNmNGIzMTIuLmFmYWUyY2MyNzIgMTAwNjQ0
Ci0tLSBhL3NyYy90ZXN0L3JlZ3Jlc3MvZXhwZWN0ZWQvY3JlYXRlX2luZGV4Lm91dAorKysg
Yi9zcmMvdGVzdC9yZWdyZXNzL2V4cGVjdGVkL2NyZWF0ZV9pbmRleC5vdXQKQEAgLTE4Nzcs
NyArMTg3Nyw3IEBAIFNFTEVDVCAqIEZST00gdGVuazEKIAogRVhQTEFJTiAoQ09TVFMgT0ZG
KQogU0VMRUNUICogRlJPTSB0ZW5rMQotICBXSEVSRSB0aG91c2FuZCA9IDQyIEFORCAodGVu
dGhvdXMgPSAxIE9SIHRlbnRob3VzID0gMyBPUiB0ZW50aG91cyA9IDQyIG9yIHRlbnRob3Vz
IGlzIG51bGwpOworICBXSEVSRSB0aG91c2FuZCA9IDQyIEFORCAodGVudGhvdXMgPSAxIE9S
IHRlbnRob3VzID0gMyBPUiB0ZW50aG91cyA9IDQyIE9SIHRlbnRob3VzIElTIE5VTEwpOwog
ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg
ICAgICAgICAgIFFVRVJZIFBMQU4gICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg
ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIAogLS0tLS0tLS0tLS0tLS0tLS0tLS0t
LS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0t
LS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0t
LS0tLS0tLS0tLQogIEJpdG1hcCBIZWFwIFNjYW4gb24gdGVuazEKQEAgLTE4OTAsNyArMTg5
MCw3IEBAIFNFTEVDVCAqIEZST00gdGVuazEKICAgICAgICAgICAgICAgIEluZGV4IENvbmQ6
ICgodGhvdXNhbmQgPSA0MikgQU5EICh0ZW50aG91cyA9IEFOWSAoJ3sxLDMsNDJ9Jzo6aW50
ZWdlcltdKSkpCiAoOCByb3dzKQogCi1jcmVhdGUgaW5kZXggc3RyaW5ndTFfaWR4IG9uIHRl
bmsxIChzdHJpbmd1MSk7CitDUkVBVEUgSU5ERVggc3RyaW5ndTFfaWR4IE9OIHRlbmsxIChz
dHJpbmd1MSk7CiBFWFBMQUlOIChDT1NUUyBPRkYpCiBTRUxFQ1QgKiBGUk9NIHRlbmsxCiAg
IFdIRVJFIHRob3VzYW5kID0gNDIgQU5EIChzdHJpbmd1MTo6dGV4dCA9ICdNQUFBQUEnIE9S
IHN0cmluZ3UxOjp0ZXh0ID0gJ1RVQUFBQSc6Om5hbWUgT1Igc3RyaW5ndTEgPSAnT0JBQUFB
Jzo6bmFtZSk7CkBAIC0xOTM1LDcgKzE5MzUsNyBAQCBTRUxFQ1QgKiBGUk9NIHRlbmsxCiAg
ICAgICAgICAgICAgICAgICAgICBJbmRleCBDb25kOiAoc3RyaW5ndTEgPSBBTlkgKCd7VFVB
QUFBLE9CQUFBQX0nOjp0ZXh0W10gQ09MTEFURSAiQyIpKQogKDExIHJvd3MpCiAKLURyb3Ag
aW5kZXggc3RyaW5ndTFfaWR4OworRFJPUCBJTkRFWCBzdHJpbmd1MV9pZHg7CiBFWFBMQUlO
IChDT1NUUyBPRkYpCiBTRUxFQ1QgY291bnQoKikgRlJPTSB0ZW5rMQogICBXSEVSRSBodW5k
cmVkID0gNDIgQU5EICh0aG91c2FuZCA9IDQyIE9SIHRob3VzYW5kID0gOTkpOwpkaWZmIC0t
Z2l0IGEvc3JjL3Rlc3QvcmVncmVzcy9zcWwvY3JlYXRlX2luZGV4LnNxbCBiL3NyYy90ZXN0
L3JlZ3Jlc3Mvc3FsL2NyZWF0ZV9pbmRleC5zcWwKaW5kZXggMzc1MzhhYjZiYi4uNTBmNzY4
MjNkOSAxMDA2NDQKLS0tIGEvc3JjL3Rlc3QvcmVncmVzcy9zcWwvY3JlYXRlX2luZGV4LnNx
bAorKysgYi9zcmMvdGVzdC9yZWdyZXNzL3NxbC9jcmVhdGVfaW5kZXguc3FsCkBAIC03NDAs
OSArNzQwLDkgQEAgU0VMRUNUICogRlJPTSB0ZW5rMQogCiBFWFBMQUlOIChDT1NUUyBPRkYp
CiBTRUxFQ1QgKiBGUk9NIHRlbmsxCi0gIFdIRVJFIHRob3VzYW5kID0gNDIgQU5EICh0ZW50
aG91cyA9IDEgT1IgdGVudGhvdXMgPSAzIE9SIHRlbnRob3VzID0gNDIgb3IgdGVudGhvdXMg
aXMgbnVsbCk7CisgIFdIRVJFIHRob3VzYW5kID0gNDIgQU5EICh0ZW50aG91cyA9IDEgT1Ig
dGVudGhvdXMgPSAzIE9SIHRlbnRob3VzID0gNDIgT1IgdGVudGhvdXMgSVMgTlVMTCk7CiAK
LWNyZWF0ZSBpbmRleCBzdHJpbmd1MV9pZHggb24gdGVuazEgKHN0cmluZ3UxKTsKK0NSRUFU
RSBJTkRFWCBzdHJpbmd1MV9pZHggT04gdGVuazEgKHN0cmluZ3UxKTsKIEVYUExBSU4gKENP
U1RTIE9GRikKIFNFTEVDVCAqIEZST00gdGVuazEKICAgV0hFUkUgdGhvdXNhbmQgPSA0MiBB
TkQgKHN0cmluZ3UxOjp0ZXh0ID0gJ01BQUFBQScgT1Igc3RyaW5ndTE6OnRleHQgPSAnVFVB
QUFBJzo6bmFtZSBPUiBzdHJpbmd1MSA9ICdPQkFBQUEnOjpuYW1lKTsKQEAgLTc1Myw3ICs3
NTMsNyBAQCBTRUxFQ1QgKiBGUk9NIHRlbmsxCiBFWFBMQUlOIChDT1NUUyBPRkYpCiBTRUxF
Q1QgKiBGUk9NIHRlbmsxCiAgIFdIRVJFIHRob3VzYW5kID0gNDIgQU5EIChzdHJpbmd1MSA9
ICdNQUFBQUEnIE9SIHN0cmluZ3UxID0gJ1RVQUFBQSc6OnRleHQgT1Igc3RyaW5ndTEgPSAn
T0JBQUFBJzo6dGV4dCk7Ci1Ecm9wIGluZGV4IHN0cmluZ3UxX2lkeDsKK0RST1AgSU5ERVgg
c3RyaW5ndTFfaWR4OwogCiBFWFBMQUlOIChDT1NUUyBPRkYpCiBTRUxFQ1QgY291bnQoKikg
RlJPTSB0ZW5rMQo=

--------------mAr0qQ7CZPUDz6kGLVBSL6j7--