From: Tom Lane <tgl@sss.pgh.pa.us>
To: Erik Wienhold <ewie@ewie.name>
cc: jian he <jian.universality@gmail.com>,
 Marcos Pegoraro <marcos@f10.com.br>,
        PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Subject: Re: Add column name to error description
In-reply-to: <4b9cff17-103e-4792-98bf-fef46171d7fe@ewie.name>
References: 
 <CAB-JLwanky28gjAMdnMh1CjyO1b2zLdr6UOA1-oY9G7PVL9KKQ@mail.gmail.com>
 <afxezpvlwknoz2w66frakeg2feua76zqvgszrjrmpkhs7ynqir@x5y2tdomabdx>
 <794292.1711912501@sss.pgh.pa.us>
 <CACJufxHiXzSOB7FqFFQGqJM0b3MNP08AB84EzTH5ZZGwGuDGgA@mail.gmail.com>
 <897633.1741294606@sss.pgh.pa.us>
 <4b9cff17-103e-4792-98bf-fef46171d7fe@ewie.name>
Comments: In-reply-to Erik Wienhold <ewie@ewie.name>
	message dated "Fri, 07 Mar 2025 02:42:00 +0100"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <936267.1741316738.1@sss.pgh.pa.us>
Date: Thu, 06 Mar 2025 22:05:38 -0500
Message-ID: <936268.1741316738@sss.pgh.pa.us>
Archived-At: 
 <https://www.postgresql.org/message-id/936268.1741316738%40sss.pgh.pa.us>
Precedence: bulk

Erik Wienhold <ewie@ewie.name> writes:
> But I don't see the point in keeping variables atttypid and atttypmod
> around when those values are now available via outatt.  Removing these
> two variables makes the code easier to read IMO.  Done so in the
> attached v4.

I think the idea of the original coding was to keep those values in
registers in the inner loop rather than re-fetching them each time.
But that's probably an unmeasurably microscopic optimization, if
real at all (modern compilers might figure it out for themselves).
Do others agree Erik's version improves readability?

			regards, tom lane