Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1tuYbu-009lre-0d for pgsql-hackers@arkaria.postgresql.org; Tue, 18 Mar 2025 15:12:06 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.94.2) (envelope-from ) id 1tuYbn-00Gf0m-Ks for pgsql-hackers@arkaria.postgresql.org; Tue, 18 Mar 2025 15:11:59 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1tuYbn-00Gf0V-Ap for pgsql-hackers@lists.postgresql.org; Tue, 18 Mar 2025 15:11:59 +0000 Received: from sss.pgh.pa.us ([68.162.161.243]) by makus.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1tuYbl-003X0X-0u for pgsql-hackers@postgresql.org; Tue, 18 Mar 2025 15:11:58 +0000 Received: from sss1.sss.pgh.pa.us (localhost [127.0.0.1]) by sss.pgh.pa.us (8.15.2/8.15.2) with ESMTP id 52IFBflD093732; Tue, 18 Mar 2025 11:11:41 -0400 From: Tom Lane To: Jeff Davis cc: Alexander Borisov , Heikki Linnakangas , pgsql-hackers@postgresql.org Subject: Re: Optimization for lower(), upper(), casefold() functions. In-reply-to: References: <7cac7e66-9a3b-4e3f-a997-42aa0c401f80@gmail.com> <7ab9d255-d7c0-4841-96c3-ed3ce9aa4abd@iki.fi> <12956299-1496-4455-b3ab-299cc0a87d7c@gmail.com> <340f2451-cd76-487b-a1e4-0f0a2fe91fba@gmail.com> <3ffb8b75b26e76624668c0883cac7886468c5d07.camel@j-davis.com> <5cf176fa-44b9-4019-b9b7-ee902352a844@gmail.com> <3080de9bcce916cf8720ac197f634e381c4de564.camel@j-davis.com> <1e3f4f6f-9b12-4109-b0d2-a4c52b5064f8@gmail.com> <4f3772355e038acd3cfe0be43ae2c1aacae1794d.camel@j-davis.com> <2c10910c21b16cb9a0e5f67d80589e3acae2b6ef.camel@j-davis.com> <44005c3d-88f4-4a26-981f-fd82dfa8e313@gmail.com> <2a9e520ba41b318df8ed396ef99ed1e3d3e4b5b6.camel@j-davis.com> <177451ea791a1! f90039ea3047f1f890b1f9ae1db.camel@j-davis.com> <3505356.1742069486@sss.pgh.pa.us> Comments: In-reply-to Jeff Davis message dated "Sat, 15 Mar 2025 13:57:03 -0700" MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <93730.1742310701.1@sss.pgh.pa.us> Content-Transfer-Encoding: quoted-printable Date: Tue, 18 Mar 2025 11:11:41 -0400 Message-ID: <93731.1742310701@sss.pgh.pa.us> List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk One more thing: I observe that headerscheck is now unhappy: $ src/tools/pginclude/headerscheck = In file included from /tmp/headerscheck.yOpahZ/test.c:2: ./src/include/common/unicode_case_table.h:8598:24: warning: 'casekind_map'= defined but not used [-Wunused-variable] static const pg_wchar *casekind_map[NCaseKind] =3D ^~~~~~~~~~~~ It's not apparent to me why that table needs to be in a header file and not in the sole user .c file? Also, probably better to make it const: -static const pg_wchar *casekind_map[NCaseKind] =3D +static const pg_wchar * const casekind_map[NCaseKind] =3D regards, tom lane