Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1qiWZl-006gIl-Dt for pgsql-hackers@arkaria.postgresql.org; Tue, 19 Sep 2023 08:59:21 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.94.2) (envelope-from ) id 1qiWZk-0087Fh-3M for pgsql-hackers@arkaria.postgresql.org; Tue, 19 Sep 2023 08:59:20 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1qiWZj-0087FQ-Oh for pgsql-hackers@lists.postgresql.org; Tue, 19 Sep 2023 08:59:19 +0000 Received: from oss.nttdata.com ([49.212.34.109]) by makus.postgresql.org with esmtps (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1qiWZg-005PnS-DZ for pgsql-hackers@lists.postgresql.org; Tue, 19 Sep 2023 08:59:18 +0000 Received: from oss.nttdata.com (localhost [127.0.0.1]) by oss.nttdata.com (Postfix) with ESMTPA id F102660830 for ; Tue, 19 Sep 2023 17:59:11 +0900 (JST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at oss.nttdata.com MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=_439aee1c72aba708b49b2e1ac33fd5ab" Content-Transfer-Encoding: 7bit Date: Tue, 19 Sep 2023 17:59:11 +0900 From: Ryoga Yoshida To: pgsql-hackers@lists.postgresql.org Subject: Fix bug in VACUUM and ANALYZE docs User-Agent: Roundcube Webmail/1.4.11 Message-ID: <9374034cb91b647b55a774a8980b0228@oss.nttdata.com> X-Sender: bt23yoshidar@oss.nttdata.com List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk --=_439aee1c72aba708b49b2e1ac33fd5ab Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset=US-ASCII; format=flowed Hi, Issue1: VACUUM and ANALYZE docs explain that the parameter of BUFFER_USAGE_LIMIT is optional as follows. But this is not true. The argument, size, is required for BUFFER_USAGE_LIMIT. So the docs should be fixed this issue. BUFFER_USAGE_LIMIT [ size ] https://www.postgresql.org/docs/devel/sql-vacuum.html https://www.postgresql.org/docs/devel/sql-analyze.html Issue2: Sizes may also be specified as a string containing the numerical size followed by any one of the following memory units: kB (kilobytes), MB (megabytes), GB (gigabytes), or TB (terabytes). VACUUM and ANALYZE docs explain that the argument of BUFFER_USAGE_LIMIT accepts the units like kB (kilobytes), MB (megabytes), GB (gigabytes), or TB (terabytes). But it also actually accepts B(bytes) as an unit. So the docs should include "B(bytes)" as an unit that the argument of BUFFER_USAGE_LIMIT can accept. You can see the patch in the attached file. Ryoga Yoshida --=_439aee1c72aba708b49b2e1ac33fd5ab Content-Transfer-Encoding: base64 Content-Type: text/x-diff; name=v1-0001-Fix-bug-in-VACUUM-and-ANALYZE-docs.patch Content-Disposition: attachment; filename=v1-0001-Fix-bug-in-VACUUM-and-ANALYZE-docs.patch; size=2563 ZGlmZiAtLWdpdCBhL2RvYy9zcmMvc2dtbC9yZWYvYW5hbHl6ZS5zZ21sIGIvZG9jL3NyYy9zZ21s L3JlZi9hbmFseXplLnNnbWwKaW5kZXggMWZiYTA4OTI2NS4uYmM5NzNiZGQxZSAxMDA2NDQKLS0t IGEvZG9jL3NyYy9zZ21sL3JlZi9hbmFseXplLnNnbWwKKysrIGIvZG9jL3NyYy9zZ21sL3JlZi9h bmFseXplLnNnbWwKQEAgLTI3LDcgKzI3LDcgQEAgQU5BTFlaRSBbICggPHJlcGxhY2VhYmxlIGNs YXNzPSJwYXJhbWV0ZXIiPm9wdGlvbjwvcmVwbGFjZWFibGU+IFssIC4uLl0gKSBdIFsgPHIKIAog ICAgIFZFUkJPU0UgWyA8cmVwbGFjZWFibGUgY2xhc3M9InBhcmFtZXRlciI+Ym9vbGVhbjwvcmVw bGFjZWFibGU+IF0KICAgICBTS0lQX0xPQ0tFRCBbIDxyZXBsYWNlYWJsZSBjbGFzcz0icGFyYW1l dGVyIj5ib29sZWFuPC9yZXBsYWNlYWJsZT4gXQotICAgIEJVRkZFUl9VU0FHRV9MSU1JVCBbIDxy ZXBsYWNlYWJsZSBjbGFzcz0icGFyYW1ldGVyIj5zaXplPC9yZXBsYWNlYWJsZT4gXQorICAgIEJV RkZFUl9VU0FHRV9MSU1JVCA8cmVwbGFjZWFibGUgY2xhc3M9InBhcmFtZXRlciI+c2l6ZTwvcmVw bGFjZWFibGU+CiAKIDxwaHJhc2U+YW5kIDxyZXBsYWNlYWJsZSBjbGFzcz0icGFyYW1ldGVyIj50 YWJsZV9hbmRfY29sdW1uczwvcmVwbGFjZWFibGU+IGlzOjwvcGhyYXNlPgogCkBAIC0xMjgsNyAr MTI4LDcgQEAgQU5BTFlaRSBbICggPHJlcGxhY2VhYmxlIGNsYXNzPSJwYXJhbWV0ZXIiPm9wdGlv bjwvcmVwbGFjZWFibGU+IFssIC4uLl0gKSBdIFsgPHIKICAgICAgPHBhcmE+CiAgICAgICBTcGVj aWZpZXMgYW4gYW1vdW50IG9mIG1lbW9yeSBpbiBraWxvYnl0ZXMuICBTaXplcyBtYXkgYWxzbyBi ZSBzcGVjaWZpZWQKICAgICAgIGFzIGEgc3RyaW5nIGNvbnRhaW5pbmcgdGhlIG51bWVyaWNhbCBz aXplIGZvbGxvd2VkIGJ5IGFueSBvbmUgb2YgdGhlCi0gICAgICBmb2xsb3dpbmcgbWVtb3J5IHVu aXRzOiA8bGl0ZXJhbD5rQjwvbGl0ZXJhbD4gKGtpbG9ieXRlcyksCisgICAgICBmb2xsb3dpbmcg bWVtb3J5IHVuaXRzOiA8bGl0ZXJhbD5CPC9saXRlcmFsPiAoYnl0ZXMpLCA8bGl0ZXJhbD5rQjwv bGl0ZXJhbD4gKGtpbG9ieXRlcyksCiAgICAgICA8bGl0ZXJhbD5NQjwvbGl0ZXJhbD4gKG1lZ2Fi eXRlcyksIDxsaXRlcmFsPkdCPC9saXRlcmFsPiAoZ2lnYWJ5dGVzKSwgb3IKICAgICAgIDxsaXRl cmFsPlRCPC9saXRlcmFsPiAodGVyYWJ5dGVzKS4KICAgICAgPC9wYXJhPgpkaWZmIC0tZ2l0IGEv ZG9jL3NyYy9zZ21sL3JlZi92YWN1dW0uc2dtbCBiL2RvYy9zcmMvc2dtbC9yZWYvdmFjdXVtLnNn bWwKaW5kZXggOTBjZGU3MGMwNy4uZjJlN2MwYmJkZSAxMDA2NDQKLS0tIGEvZG9jL3NyYy9zZ21s L3JlZi92YWN1dW0uc2dtbAorKysgYi9kb2Mvc3JjL3NnbWwvcmVmL3ZhY3V1bS5zZ21sCkBAIC0z OCw3ICszOCw3IEBAIFZBQ1VVTSBbICggPHJlcGxhY2VhYmxlIGNsYXNzPSJwYXJhbWV0ZXIiPm9w dGlvbjwvcmVwbGFjZWFibGU+IFssIC4uLl0gKSBdIFsgPHJlCiAgICAgUEFSQUxMRUwgPHJlcGxh Y2VhYmxlIGNsYXNzPSJwYXJhbWV0ZXIiPmludGVnZXI8L3JlcGxhY2VhYmxlPgogICAgIFNLSVBf REFUQUJBU0VfU1RBVFMgWyA8cmVwbGFjZWFibGUgY2xhc3M9InBhcmFtZXRlciI+Ym9vbGVhbjwv cmVwbGFjZWFibGU+IF0KICAgICBPTkxZX0RBVEFCQVNFX1NUQVRTIFsgPHJlcGxhY2VhYmxlIGNs YXNzPSJwYXJhbWV0ZXIiPmJvb2xlYW48L3JlcGxhY2VhYmxlPiBdCi0gICAgQlVGRkVSX1VTQUdF X0xJTUlUIFsgPHJlcGxhY2VhYmxlIGNsYXNzPSJwYXJhbWV0ZXIiPnNpemU8L3JlcGxhY2VhYmxl PiBdCisgICAgQlVGRkVSX1VTQUdFX0xJTUlUIDxyZXBsYWNlYWJsZSBjbGFzcz0icGFyYW1ldGVy Ij5zaXplPC9yZXBsYWNlYWJsZT4KIAogPHBocmFzZT5hbmQgPHJlcGxhY2VhYmxlIGNsYXNzPSJw YXJhbWV0ZXIiPnRhYmxlX2FuZF9jb2x1bW5zPC9yZXBsYWNlYWJsZT4gaXM6PC9waHJhc2U+CiAK QEAgLTM4OSw3ICszODksNyBAQCBWQUNVVU0gWyAoIDxyZXBsYWNlYWJsZSBjbGFzcz0icGFyYW1l dGVyIj5vcHRpb248L3JlcGxhY2VhYmxlPiBbLCAuLi5dICkgXSBbIDxyZQogICAgICA8cGFyYT4K ICAgICAgIFNwZWNpZmllcyBhbiBhbW91bnQgb2YgbWVtb3J5IGluIGtpbG9ieXRlcy4gIFNpemVz IG1heSBhbHNvIGJlIHNwZWNpZmllZAogICAgICAgYXMgYSBzdHJpbmcgY29udGFpbmluZyB0aGUg bnVtZXJpY2FsIHNpemUgZm9sbG93ZWQgYnkgYW55IG9uZSBvZiB0aGUKLSAgICAgIGZvbGxvd2lu ZyBtZW1vcnkgdW5pdHM6IDxsaXRlcmFsPmtCPC9saXRlcmFsPiAoa2lsb2J5dGVzKSwKKyAgICAg IGZvbGxvd2luZyBtZW1vcnkgdW5pdHM6IDxsaXRlcmFsPkI8L2xpdGVyYWw+IChieXRlcyksIDxs aXRlcmFsPmtCPC9saXRlcmFsPiAoa2lsb2J5dGVzKSwKICAgICAgIDxsaXRlcmFsPk1CPC9saXRl cmFsPiAobWVnYWJ5dGVzKSwgPGxpdGVyYWw+R0I8L2xpdGVyYWw+IChnaWdhYnl0ZXMpLCBvcgog ICAgICAgPGxpdGVyYWw+VEI8L2xpdGVyYWw+ICh0ZXJhYnl0ZXMpLgogICAgICA8L3BhcmE+Cg== --=_439aee1c72aba708b49b2e1ac33fd5ab--