Message-ID: <93804d18-9e49-46b6-abc8-de9694f34d0a@proxel.se>
Date: Wed, 28 Aug 2024 17:26:38 +0200
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: Little cleanup of ShmemInit function names
To: Heikki Linnakangas <hlinnaka@iki.fi>,
 "pgsql-hackers@postgresql.org" <pgsql-hackers@postgresql.org>
References: <c09694ff-2453-47e5-b26c-32a16cd75ce6@iki.fi>
Content-Language: en-US
From: Andreas Karlsson <andreas@proxel.se>
In-Reply-To: <c09694ff-2453-47e5-b26c-32a16cd75ce6@iki.fi>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Archived-At: <https://www.postgresql.org/message-id/93804d18-9e49-46b6-abc8-de9694f34d0a%40proxel.se>
Precedence: bulk

On 8/7/24 2:08 PM, Heikki Linnakangas wrote:
> The attached patches rename them to follow the usual naming convention. 
> The InitLocks() function is refactored a bit more, splitting the 
> per-backend initialization to a separate InitLockManagerAccess() 
> function. That's why it's in a separate commit.

I like the idea behind the patches. And they still apply and build.

The first patch is clean and well commented. I just have two minor nitpicks.

Small typo with the extra "which" which makes the sentence not flow 
correctly

"This is called from CreateSharedMemoryAndSemaphores(), which see for 
more comments."

On the topic of minor language issues I think the comma below is redundant.

"In the normal postmaster case, the shared hash tables are created here."

The second patch is a simple renaming which reduces mental load by 
making the naming more consistent so I like it. Also since these 
functions are not really useful for any extension authors I do not see 
any harm in renaming them.

After cleaning up the language of that comment I think these patches can 
be committed.

Andreas