From: Tom Lane <tgl@sss.pgh.pa.us>
To: Andres Freund <andres@anarazel.de>
cc: Chao Li <li.evan.chao@gmail.com>, Kirill Reshke <reshkekirill@gmail.com>,
        Heikki Linnakangas <hlinnaka@iki.fi>,
        Melanie Plageman <melanieplageman@gmail.com>,
        Matthias van de Meent <boekewurm+postgres@gmail.com>,
        pgsql-hackers@postgresql.org, Thomas Munro <thomas.munro@gmail.com>,
        Noah Misch <noah@leadboat.com>, Robert Haas <robertmhaas@gmail.com>,
        Michael Paquier <michael.paquier@gmail.com>
Subject: Re: Buffer locking is special (hints, checksums, AIO writes)
In-reply-to: <oauakayi2ksyaavz2ounpns47qei5q2kguya4ocfmvjyr45ctc@qqb6b7gjttwi>
References: <kjdgvws34gpnz4y6xu5aaeul5mspgy3ahvyiw4lndb3ecsacdb@b2ccyowotpqh>
 <jtg5cu4n6h5lib3kzx66ju4yhh6kmviaud7oq6dtut6c4q4rdi@xwsfoagt3c2b>
 <9C2494E1-F446-42DF-B070-7E231B8E6221@gmail.com>
 <vrnib3bf726ht72jlccu252qm65lzexutydtagytstsjszpiya@ece6xi7o4nfx>
 <F6A52B41-2FFA-4592-BD9B-0438F610B6A2@gmail.com>
 <cj5mcjdpucvw4a54hehslr3ctukavrbnxltvuzzhqnimvpju5e@cy3g3mnsefwz>
 <58821140-0182-4FF3-9A4F-5B168DDB9243@gmail.com>
 <732580B4-962F-4EBD-8811-F4667D79747D@gmail.com>
 <wat7azo4hpgux7ptvozfedtw6hnz7pih3vvnfipxdlcci6fuf3@wacut36qcac7>
 <934395.1768518154@sss.pgh.pa.us>
 <oauakayi2ksyaavz2ounpns47qei5q2kguya4ocfmvjyr45ctc@qqb6b7gjttwi>
Comments: In-reply-to Andres Freund <andres@anarazel.de>
	message dated "Thu, 15 Jan 2026 18:16:07 -0500"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <938361.1768519181.1@sss.pgh.pa.us>
Date: Thu, 15 Jan 2026 18:19:41 -0500
Message-ID: <938362.1768519181@sss.pgh.pa.us>
Archived-At: 
 <https://www.postgresql.org/message-id/938362.1768519181%40sss.pgh.pa.us>
Precedence: bulk

Andres Freund <andres@anarazel.de> writes:
> Can't quite decide between just using always_inline - after all the buffer
> locking really is a rather crucial code path - and just initializing
> wait_event to 0. Either seems better than using a default:.

Yeah, I agree with not using a default: in case we ever extend
the mode enum.  I'd be inclined to fix it like this:

 			case BUFFER_LOCK_UNLOCK:
 				pg_unreachable();
+				/* silence possible compiler warning: */ 
+				wait_event = 0;
  		}

			regards, tom lane