Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1hihVw-0003yO-7A for pgsql-hackers@arkaria.postgresql.org; Wed, 03 Jul 2019 15:49:44 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.89) (envelope-from ) id 1hihVv-0001iy-3B for pgsql-hackers@arkaria.postgresql.org; Wed, 03 Jul 2019 15:49:43 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1hihVu-0001ir-QW for pgsql-hackers@lists.postgresql.org; Wed, 03 Jul 2019 15:49:42 +0000 Received: from sss.pgh.pa.us ([66.207.139.130]) by magus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1hihVs-0007VJ-Jj for pgsql-hackers@postgresql.org; Wed, 03 Jul 2019 15:49:42 +0000 Received: from sss1.sss.pgh.pa.us (localhost [127.0.0.1]) by sss.pgh.pa.us (8.14.4/8.14.4) with ESMTP id x63FnUa6009396; Wed, 3 Jul 2019 11:49:30 -0400 From: Tom Lane To: Daniel Gustafsson cc: Alvaro Herrera , David Fetter , Fabien COELHO , Rafia Sabih , PostgreSQL Development Subject: Re: [PATCH v5] Show detailed table persistence in \dt+ In-reply-to: References: <20190702203526.GA29015@alvherre.pgsql> Comments: In-reply-to Daniel Gustafsson message dated "Tue, 02 Jul 2019 22:38:32 +0200" MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-ID: <9394.1562168970.1@sss.pgh.pa.us> Content-Transfer-Encoding: quoted-printable Date: Wed, 03 Jul 2019 11:49:30 -0400 Message-ID: <9395.1562168970@sss.pgh.pa.us> List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk Daniel Gustafsson writes: >> On 2 Jul 2019, at 22:35, Alvaro Herrera wrot= e: >> Anyway I'm not objecting to the patch -- I agree that we're already not >> testing translatability and that this patch shouldn't be forced to star= t >> doing it. > I forgot to add that to my previous email, the patch as it stands in v8 = looks > good to me. I=E2=80=99ve missed having this on many occasions. OK, pushed. For the record, I did verify that the translatability logic worked by adding some bogus entries to psql/po/es.po and seeing that the display changed to match. regards, tom lane