Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1qVmNT-001BQy-Al for pgsql-hackers@arkaria.postgresql.org; Tue, 15 Aug 2023 05:13:59 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.94.2) (envelope-from ) id 1qVmNQ-00ATHv-2n for pgsql-hackers@arkaria.postgresql.org; Tue, 15 Aug 2023 05:13:56 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1qVmNP-00ATHn-Nm for pgsql-hackers@lists.postgresql.org; Tue, 15 Aug 2023 05:13:55 +0000 Received: from oss.nttdata.com ([49.212.34.109]) by magus.postgresql.org with esmtps (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1qVmNL-000Dod-LG for pgsql-hackers@lists.postgresql.org; Tue, 15 Aug 2023 05:13:54 +0000 Received: from oss.nttdata.com (localhost [127.0.0.1]) by oss.nttdata.com (Postfix) with ESMTPA id 0FA846078C; Tue, 15 Aug 2023 14:13:46 +0900 (JST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.8 at oss.nttdata.com MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=_65d92d8cd986e8b8630e9dc4a63aaee8" Content-Transfer-Encoding: 8bit Date: Tue, 15 Aug 2023 14:13:46 +0900 From: Masahiro Ikeda To: Masahiko Sawada Cc: Andres Freund , pgsql-hackers@lists.postgresql.org, mitsuru.hinata.5432@gmail.com Subject: Re: Fix pg_stat_reset_single_table_counters function In-Reply-To: References: <7cc69f863d9b1bc677544e3accd0e4b4@oss.nttdata.com> <9a4a6718abb47647ae83f1f4b3f9bf68@oss.nttdata.com> <20230812191207.aerskqox7aoan3ud@awork3.anarazel.de> <97c9f7a46681f051b1356e2987c3fd6c@oss.nttdata.com> User-Agent: Roundcube Webmail/1.4.11 Message-ID: <93d14a670cf090c08994f1f4958efa25@oss.nttdata.com> X-Sender: ikedamsh@oss.nttdata.com List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk --=_65d92d8cd986e8b8630e9dc4a63aaee8 Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset=UTF-8; format=flowed On 2023-08-15 11:48, Masahiko Sawada wrote: > On Mon, Aug 14, 2023 at 5:12 PM Masahiro Ikeda > wrote: >> I changed the table to check the stats from pg_database to >> pg_shdescription >> because the stats can update via the SQL interface COMMENT command. > > It seems to work well. > > +COMMENT ON DATABASE :current_database IS 'This is a test comment'; > -- insert or update in 'pg_shdescription' > > I think the current_database should be quoted (see other examples > where using current_database(), e.g. collate.linux.utf8.sql). Also it > would be better to reset the comment after the test. Thanks! I fixed the issues in the v4 patch. Regards, -- Masahiro Ikeda NTT DATA CORPORATION --=_65d92d8cd986e8b8630e9dc4a63aaee8 Content-Transfer-Encoding: base64 Content-Type: text/x-diff; name=v4-0001-Fix-pg_stat_reset_single_table_counters-function.patch Content-Disposition: attachment; filename=v4-0001-Fix-pg_stat_reset_single_table_counters-function.patch; size=5001 RnJvbSBiY2E0YzE4NDQ5OTRiZThlZDgwYTI5YjhjYjc2MGUyZWI4NjVkY2E5IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBNYXNhaGlybyBJa2VkYSA8bXNoci5pa2VkYUBudHQuY29tPgpE YXRlOiBNb24sIDE0IEF1ZyAyMDIzIDE2OjQ4OjMwICswOTAwClN1YmplY3Q6IFtQQVRDSF0gRml4 IHBnX3N0YXRfcmVzZXRfc2luZ2xlX3RhYmxlX2NvdW50ZXJzIGZ1bmN0aW9uLgoKVGhpcyBjb21t aXQgcmV2aXZlcyB0aGUgZmVhdHVyZSB0byByZXNldCBzdGF0aXN0aWNzIGZvciBhIHNpbmdsZQpy ZWxhdGlvbiBzaGFyZWQgYWNyb3NzIGFsbCBkYXRhYmFzZXMgaW4gdGhlIGNsdXN0ZXIgdG8gemVy bywgd2hpY2gKd2FzIGltcGxlbWVudGVkIGJ5IHRoZSBmb2xsb3dpbmcgY29tbWl0LgoqIEVuaGFu Y2UgcGdfc3RhdF9yZXNldF9zaW5nbGVfdGFibGVfY291bnRlcnMgZnVuY3Rpb24oZTA0MjY3ODQ0 KQoKVGhlIGZvbGxvd2luZyBjb21taXQgYWNjaWRlbnRhbGx5IGRlbGV0ZWQgdGhlIGZlYXR1cmUu CiogcGdzdGF0OiBzdG9yZSBzdGF0aXN0aWNzIGluIHNoYXJlZCBtZW1vcnkoNTg5MWM3YThlKQoK TmVlZCB0byBiYWNrcGF0Y2ggZnJvbSAxNS4KClJlcG9ydGVkLWJ5OiBNaXRzdXJ1IEhpbmF0YQot LS0KIHNyYy9iYWNrZW5kL3V0aWxzL2FkdC9wZ3N0YXRmdW5jcy5jIHwgIDkgKysrKystLQogc3Jj L3Rlc3QvcmVncmVzcy9leHBlY3RlZC9zdGF0cy5vdXQgfCA0MiArKysrKysrKysrKysrKysrKysr KysrKysrKysrKwogc3JjL3Rlc3QvcmVncmVzcy9zcWwvc3RhdHMuc3FsICAgICAgfCAyNiArKysr KysrKysrKysrKysrKysKIDMgZmlsZXMgY2hhbmdlZCwgNzUgaW5zZXJ0aW9ucygrKSwgMiBkZWxl dGlvbnMoLSkKCmRpZmYgLS1naXQgYS9zcmMvYmFja2VuZC91dGlscy9hZHQvcGdzdGF0ZnVuY3Mu YyBiL3NyYy9iYWNrZW5kL3V0aWxzL2FkdC9wZ3N0YXRmdW5jcy5jCmluZGV4IDJhNGM4ZWY4N2Yu LjJiOTc0MmFkMjEgMTAwNjQ0Ci0tLSBhL3NyYy9iYWNrZW5kL3V0aWxzL2FkdC9wZ3N0YXRmdW5j cy5jCisrKyBiL3NyYy9iYWNrZW5kL3V0aWxzL2FkdC9wZ3N0YXRmdW5jcy5jCkBAIC0xNyw2ICsx Nyw3IEBACiAjaW5jbHVkZSAiYWNjZXNzL2h0dXBfZGV0YWlscy5oIgogI2luY2x1ZGUgImFjY2Vz cy94bG9nLmgiCiAjaW5jbHVkZSAiYWNjZXNzL3hsb2dwcmVmZXRjaGVyLmgiCisjaW5jbHVkZSAi Y2F0YWxvZy9jYXRhbG9nLmgiCiAjaW5jbHVkZSAiY2F0YWxvZy9wZ19hdXRoaWQuaCIKICNpbmNs dWRlICJjYXRhbG9nL3BnX3R5cGUuaCIKICNpbmNsdWRlICJjb21tb24vaXAuaCIKQEAgLTE3NzYs MTMgKzE3NzcsMTcgQEAgcGdfc3RhdF9yZXNldF9zaGFyZWQoUEdfRlVOQ1RJT05fQVJHUykKIAlQ R19SRVRVUk5fVk9JRCgpOwogfQogCi0vKiBSZXNldCBhIHNpbmdsZSBjb3VudGVyIGluIHRoZSBj dXJyZW50IGRhdGFiYXNlICovCisvKgorICogUmVzZXQgYSBzdGF0aXN0aWNzIGZvciBhIHNpbmds ZSBvYmplY3QsIHdoaWNoIG1heSBiZSBvZiBjdXJyZW50CisgKiBkYXRhYmFzZSBvciBzaGFyZWQg YWNyb3NzIGFsbCBkYXRhYmFzZXMgaW4gdGhlIGNsdXN0ZXIuCisgKi8KIERhdHVtCiBwZ19zdGF0 X3Jlc2V0X3NpbmdsZV90YWJsZV9jb3VudGVycyhQR19GVU5DVElPTl9BUkdTKQogewogCU9pZAkJ CXRhYm9pZCA9IFBHX0dFVEFSR19PSUQoMCk7CisJT2lkCQkJZGJvaWQgPSAoSXNTaGFyZWRSZWxh dGlvbih0YWJvaWQpID8gSW52YWxpZE9pZCA6IE15RGF0YWJhc2VJZCk7CiAKLQlwZ3N0YXRfcmVz ZXQoUEdTVEFUX0tJTkRfUkVMQVRJT04sIE15RGF0YWJhc2VJZCwgdGFib2lkKTsKKwlwZ3N0YXRf cmVzZXQoUEdTVEFUX0tJTkRfUkVMQVRJT04sIGRib2lkLCB0YWJvaWQpOwogCiAJUEdfUkVUVVJO X1ZPSUQoKTsKIH0KZGlmZiAtLWdpdCBhL3NyYy90ZXN0L3JlZ3Jlc3MvZXhwZWN0ZWQvc3RhdHMu b3V0IGIvc3JjL3Rlc3QvcmVncmVzcy9leHBlY3RlZC9zdGF0cy5vdXQKaW5kZXggMzE5MTY0YTVl OS4uZWIyNGEwMjE0NyAxMDA2NDQKLS0tIGEvc3JjL3Rlc3QvcmVncmVzcy9leHBlY3RlZC9zdGF0 cy5vdXQKKysrIGIvc3JjL3Rlc3QvcmVncmVzcy9leHBlY3RlZC9zdGF0cy5vdXQKQEAgLTc2NCw2 ICs3NjQsNDggQEAgRlJPTSBwZ19zdGF0X2FsbF90YWJsZXMgV0hFUkUgcmVsaWQgPSAndGVzdF9s YXN0X3NjYW4nOjpyZWdjbGFzczsKICAgICAgICAgMiB8IHQgICAgICB8ICAgICAgICAzIHwgdAog KDEgcm93KQogCistLS0tLQorLS0gVGVzdCB0byByZXNldCBzdGF0cyBmb3IgYSB0YWJsZSBzaGFy ZWQgYWNyb3NzIGFsbCBkYXRhYmFzZXMgKGV4LiBwZ19zaGRlc2NyaXB0aW9uKQorLS0tLS0KKy0t IHN0b3JlIHRoZSBvbGQgY29tbWVudCB0byByZXNldAorU0VMRUNUIHNob2JqX2Rlc2NyaXB0aW9u KGQub2lkLCAncGdfZGF0YWJhc2UnKSBhcyBkZXNjcmlwdGlvbl9iZWZvcmUKK0ZST00gcGdfZGF0 YWJhc2UgZCBXSEVSRSBkYXRuYW1lID0gY3VycmVudF9kYXRhYmFzZSgpIFxnc2V0CistLSB1cGRh dGUgdGhlIHN0YXRzIGluIHBnX3NoZGVzY3JpcHRpb24KK0JFR0lOOworU0VMRUNUIGN1cnJlbnRf ZGF0YWJhc2UoKSBhcyBjdXJyZW50X2RhdGFiYXNlIFxnc2V0CitDT01NRU5UIE9OIERBVEFCQVNF IDoiY3VycmVudF9kYXRhYmFzZSIgSVMgJ1RoaXMgaXMgYSB0ZXN0IGNvbW1lbnQnOworU0VMRUNU IHBnX3N0YXRfZm9yY2VfbmV4dF9mbHVzaCgpOworIHBnX3N0YXRfZm9yY2VfbmV4dF9mbHVzaCAK Ky0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tCisgCisoMSByb3cpCisKK0NPTU1JVDsKKy0tIGNo ZWNrIHRvIHJlc2V0IHRoZSBzdGF0cworU0VMRUNUIG5fdHVwX2lucyArIG5fdHVwX3VwZCA+IDAg RlJPTSBwZ19zdGF0X2FsbF90YWJsZXMgV0hFUkUgcmVsaWQgPSAncGdfc2hkZXNjcmlwdGlvbic6 OnJlZ2NsYXNzOworID9jb2x1bW4/IAorLS0tLS0tLS0tLQorIHQKKygxIHJvdykKKworU0VMRUNU IHBnX3N0YXRfcmVzZXRfc2luZ2xlX3RhYmxlX2NvdW50ZXJzKCdwZ19zaGRlc2NyaXB0aW9uJzo6 cmVnY2xhc3MpOworIHBnX3N0YXRfcmVzZXRfc2luZ2xlX3RhYmxlX2NvdW50ZXJzIAorLS0tLS0t LS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLQorIAorKDEgcm93KQorCitTRUxFQ1Qgbl90 dXBfaW5zICsgbl90dXBfdXBkIEZST00gcGdfc3RhdF9hbGxfdGFibGVzIFdIRVJFIHJlbGlkID0g J3BnX3NoZGVzY3JpcHRpb24nOjpyZWdjbGFzczsKKyA/Y29sdW1uPyAKKy0tLS0tLS0tLS0KKyAg ICAgICAgMAorKDEgcm93KQorCistLSBjbGVhbnVwIHRoZSBjb21tZW50CitcaWYgOns/ZGVzY3Jp cHRpb25fYmVmb3JlfQorICBDT01NRU5UIE9OIERBVEFCQVNFIDoiY3VycmVudF9kYXRhYmFzZSIg SVMgOidkZXNjcmlwdGlvbl9iZWZvcmUnOworXGVsc2UKKyAgQ09NTUVOVCBPTiBEQVRBQkFTRSA6 ImN1cnJlbnRfZGF0YWJhc2UiIElTIE5VTEw7CitcZW5kaWYKIC0tLS0tCiAtLSBUZXN0IHRoYXQg dmFyaW91cyBzdGF0cyB2aWV3cyBhcmUgYmVpbmcgcHJvcGVybHkgcG9wdWxhdGVkCiAtLS0tLQpk aWZmIC0tZ2l0IGEvc3JjL3Rlc3QvcmVncmVzcy9zcWwvc3RhdHMuc3FsIGIvc3JjL3Rlc3QvcmVn cmVzcy9zcWwvc3RhdHMuc3FsCmluZGV4IDlhMTZkZjFjNDkuLjczNTExOGM0NTIgMTAwNjQ0Ci0t LSBhL3NyYy90ZXN0L3JlZ3Jlc3Mvc3FsL3N0YXRzLnNxbAorKysgYi9zcmMvdGVzdC9yZWdyZXNz L3NxbC9zdGF0cy5zcWwKQEAgLTM3Niw2ICszNzYsMzIgQEAgQ09NTUlUOwogU0VMRUNUIHNlcV9z Y2FuLCA6J3Rlc3RfbGFzdF9zZXEnID0gbGFzdF9zZXFfc2NhbiBBUyBzZXFfb2ssIGlkeF9zY2Fu LCA6J3Rlc3RfbGFzdF9pZHgnIDwgbGFzdF9pZHhfc2NhbiBBUyBpZHhfb2sKIEZST00gcGdfc3Rh dF9hbGxfdGFibGVzIFdIRVJFIHJlbGlkID0gJ3Rlc3RfbGFzdF9zY2FuJzo6cmVnY2xhc3M7CiAK Ky0tLS0tCistLSBUZXN0IHRvIHJlc2V0IHN0YXRzIGZvciBhIHRhYmxlIHNoYXJlZCBhY3Jvc3Mg YWxsIGRhdGFiYXNlcyAoZXguIHBnX3NoZGVzY3JpcHRpb24pCistLS0tLQorCistLSBzdG9yZSB0 aGUgb2xkIGNvbW1lbnQgdG8gcmVzZXQKK1NFTEVDVCBzaG9ial9kZXNjcmlwdGlvbihkLm9pZCwg J3BnX2RhdGFiYXNlJykgYXMgZGVzY3JpcHRpb25fYmVmb3JlCitGUk9NIHBnX2RhdGFiYXNlIGQg V0hFUkUgZGF0bmFtZSA9IGN1cnJlbnRfZGF0YWJhc2UoKSBcZ3NldAorCistLSB1cGRhdGUgdGhl IHN0YXRzIGluIHBnX3NoZGVzY3JpcHRpb24KK0JFR0lOOworU0VMRUNUIGN1cnJlbnRfZGF0YWJh c2UoKSBhcyBjdXJyZW50X2RhdGFiYXNlIFxnc2V0CitDT01NRU5UIE9OIERBVEFCQVNFIDoiY3Vy cmVudF9kYXRhYmFzZSIgSVMgJ1RoaXMgaXMgYSB0ZXN0IGNvbW1lbnQnOworU0VMRUNUIHBnX3N0 YXRfZm9yY2VfbmV4dF9mbHVzaCgpOworQ09NTUlUOworCistLSBjaGVjayB0byByZXNldCB0aGUg c3RhdHMKK1NFTEVDVCBuX3R1cF9pbnMgKyBuX3R1cF91cGQgPiAwIEZST00gcGdfc3RhdF9hbGxf dGFibGVzIFdIRVJFIHJlbGlkID0gJ3BnX3NoZGVzY3JpcHRpb24nOjpyZWdjbGFzczsKK1NFTEVD VCBwZ19zdGF0X3Jlc2V0X3NpbmdsZV90YWJsZV9jb3VudGVycygncGdfc2hkZXNjcmlwdGlvbic6 OnJlZ2NsYXNzKTsKK1NFTEVDVCBuX3R1cF9pbnMgKyBuX3R1cF91cGQgRlJPTSBwZ19zdGF0X2Fs bF90YWJsZXMgV0hFUkUgcmVsaWQgPSAncGdfc2hkZXNjcmlwdGlvbic6OnJlZ2NsYXNzOworCist LSBjbGVhbnVwIHRoZSBjb21tZW50CitcaWYgOns/ZGVzY3JpcHRpb25fYmVmb3JlfQorICBDT01N RU5UIE9OIERBVEFCQVNFIDoiY3VycmVudF9kYXRhYmFzZSIgSVMgOidkZXNjcmlwdGlvbl9iZWZv cmUnOworXGVsc2UKKyAgQ09NTUVOVCBPTiBEQVRBQkFTRSA6ImN1cnJlbnRfZGF0YWJhc2UiIElT IE5VTEw7CitcZW5kaWYKIAogLS0tLS0KIC0tIFRlc3QgdGhhdCB2YXJpb3VzIHN0YXRzIHZpZXdz IGFyZSBiZWluZyBwcm9wZXJseSBwb3B1bGF0ZWQKLS0gCjIuMjUuMQoK --=_65d92d8cd986e8b8630e9dc4a63aaee8--