From: Tom Lane <tgl@sss.pgh.pa.us>
To: Ashutosh Bapat <ashutosh.bapat.oss@gmail.com>
cc: Alvaro Herrera <alvherre@alvh.no-ip.org>,
        PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Subject: Re: Relids instead of Bitmapset * in plannode.h
In-reply-to: <CAExHW5vjq4iUGEVVZhs7DNNjuRD0v8aqoKGn27zkNEzFK=sCbg@mail.gmail.com>
References: <202311071106.6y7b2ascqjlz@alvherre.pgsql> <122451.1699370672@sss.pgh.pa.us> <CAExHW5vjq4iUGEVVZhs7DNNjuRD0v8aqoKGn27zkNEzFK=sCbg@mail.gmail.com>
Comments: In-reply-to Ashutosh Bapat <ashutosh.bapat.oss@gmail.com>
	message dated "Thu, 09 Nov 2023 11:12:28 +0530"
MIME-Version: 1.0
Content-Type: text/plain; charset="UTF-8"
Content-ID: <941944.1699510121.1@sss.pgh.pa.us>
Content-Transfer-Encoding: 8bit
Date: Thu, 09 Nov 2023 01:08:41 -0500
Message-ID: <941945.1699510121@sss.pgh.pa.us>
Archived-At: <https://www.postgresql.org/message-id/941945.1699510121%40sss.pgh.pa.us>
Precedence: bulk

Ashutosh Bapat <ashutosh.bapat.oss@gmail.com> writes:
> On Tue, Nov 7, 2023 at 8:54 PM Tom Lane <tgl@sss.pgh.pa.us> wrote:
>> Yes, I'm pretty sure that's exactly the reason, and I'm strongly
>> against the initially-proposed patch.  The include footprint of
>> pathnodes.h would be greatly expanded, for no real benefit.

> As I mentioned in [1] the Bitmapset implementation is not space
> efficient to be used as Relids when there are thousands of partitions.

TBH, I'd be very strongly against "optimizing" that case by adopting a
data structure that is less efficient for typical rangetable sizes.
I continue to think that anybody who is using that many partitions
is Doing It Wrong and has no excuse for thinking it'll be free.
Moreover, the size of their relid sets is pretty unlikely to be
their worst pain point.

In any case, that is a poor argument for weakening the separation
between planner and executor.  When and if somebody comes up with
a credible replacement for bitmapsets here, we can consider what
we want to do in terms of header-file organization --- but I do
not think including pathnodes.h into executor files will be it.

			regards, tom lane