From: Tom Lane <tgl@sss.pgh.pa.us>
To: John Naylor <jcnaylor@gmail.com>
cc: Andrew Dunstan <andrew.dunstan@2ndquadrant.com>,
        Stas Kelvich <s.kelvich@postgrespro.ru>,
        PostgreSQL Hackers <pgsql-hackers@postgresql.org>
Subject: Re: unused_oids script is broken with bsd sed
In-reply-to: 
 <CAJVSVGUqEPFWxRSB0pxO5jHR83O2HF6n9Dhv51kLQuwdkuxTHQ@mail.gmail.com>
References: <37D774E4-FE1F-437E-B3D2-593F314B7505@postgrespro.ru>
 <34a54c54-9132-1254-2bc3-d3489fb79728@2ndQuadrant.com>
 <4473.1524665917@sss.pgh.pa.us>
 <CAJVSVGUqEPFWxRSB0pxO5jHR83O2HF6n9Dhv51kLQuwdkuxTHQ@mail.gmail.com>
Comments: In-reply-to John Naylor <jcnaylor@gmail.com>
	message dated "Thu, 26 Apr 2018 01:14:08 +0700"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <9425.1524680795.1@sss.pgh.pa.us>
Date: Wed, 25 Apr 2018 14:26:35 -0400
Message-ID: <9426.1524680795@sss.pgh.pa.us>
Precedence: bulk

John Naylor <jcnaylor@gmail.com> writes:
> On 4/25/18, Tom Lane <tgl@sss.pgh.pa.us> wrote:
>> I think we should rewrite
>> both of them to use the Catalog.pm infrastructure.

> If we're going to use Catalog.pm for that, it seems more convenient to
> expose toast and index oids directly rather than in strings formatted
> specifically for the bki file, as in the attached. Thoughts?

Good idea, I like this better than what Stas did in his patch.

I'm a bit inclined to preserve the old variable names (toast_name,
toast_oid etc) as the hash keys because they seem more greppable
than the generic "oid", "name" that you have here.  But maybe that
isn't an interesting consideration.

			regards, tom lane