Message-ID: <9427c6b3-5e0b-e27f-a2e7-ec1ebc00b582@pgmasters.net>
Date: Wed, 1 Dec 2021 11:27:42 -0500
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0)
 Gecko/20100101 Thunderbird/91.3.2
Subject: Re: Postgres restart in the middle of exclusive backup and the
 presence of backup_label file
Content-Language: en-US
To: "Bossart, Nathan" <bossartn@amazon.com>, Tom Lane <tgl@sss.pgh.pa.us>
Cc: Stephen Frost <sfrost@snowman.net>,
 Laurenz Albe <laurenz.albe@cybertec.at>,
 Michael Paquier <michael@paquier.xyz>,
 Pg Hackers <pgsql-hackers@postgresql.org>,
 SATYANARAYANA NARLAPURAM <satyanarlapuram@gmail.com>
References: 
 <CAHg+QDfiM+WU61tF6=nPZocMZvHDzCK47Kneyb0ZRULYzV5sKQ@mail.gmail.com>
 <YZ7Amotspa4ve+91@paquier.xyz>
 <CAHg+QDekOasWArvmPeOqhyTUHR40DsDOWyt7OaKxpQ7eFYqysw@mail.gmail.com>
 <YaB3Oj4GfPOZ/3LC@paquier.xyz> <417711.1637940660@sss.pgh.pa.us>
 <20211130142042.GR26257@tamriel.snowman.net>
 <3404870c1a921bafbcd168c098088981fe082ab1.camel@cybertec.at>
 <CAOuzzgoYqzH+c_fzapjGFh6kiZjXDc0jPCQctbQjajn7a4vyxA@mail.gmail.com>
 <845544A4-0B0E-41D2-903C-C8B9E8A18812@amazon.com>
 <1661037.1638311167@sss.pgh.pa.us>
 <1cce9981-2c48-981a-a936-812830dfb3b1@pgmasters.net>
 <BC31E8F0-7CFF-462E-9B27-727AD573A675@amazon.com>
From: David Steele <david@pgmasters.net>
In-Reply-To: <BC31E8F0-7CFF-462E-9B27-727AD573A675@amazon.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Archived-At: 
 <https://www.postgresql.org/message-id/9427c6b3-5e0b-e27f-a2e7-ec1ebc00b582%40pgmasters.net>
Precedence: bulk

On 11/30/21 18:31, Bossart, Nathan wrote:
> On 11/30/21, 2:58 PM, "David Steele" <david@pgmasters.net> wrote:
>> I did figure out how to keep the safe part of exclusive backup (not
>> having to maintain a connection) while removing the dangerous part
>> (writing backup_label into PGDATA), but it was a substantial amount of
>> work and I felt that it had little chance of being committed.
> 
> Do you think it's still worth trying to make it safe, or do you think
> we should just remove exclusive mode completely?

My preference would be to remove it completely, but I haven't gotten a 
lot of traction so far.

>> Attaching the thread [1] that I started with a patch to remove exclusive
>> backup for reference.
> 
> Ah, good, some light reading.  :)

Sure, if you say so!

Regards,
-David