From: Tom Lane <tgl@sss.pgh.pa.us>
To: Robert Haas <robertmhaas@gmail.com>
cc: Amul Sul <sulamul@gmail.com>, Sravan Kumar <sravanvcybage@gmail.com>,
        PostgreSQL-development <pgsql-hackers@postgresql.org>
Subject: Re: pg_verifybackup: TAR format backup verification
In-reply-to: 
 <CA+TgmoYyC85N-YxsDNPK1Z=q_12OG5Pg2Eey78CjpkMxGqYLZw@mail.gmail.com>
References: 
 <CAAJ_b94StvLWrc_p4q-f7n3OPfr6GhL8_XuAg2aAaYZp1tF-nw@mail.gmail.com>
 <CA+=NbjjkFADANQoyvgTQfKH8ZerxpmsJD70R17V8ZtfaoyRYwg@mail.gmail.com>
 <CAAJ_b96xU5fOOvWhJyMvvDCirJEZZdjieZZbyf0PnYukFQCy+Q@mail.gmail.com>
 <CA+Tgmoa0FVRbC9EG5GDaXORqMsoj8AnEDV4FVXwbLENKqwQqaA@mail.gmail.com>
 <CAAJ_b96Gwh=6zwpqsD-sVNOeYcU=9rfBygVtuXmU3qFAiNr2Hw@mail.gmail.com>
 <CA+Tgmobmi7qiu8HDQECwuy-JrAH0zcYbzGnhnKjurqv44DHtxg@mail.gmail.com>
 <CAAJ_b94sxUN73kNZ_Z5sP0GDEZGAxKgW0PvS5CBJXiH212+Fww@mail.gmail.com>
 <CA+Tgmoboyugvh0C-QWfzQK0nNgOHrxGnQQiOROjaa--+Aqr2xg@mail.gmail.com>
 <CAAJ_b975Pyo53P-zvkTPjVFErEANuRP9+K=2Qnifiy6BJBtwfw@mail.gmail.com>
 <CA+Tgmobt6=v-jE4iJ2kBGQ=jfubX_7fdOe4Uf9TWhKn+cfjGfw@mail.gmail.com>
 <CAAJ_b95rXAsyuetre9Wc-W6uHW-=ivVj56F8-w4gfrTGsnRRSA@mail.gmail.com>
 <CA+TgmoZw9dc6w-FFFJvuFMEfB11c+tDRyW+BjWD89+NG8bV=iA@mail.gmail.com>
 <CAAJ_b95mcGjkfAf1qduOR97CokW8-_i-dWLm3v6x1w2-OW9M+A@mail.gmail.com>
 <CA+TgmoZTJzUyzDkdo6K7TTM2ePP0EMXTwxGhJN1Ymx3qNHvevQ@mail.gmail.com>
 <CAAJ_b95e9!
 oNpQ+EdLgKX+aLJXwpWAy2EZsLBFSB9=XSPs4hhFg@mail.gmail.com>
 <CAAJ_b972EmWT+a63wtTAwfGF3QpYZkzwov5UPh=JPmgJY=dW8A@mail.gmail.com>
 <CA+TgmobUiaquaz7CTzDDpJu5e6XYuvxEc4e+HXEvUqn7PD4byw@mail.gmail.com>
 <CAAJ_b976LwbmzJLDLTw6ScAVbH7mtxWhj12MWtyRYSkCSjOcfw@mail.gmail.com>
 <CA+TgmoZ-fwQ0aWUs_40oXkEpF7JAn4D9SnKj8dj=qGLtO0VSRw@mail.gmail.com>
 <CA+Tgmobs-gbRUMGPpzVZnPPP=cgeEO7hnzV2yKmM0BQ=MGQSMg@mail.gmail.com>
 <CAAJ_b955y7NrkTUGtiyoGkPBs-OgYMv32iW0WTSpVfpFpezxdQ@mail.gmail.com>
 <CA+Tgmob3zhdDM=ggw-NrV-jrvLP7a-otWFn5F+5oOputiFdhmQ@mail.gmail.com>
 <CAAJ_b96RBwBMkgK3gzzm+94m6jvdbMi--8RzxaQLu-2+52Nj6g@mail.gmail.com>
 <CA+TgmoZBPKaonc=rE0d7YUm3fzeQTftP6o=8vqFDe1AY2nmbrw@mail.gmail.com>
 <1115881.1727564342@sss.pgh.pa.us>
 <CA+TgmoYHyUxkTW4CdwpdVsB4V-Mq+YWs7FwEsuSJq057+fSVoQ@mail.gmail.com>
 <1466068.1727709896@sss.pgh.pa.us>
 <CA+TgmoYAUxW4GzEK4puDtA_HNaWPJxfmgqQX8oDkRM3krGJuUg@mail.gmail.com>
 <CA+Tgmobazb7N0yURs1Cs0bmidFo+JTiqBFrZmw95B=bwPiW4dQ@mail.gmail.com>
 <1831796.1727794088@sss.pgh.pa.u!
 s> <1865585.1727803933@sss.pgh.pa.us>
 <CA+TgmoYyC85N-YxsDNPK1Z=q_12OG5Pg2Eey78CjpkMxGqYLZw@mail.gmail.com>
Comments: In-reply-to Robert Haas <robertmhaas@gmail.com>
	message dated "Wed, 02 Oct 2024 10:09:45 -0400"
MIME-Version: 1.0
Content-Type: text/plain; charset="UTF-8"
Content-ID: <9467.1727895630.1@sss.pgh.pa.us>
Content-Transfer-Encoding: quoted-printable
Date: Wed, 02 Oct 2024 15:00:30 -0400
Message-ID: <9468.1727895630@sss.pgh.pa.us>
Archived-At: 
 <https://www.postgresql.org/message-id/9468.1727895630%40sss.pgh.pa.us>
Precedence: bulk

Robert Haas <robertmhaas@gmail.com> writes:
> On Tue, Oct 1, 2024 at 1:32=E2=80=AFPM Tom Lane <tgl@sss.pgh.pa.us> wrot=
e:
>> Yes, mamba thinks this is OK.

> Committed.

Sadly, it seems adder[1] is even pickier than mamba:

../pgsql/src/backend/backup/basebackup_incremental.c: In function \342\200=
\230CreateIncrementalBackupInfo\342\200\231:
../pgsql/src/backend/backup/basebackup_incremental.c:179:30: error: assign=
ment to \342\200\230json_manifest_per_file_callback\342\200\231 {aka \342\=
200\230void (*)(JsonManifestParseContext *, const char *, long long unsign=
ed int,  pg_checksum_type,  int,  unsigned char *)\342\200\231} from incom=
patible pointer type \342\200\230void (*)(JsonManifestParseContext *, cons=
t char *, size_t,  pg_checksum_type,  int,  uint8 *)\342\200\231 {aka \342=
\200\230void (*)(JsonManifestParseContext *, const char *, unsigned int,  =
pg_checksum_type,  int,  unsigned char *)\342\200\231} [-Wincompatible-poi=
nter-types]
  179 |         context->per_file_cb =3D manifest_process_file;
      |                              ^


			regards, tom lane

[1] https://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=3Dadder&dt=3D2=
024-10-02%2014%3A09%3A58