Content-Type: text/plain;
	charset=utf-8
Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3826.700.81\))
Subject: Re: Cleanup shadows variable warnings, round 1
From: Chao Li <li.evan.chao@gmail.com>
In-Reply-To: 
 <CAHut+PvrcSUabnsuH+77+yEwvjiLHy0XJiLuTtVHWed_MHdwMw@mail.gmail.com>
Date: Wed, 3 Dec 2025 14:52:14 +0800
Cc: Peter Eisentraut <peter@eisentraut.org>,
 Postgres hackers <pgsql-hackers@lists.postgresql.org>
Content-Transfer-Encoding: quoted-printable
Message-Id: <94ECEF6E-681B-40DF-8F6B-4CABE4CDB96A@gmail.com>
References: 
 <CAEoWx2kQ2x5gMaj8tHLJ3=jfC+p5YXHkJyHrDTiQw2nn2FJTmQ@mail.gmail.com>
 <c981068f-008a-4951-992a-4d2159b9d656@eisentraut.org>
 <CAEoWx2kjuQTQg=ZO76R7yKSj27zEHqehhL15UaK2D=vAw2JgYw@mail.gmail.com>
 <CAHut+PvrcSUabnsuH+77+yEwvjiLHy0XJiLuTtVHWed_MHdwMw@mail.gmail.com>
To: Peter Smith <smithpb2250@gmail.com>
Archived-At: 
 <https://www.postgresql.org/message-id/94ECEF6E-681B-40DF-8F6B-4CABE4CDB96A%40gmail.com>
Precedence: bulk


> On Dec 3, 2025, at 14:42, Peter Smith <smithpb2250@gmail.com> wrote:
>=20
> Patch v2-0001.
>=20
> src/backend/backup/basebackup_incremental.c:
> PrepareForIncrementalBackup:
>=20
> Instead of changing the var name from 'i' to 'u', you can fix this one
> by changing all the for loops to declare 'i' within the 'for ('.
> That way kills two birds with one stone: it removes the shadow warning
> and at the same time improves the scope of the loop variables.
>=20
>=20
> -       int                     i;
>=20
> -       for (i =3D 0; i < num_wal_ranges; ++i)
> +       for (int i =3D 0; i < num_wal_ranges; ++i)
>=20
> -       for (i =3D 0; i < num_wal_ranges; ++i)
> +       for (int i =3D 0; i < num_wal_ranges; ++i)
>=20
> -       unsigned        i;
>=20
> -               for (i =3D 0; i < nblocks; ++i)
> +               for (unsigned i =3D 0; i < nblocks; ++i)

Unfortunately that doesn=E2=80=99t work for my compiler (clang on =
MacOS), that=E2=80=99s why I renamed =E2=80=9CI" to =E2=80=9Cu=E2=80=9D.

By the way, Peter (S), thank you very much for reviewing.

Best regards,
--
Chao Li (Evan)
HighGo Software Co., Ltd.
https://www.highgo.com/