Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ceLuV-0005q4-T1 for pgsql-hackers@arkaria.postgresql.org; Thu, 16 Feb 2017 13:15:47 +0000 Received: from localhost ([127.0.0.1] helo=postgresql.org) by malur.postgresql.org with smtp (Exim 4.84_2) (envelope-from ) id 1ceLuV-0003dd-9p for pgsql-hackers@arkaria.postgresql.org; Thu, 16 Feb 2017 13:15:47 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1ceLuU-0003cd-DC for pgsql-hackers@postgresql.org; Thu, 16 Feb 2017 13:15:46 +0000 Received: from out3-smtp.messagingengine.com ([66.111.4.27]) by magus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1ceLuS-0007JA-A5 for pgsql-hackers@postgresql.org; Thu, 16 Feb 2017 13:15:45 +0000 Received: from compute7.internal (compute7.nyi.internal [10.202.2.47]) by mailout.nyi.internal (Postfix) with ESMTP id 0555F209B0; Thu, 16 Feb 2017 08:15:41 -0500 (EST) Received: from frontend2 ([10.202.2.161]) by compute7.internal (MEProxy); Thu, 16 Feb 2017 08:15:42 -0500 DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-sender:x-me-sender:x-sasl-enc:x-sasl-enc; s= smtpout; bh=KMZeeqUcVdPpRV3i8eArETKyv0o=; b=JaOtuq+1C4G8BQwEuPZV +VxpCLBJ7Rfj4VoG6fojWTSPJjfQ+N1XmGejaMeSkwima0i0ZAUM6EHUFERO1SRq KkdMuNAS2LadrNtAiWx1SHjW2ZZSgh7+BeIbJVhaC5yxBLGZ4tZgKXESyYQmQiw+ q8HK2tklsW8Yerje9U9sh54= X-ME-Sender: X-Sasl-enc: 0iCmvriO2fGJKYDwJfEZBdF6JIOutElHwDmIgLspo2Cw 1487250941 Received: from april.local (c-73-13-66-39.hsd1.pa.comcast.net [73.13.66.39]) by mail.messagingengine.com (Postfix) with ESMTPA id 994BD2450F; Thu, 16 Feb 2017 08:15:41 -0500 (EST) Subject: Re: ICU integration To: Peter Geoghegan References: <85364fde-091f-bbc0-fec2-e3ede39840a6@2ndquadrant.com> <3a88fa29-275b-f547-9957-86d4b2cd68db@2ndquadrant.com> Cc: Thomas Munro , pgsql-hackers From: Peter Eisentraut Organization: 2ndQuadrant Message-ID: <94ac0476-e449-4cc0-d4bd-76d39576979d@2ndquadrant.com> Date: Thu, 16 Feb 2017 08:15:46 -0500 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.12; rv:45.0) Gecko/20100101 Thunderbird/45.7.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-Pg-Spam-Score: -2.6 (--) List-Archive: List-Help: List-ID: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: X-Mailing-List: pgsql-hackers Precedence: bulk Sender: pgsql-hackers-owner@postgresql.org On 2/16/17 01:13, Peter Geoghegan wrote: > On Wed, Feb 15, 2017 at 9:17 PM, Peter Eisentraut > wrote: >> I have changed it to use ucol_nextSortKeyPart() when appropriate. > > I think it would be fine if the second last argument was > "sizeof(Datum)", not "Min(sizeof(Datum), sss->buflen2)" here: I don't see anything that guarantees that the buffer length is always at least sizeof(Datum). -- Peter Eisentraut http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers