Content-Type: text/plain;
	charset=utf-8
Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3826.700.81.1.4\))
Subject: Re: ALTER TABLE: warn when actions do not recurse to partitions
From: Chao Li <li.evan.chao@gmail.com>
In-Reply-To: <6eff5e43-cacd-4a2a-ad1d-e3b313c86050@uni-muenster.de>
Date: Wed, 14 Jan 2026 08:52:18 +0800
Cc: "David G. Johnston" <david.g.johnston@gmail.com>,
 Greg Sabino Mullane <htamfids@gmail.com>,
 Postgres hackers <pgsql-hackers@lists.postgresql.org>
Content-Transfer-Encoding: quoted-printable
Message-Id: <950BB7B5-0180-4C36-82A0-7E17B920F740@gmail.com>
References: <CAEoWx2=SLga-xH09Cq_PAvsHhQHrBK+V0vF821JKgzS=Bm0haA@mail.gmail.com>
 <CAKFQuwZXt2dAuHFs6MtRCzfMP6YZFzssuzdW2woJBVmco=CDdQ@mail.gmail.com>
 <CAEoWx2nic2MaPUEKwb0Me1iwO3LsCf8wUHm55pjqaTRgJEZpcQ@mail.gmail.com>
 <CAKFQuwahxpPKT-LXGJ34BO5cVBUxFxzgNPTY8E_VW-cuNU_DkQ@mail.gmail.com>
 <CAEoWx2kQ9aSn-0LGPKc=woj+h-HR4uBV9TL20aeM3HzLmFqgFQ@mail.gmail.com>
 <6eff5e43-cacd-4a2a-ad1d-e3b313c86050@uni-muenster.de>
To: Jim Jones <jim.jones@uni-muenster.de>
Archived-At: <https://www.postgresql.org/message-id/950BB7B5-0180-4C36-82A0-7E17B920F740%40gmail.com>
Precedence: bulk


> On Jan 13, 2026, at 19:16, Jim Jones <jim.jones@uni-muenster.de> =
wrote:
>=20
> Hi Chao
>=20
> On 13/01/2026 05:02, Chao Li wrote:
>>=20
>> PSA v3:
>>=20
>> * Rephrased the notice message as David's suggestion.
>> * Removed partition count from notice message.
>> * If a partitioned table doesn't have any partition, then suppress =
the
>> message.
>=20
> I've been playing with this patch, and it seems to work as expected -
> I'm surprised it didn't break any existing tests :). Do you plan to
> extend this patch to other subcommands mentioned in your initial post,
> such as SET STATISTICS?
>=20
> Thanks for the patch
>=20
> Best, Jim
>=20

Hi Jim,

Thanks for your testing. Yes, I plan to add the notice to other =
sub-commands as needed. I only updated REPLICA IDENTITY first to call =
for feedback. As you see, David has suggested the great wording for the =
notice message. Once the change on REPLICA IDENTITY is reviewed, it=E2=80=99=
s easy to extend to other sub-commands.

Best regards,
--
Chao Li (Evan)
HighGo Software Co., Ltd.
https://www.highgo.com/