From: Tom Lane <tgl@sss.pgh.pa.us>
To: Julien Rouhaud <rjuju123@gmail.com>
cc: 
 =?UTF-8?B?0JzQtdC70YzQvdC40LrQvtCyINCQ0L3RgtC+0L0g0JDQvdC00YDQtdC10LLQuNGH?=
 <aamelnikov@inbox.ru>,
        pgsql-hackers <pgsql-hackers@postgresql.org>
Subject: Re: installcheck fails when compute_query_id=on or pg_stat_statsement
 is loaded
In-reply-to: 
 <CAOBaU_b57L=NxBaOEGHZ2M35LYZKsLu2YkekhB7yZ4=CrGo+cA@mail.gmail.com>
References: <1634283396.372373993@f75.i.mail.ru>
 <CAOBaU_b57L=NxBaOEGHZ2M35LYZKsLu2YkekhB7yZ4=CrGo+cA@mail.gmail.com>
Comments: In-reply-to Julien Rouhaud <rjuju123@gmail.com>
	message dated "Fri, 15 Oct 2021 16:35:25 +0800"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <952791.1634305578.1@sss.pgh.pa.us>
Date: Fri, 15 Oct 2021 09:46:18 -0400
Message-ID: <952792.1634305578@sss.pgh.pa.us>
Archived-At: 
 <https://www.postgresql.org/message-id/952792.1634305578%40sss.pgh.pa.us>
Precedence: bulk

Julien Rouhaud <rjuju123@gmail.com> writes:
> ... Note that you don't really need to enable
> pg_stat_statements, enabling compute_query_id is enough.  The query
> identifier is only displayed for EXPLAIN (VERBOSE), so it's already a
> bit filtered.  I don't see any simple way to entirely avoid the
> problem though.

> There are already many options that can break the regression tests, so
> maybe it's ok to accept that this is yet another one.

Yeah, that's my reaction.  We could add "compute_query_id = off" to
the database-level settings set up by pg_regress, but that cure seems
worse than the disease.  It would make it impossible to run the
regression tests with pg_stat_statements loaded, which you might wish
to do (just ignoring the bogus test failures) as a way of testing
pg_stat_statements.

			regards, tom lane