Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1w92wE-0018zq-1h for pgsql-hackers@arkaria.postgresql.org; Sat, 04 Apr 2026 15:29:31 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.96) (envelope-from ) id 1w92wC-00GyLr-27 for pgsql-hackers@arkaria.postgresql.org; Sat, 04 Apr 2026 15:29:29 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1w92wC-00GyLi-0A for pgsql-hackers@lists.postgresql.org; Sat, 04 Apr 2026 15:29:28 +0000 Received: from mail-wr1-x42b.google.com ([2a00:1450:4864:20::42b]) by makus.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.98.2) (envelope-from ) id 1w92w7-00000000XSr-357V for pgsql-hackers@lists.postgresql.org; Sat, 04 Apr 2026 15:29:27 +0000 Received: by mail-wr1-x42b.google.com with SMTP id ffacd0b85a97d-43d03db7f87so1456540f8f.3 for ; Sat, 04 Apr 2026 08:29:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cybertec.at; s=google; t=1775316561; x=1775921361; darn=lists.postgresql.org; h=message-id:date:mime-version:comments:references:in-reply-to :subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to; bh=uIMCCx09pOcz6dP/hdWWMvZEkD0BRctivUS3Imqho2U=; b=Qcs1rNZsw2cBLxiXTdKxqj2Nf2YhAxYhHgey9glE5x+mQjmftbvHzK6CiIeebxWyFF 5GIay3O2LflYxJRtddx3WAgI24gYiv87Q6tsYw3yZVJMPuxC+D9kO6jAfGSgNdNPxfF9 GckJ5XsJwENFn8fV0IBLZexWumPsrNVYY5LvzmCa7ePjO4vh1LZooyewEcvH9AOGeRJ8 18rg3b4gXBYzTdfBHrXZ67+yfb9Z8t1g9oFjgExwpMWuWoengL22NfaW6B7L8QyLfOIo HrxGTT22geX7Xue0GioxIjvxHbACcDuo+ytaazlBWUozQHxtNqs1dLknR/m9mSwzYh4K +OoQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1775316561; x=1775921361; h=message-id:date:mime-version:comments:references:in-reply-to :subject:cc:to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=uIMCCx09pOcz6dP/hdWWMvZEkD0BRctivUS3Imqho2U=; b=EvVY1NtRhhLLyh8uAP8T08ABXmESKOyhd/AoidPbzEV+N3lTHUOQjbBMxHRx6/nfHL 8EghMrDwZlMhJBMrCNzEiP9n0of5jxsgyFLa+owtPAT0fsPgcv3bclZWV66ze/sICPYw Aufd+6tXoK+91IfZadsqlwmZn4VGww1V6wUVtwS9IqOj5h5F012A2yNW301mKExoVeBM 2rF37/FQzTjUMtKgYBRmRzJac7VxS6nBBHQCHOasPXEeMZwJGWCXGfJ0L8U0baoyYwey LbNQ94m8U/IXW5Jmlqw01rezOeRrT68I5O6k6h9I/SbBYN7jCvyjXp6Szj6DDOq0LiM4 M4sQ== X-Forwarded-Encrypted: i=1; AJvYcCWepexOhRUXyD9QuElJ4c4X1Wgu8pUA3Tgm99wPFhMn+en+1D4UN2OKZLT7ObGAlho1EkkPEmFDG/6uXgCt@lists.postgresql.org X-Gm-Message-State: AOJu0YyIMWgM5sqDZ+xsklCFfVWxswgNP6gVgTr9XtZWv/q1Od+1M+pi 8rZI4bJ+LjVqIgtmRkYUhFIIZqTl6qZiONmzLPvf18uP3ATl/iD22gSIbY/mDnR7ypo= X-Gm-Gg: AeBDietoHzQiox/ZW9+TSI4zKjjJTxPZ/8un2div4RH6c/5vQiI80VgTBOWJGXF3YUV 43LG4cAwnN30bA83aUR+lPEvqkN9YT+yVpXp2/ogls6H0Uj5NWKYskETcEasFWY5Mr+WES5jJk/ hvQbPCv9nJnmzq/JE3V57DzwVfa+5yR1vJTwBEAgIfvECefgdTr62C02w3DyatSNST1U6Db6Fq4 TbZZwekgpvnDqXlwCTYGNExUODGUuXlwdtGrTjRuPUkXkX8vgJpVa+D+N3tl0XQ9OJ9xkjrqaxz OGM7AYzuMT1YBU1/EQm//Tqta156d2BgToqFs43na7FuUj0FBvnkgAzvUUPsQgJRXTNyxi80Qce 9pE5ZLsvotK01E+D00oXCox9YA6sVj1Z86xVkrg2e/wpKxZvuqeQri5EDzoMg9qAa53RUcmV/ar bDsuxznjbClzofNX05+2eZS7lke4vUXrQCQDKu X-Received: by 2002:a05:6000:4010:b0:43d:1e97:d62e with SMTP id ffacd0b85a97d-43d292e4100mr10700543f8f.24.1775316560563; Sat, 04 Apr 2026 08:29:20 -0700 (PDT) Received: from localhost (109-81-168-142.rct.o2.cz. [109.81.168.142]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-43d1e4f5016sm26567002f8f.33.2026.04.04.08.29.19 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 04 Apr 2026 08:29:20 -0700 (PDT) From: Antonin Houska To: Alvaro Herrera cc: Srinath Reddy Sadipiralla , Amit Kapila , Mihail Nikalayeu , Matthias van de Meent , Pg Hackers , Robert Treat Subject: Re: Adding REPACK [concurrently] In-reply-to: <202604040948.ejtohc7kjqif@alvherre.pgsql> References: <202604040948.ejtohc7kjqif@alvherre.pgsql> Comments: In-reply-to Alvaro Herrera message dated "Sat, 04 Apr 2026 11:48:58 +0200." X-Mailer: MH-E 8.6+git; nmh 1.8; GNU Emacs 28.3 MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" Date: Sat, 04 Apr 2026 17:29:19 +0200 Message-ID: <95398.1775316559@localhost> List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk --=-=-= Content-Type: text/plain Alvaro Herrera wrote: > On 2026-Apr-04, Antonin Houska wrote: > > > I agree that the global variable is not handy, but instead of modifying > > CreateInitDecodingContext(), how about adding a boolean returning callback to > > OutputPluginCallbacks? The point is that whether shared catalogs are needed > > during the decoding or not is actually property of the plugin. > > Oh, yeah, that sounds good to me. This is it. New callback was actually not needed, I just added a new flag to the OutputPluginOptions structure. -- Antonin Houska Web: https://www.cybertec-postgresql.com --=-=-= Content-Type: text/x-diff Content-Disposition: attachment; filename=nocfbot.v52-0008.2-Introduce-an-option-to-make-logical-replication-.patch