From: Tom Lane <tgl@sss.pgh.pa.us>
To: Bruce Momjian <bruce@momjian.us>
cc: Dave Cramer <davecramer@gmail.com>,
        Alvaro Herrera <alvherre@alvh.no-ip.org>,
        "David G. Johnston" <david.g.johnston@gmail.com>,
        PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Subject: Re: pg_upgrade does not upgrade pg_stat_statements properly
In-reply-to: <20210729222601.GX9600@momjian.us>
References: <20210729163448.GP9600@momjian.us>
 <202107291743.pqlj3s2uilfu@alvherre.pgsql> <20210729190645.GS9600@momjian.us>
 <CADK3HHLZP=3HYNY_qsVBDQt83F7QpY_WrqXGN=KkQZCxraOyLA@mail.gmail.com>
 <915981.1627592484@sss.pgh.pa.us> <20210729221103.GV9600@momjian.us>
 <953847.1627597196@sss.pgh.pa.us> <20210729222601.GX9600@momjian.us>
Comments: In-reply-to Bruce Momjian <bruce@momjian.us>
	message dated "Thu, 29 Jul 2021 18:26:01 -0400"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <954339.1627597751.1@sss.pgh.pa.us>
Date: Thu, 29 Jul 2021 18:29:11 -0400
Message-ID: <954340.1627597751@sss.pgh.pa.us>
Archived-At: 
 <https://www.postgresql.org/message-id/954340.1627597751%40sss.pgh.pa.us>
Precedence: bulk

Bruce Momjian <bruce@momjian.us> writes:
> On Thu, Jul 29, 2021 at 06:19:56PM -0400, Tom Lane wrote:
>> I suggested awhile ago that pg_upgrade should look into
>> pg_available_extensions in the new cluster, and prepare
>> a script with ALTER EXTENSION UPDATE commands for
>> anything that's installed but is not the (new cluster's)
>> default version.

> I can do that, but I would think a pg_dump/restore would also have this
> issue, so should this be more generic?

No, because dump/restore does not have this issue.  Regular pg_dump just
issues "CREATE EXTENSION" commands, so you automatically get the target
server's default version.

			regards, tom lane