Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1viWU6-008j5Q-0Z for pgsql-hackers@arkaria.postgresql.org; Wed, 21 Jan 2026 11:34:50 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.96) (envelope-from ) id 1viWU4-006orB-38 for pgsql-hackers@arkaria.postgresql.org; Wed, 21 Jan 2026 11:34:49 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1viWU4-006or3-2B for pgsql-hackers@lists.postgresql.org; Wed, 21 Jan 2026 11:34:49 +0000 Received: from fhigh-b1-smtp.messagingengine.com ([202.12.124.152]) by magus.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1viWU2-001hzJ-2t for pgsql-hackers@postgresql.org; Wed, 21 Jan 2026 11:34:48 +0000 Received: from phl-compute-05.internal (phl-compute-05.internal [10.202.2.45]) by mailfhigh.stl.internal (Postfix) with ESMTP id 8E5D07A0060; Wed, 21 Jan 2026 06:34:44 -0500 (EST) Received: from phl-frontend-04 ([10.202.2.163]) by phl-compute-05.internal (MEProxy); Wed, 21 Jan 2026 06:34:44 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=eisentraut.org; h=cc:cc:content-transfer-encoding:content-type:content-type :date:date:from:from:in-reply-to:in-reply-to:message-id :mime-version:references:reply-to:subject:subject:to:to; s=fm1; t=1768995284; x=1769081684; bh=bmWw5FCWYFyZyJeB3ObD1UeZl/hkwwf6 NA6Zir5ip5Y=; b=SyugZHxur0ydURuNFkKOClvS5gFH8DSVv3i5EWC/brV9hKOX jIVAOnlQP3+kJrkYjWRCxV5VI3e0cjMstJn3PP1zBr2aryzQypQX3oPhpgAbsIg0 4TQgh06/ESyDoQhhCFyR+uML9EuwTYtWTjSl9bwHSx3W/eSEZ9ni0OJgfWZeWgY+ Uskk0oU8N8HYjRhnZz7r3rELFLhmrhDihGyF0tWRaffBbiH5B9SEuulacpFAGx50 zAjlbvmpGSVNVPnb9N/ERln3VrAD5S5RAONNWcJKAedooa8heZROnEUAWLITsIYA QxBUtMxZPU13VhO6G3w7iinv5rwghoaEbAW8+Q== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm2; t=1768995284; x= 1769081684; bh=bmWw5FCWYFyZyJeB3ObD1UeZl/hkwwf6NA6Zir5ip5Y=; b=b sNS7VgLXOPhUtZqdsv8dIsx2bcjcrobA/wMELM8g4DCvKiPS09Xw9rfYJWNaZu3W zT5ggb72u50KpdfcTOGEEhfJD8aAvU4fP0hFV4xoWSlz9xVQoB8J8+ZfCGJbx3Wp 87wPUcpRWQXvaj9IyIfza9v0Vp5LBOhr5h82WZqlJwlcbv0H0uNpwbVAoQCHOQZV mT29piN6xiWxKEkb7Io7n2I5nigcod3V4sphdGnAZ3SE5Kg3k6npyWmnSD50fO9M DNrRYSpzb3S4Fp7PK0KmIl9XCLbl+cpdCeP38H9/+cNKop0nWyiu7bKZVbkMu95Y kheNJ5nXITcdMhub4ovjQ== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeefgedrtddtgddugeefudejucetufdoteggodetrf dotffvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfurfetoffkrfgpnffqhgenuceu rghilhhouhhtmecufedttdenucenucfjughrpefkffggfgfuvfevfhfhjggtgfesthejre dttddvjeenucfhrhhomheprfgvthgvrhcugfhishgvnhhtrhgruhhtuceophgvthgvrhes vghishgvnhhtrhgruhhtrdhorhhgqeenucggtffrrghtthgvrhhnpefgjedthfekfedtue fgieelheetleejgefhueeltdfhueetvdffudekfeejhfegheenucevlhhushhtvghrufhi iigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehpvghtvghrsegvihhsvghnthhrrg huthdrohhrghdpnhgspghrtghpthhtohepvddpmhhouggvpehsmhhtphhouhhtpdhrtghp thhtohepphhoshhtghhrvghssehjvghlthgvfhdrnhhlpdhrtghpthhtohepphhgshhqlh dqhhgrtghkvghrshesphhoshhtghhrvghsqhhlrdhorhhg X-ME-Proxy: Feedback-ID: ie0a040ee:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Wed, 21 Jan 2026 06:34:43 -0500 (EST) Message-ID: <955ddaa3-d6e8-4d87-a368-ef9f25960d4e@eisentraut.org> Date: Wed, 21 Jan 2026 12:34:42 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: enable fallthrough warnings on clang To: Jelte Fennema-Nio Cc: pgsql-hackers References: <76a8efcd-925a-4eaf-bdd1-d972cd1a32ff@eisentraut.org> Content-Language: en-US From: Peter Eisentraut In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk On 20.01.26 16:03, Jelte Fennema-Nio wrote: > On Tue, 20 Jan 2026 at 12:16, Peter Eisentraut wrote: >> So my proposal is that we wrap the appropriate attribute into a >> pg_fallthrough macro, and replace the current comments with that. > > All looks okay to me. The only thing that stood out is that it checks > for C++ with __cpp_attributes instead of __cplusplus. Is it really > worth using this more specific attribute? Given that we're already > requiring C++11 and afaict all C++11 compilers should support the > general notion of attributes. I agree. I will make that change.