Received: from malur.postgresql.org ([217.196.149.56])
	by arkaria.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256)
	(Exim 4.89)
	(envelope-from <pgsql-hackers-owner+archive@lists.postgresql.org>)
	id 1gXouj-0000u1-NB
	for pgsql-hackers@arkaria.postgresql.org; Fri, 14 Dec 2018 14:58:05 +0000
Received: from localhost ([127.0.0.1] helo=malur.postgresql.org)
	by malur.postgresql.org with esmtp (Exim 4.89)
	(envelope-from <pgsql-hackers-owner+archive@lists.postgresql.org>)
	id 1gXouh-00059M-Uz
	for pgsql-hackers@arkaria.postgresql.org; Fri, 14 Dec 2018 14:58:03 +0000
Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29])
	by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256)
	(Exim 4.89)
	(envelope-from <tgl@sss.pgh.pa.us>)
	id 1gXouh-00059F-Nv
	for pgsql-hackers@lists.postgresql.org; Fri, 14 Dec 2018 14:58:03 +0000
Received: from sss.pgh.pa.us ([66.207.139.130])
	by magus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256)
	(Exim 4.89)
	(envelope-from <tgl@sss.pgh.pa.us>)
	id 1gXouf-0004IX-2b
	for pgsql-hackers@lists.postgresql.org; Fri, 14 Dec 2018 14:58:03 +0000
Received: from sss1.sss.pgh.pa.us (localhost [127.0.0.1])
	by sss.pgh.pa.us (8.14.4/8.14.4) with ESMTP id wBEEvvho009577;
	Fri, 14 Dec 2018 09:57:57 -0500
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Peter Eisentraut <peter.eisentraut@2ndquadrant.com>
cc: pgsql-hackers@lists.postgresql.org
Subject: Re: Upgrading pg_statistic to handle collation honestly
In-reply-to: <106ec7b1-83c4-4fba-f10a-d0213fe19694@2ndquadrant.com>
References: <14706.1544630227@sss.pgh.pa.us>
 <106ec7b1-83c4-4fba-f10a-d0213fe19694@2ndquadrant.com>
Comments: In-reply-to Peter Eisentraut <peter.eisentraut@2ndquadrant.com>
	message dated "Fri, 14 Dec 2018 09:24:50 +0100"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <9575.1544799477.1@sss.pgh.pa.us>
Date: Fri, 14 Dec 2018 09:57:57 -0500
Message-ID: <9576.1544799477@sss.pgh.pa.us>
List-Id: <pgsql-hackers.lists.postgresql.org>
List-Help: <https://lists.postgresql.org/manage/>
List-Subscribe: <https://lists.postgresql.org/manage/>
List-Post: <mailto:pgsql-hackers@lists.postgresql.org>
List-Owner: <mailto:pgsql-hackers-owner@lists.postgresql.org>
List-Archive: <https://www.postgresql.org/list/pgsql-hackers>
Precedence: bulk

Peter Eisentraut <peter.eisentraut@2ndquadrant.com> writes:
> On 12/12/2018 16:57, Tom Lane wrote:
>> + 		stats->attrcollid = exprCollation(index_expr);
>> + 		/* XXX should we consult indcollation instead? */

> After looking through this again, I think the answer here is "yes".

Yeah, I was leaning towards that as well, but hadn't written the extra
code needed to make it so.  Will fix.

			regards, tom lane