Feedback-ID: i131946ab:Fastmail
Message-ID: <95767d55-0dfe-3e73-0373-9d910c4322f2@enterprisedb.com>
Date: Tue, 15 Nov 2022 17:07:05 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0)
 Gecko/20100101 Thunderbird/102.4.1
Subject: Re: meson oddities
Content-Language: en-US
To: Andres Freund <andres@anarazel.de>, Michael Paquier <michael@paquier.xyz>
Cc: Andrew Dunstan <andrew@dunslane.net>,
 PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
References: <64c0517b-5504-68ea-1912-9f647a70a3cc@dunslane.net>
 <Y3LN09Hu5GLadEMC@paquier.xyz>
 <20221114234812.yjj6gxs2n6e4uvgm@awork3.anarazel.de>
From: Peter Eisentraut <peter.eisentraut@enterprisedb.com>
In-Reply-To: <20221114234812.yjj6gxs2n6e4uvgm@awork3.anarazel.de>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Archived-At: 
 <https://www.postgresql.org/message-id/95767d55-0dfe-3e73-0373-9d910c4322f2%40enterprisedb.com>
Precedence: bulk

On 15.11.22 00:48, Andres Freund wrote:
> We effectively do that with autoconf as well, except that we don't mention
> that in pg_config --ldflags. Our linking rules include CFLAGS, see e.g.:
> 
> %: %.o
> 	$(CC) $(CFLAGS) $^ $(LDFLAGS) $(LDFLAGS_EX) $(LIBS) -o $@$(X)
> 
> postgres: $(OBJS)
> 	$(CC) $(CFLAGS) $(call expand_subsys,$^) $(LDFLAGS) $(LDFLAGS_EX) $(export_dynamic) $(LIBS) -o $@
> 
> ifdef PROGRAM
> $(PROGRAM): $(OBJS)
> 	$(CC) $(CFLAGS) $(OBJS) $(PG_LIBS_INTERNAL) $(LDFLAGS) $(LDFLAGS_EX) $(PG_LIBS) $(LIBS) -o $@$(X)
> endif
> 
> # Rule for building a shared library from a single .o file
> %.so: %.o
> 	$(CC) $(CFLAGS) $< $(LDFLAGS) $(LDFLAGS_SL) -shared -o $@
> 
> 
> Should we try that fact in pg_configin the meson build as well?

It's up to the consumer of pg_config to apply CFLAGS and LDFLAGS as they 
need.  But pg_config and pkg-config etc. should report them separately.