From: Tom Lane <tgl@sss.pgh.pa.us>
To: Andres Freund <andres@anarazel.de>
cc: Alvaro Herrera <alvherre@2ndquadrant.com>,
        Pavan Deolasee <pavan.deolasee@gmail.com>,
        Masahiko Sawada <sawada.mshk@gmail.com>,
        pgsql-hackers <pgsql-hackers@postgresql.org>,
        Jeff Janes <jeff.janes@gmail.com>,
 Simon Riggs <simon@2ndquadrant.com>,
        Tomas Vondra <tomas.vondra@2ndquadrant.com>
Subject: Re: COPY FREEZE and setting PD_ALL_VISIBLE/visibility map bits
In-reply-to: <20190405033537.vklegbflesm2c7m3@alap3.anarazel.de>
References: <20190404214520.7rfufsubxekodypr@alap3.anarazel.de>
 <20190405030604.GA3360@alvherre.pgsql>
 <20190405033537.vklegbflesm2c7m3@alap3.anarazel.de>
Comments: In-reply-to Andres Freund <andres@anarazel.de>
	message dated "Thu, 04 Apr 2019 20:35:37 -0700"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <958.1554436678.1@sss.pgh.pa.us>
Date: Thu, 04 Apr 2019 23:57:58 -0400
Message-ID: <959.1554436678@sss.pgh.pa.us>
Precedence: bulk

Andres Freund <andres@anarazel.de> writes:
> I think the right approach would be to do all of this in heap_insert and
> heap_multi_insert. Whenever starting to work on a page, if INSERT_FROZEN
> is specified, remember whether it is either currently empty, or is
> already marked as all-visible. If previously empty, mark it as all
> visible at the end. If already all visible, there's no need to change
> that. If not yet all-visible, no need to do anything, since it can't
> have been inserted with COPY FREEZE.  Do you see any problem doing it
> that way?

Do we want to add overhead to these hot-spot routines for this purpose?

			regards, tom lane