Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oWBMH-00065w-B3 for pgsql-hackers@arkaria.postgresql.org; Thu, 08 Sep 2022 06:49:53 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1oWBMF-0007Ly-6g for pgsql-hackers@arkaria.postgresql.org; Thu, 08 Sep 2022 06:49:51 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oWBME-0007Lo-KT for pgsql-hackers@lists.postgresql.org; Thu, 08 Sep 2022 06:49:50 +0000 Received: from smtp-fw-80006.amazon.com ([99.78.197.217]) by makus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oWBM7-0003KB-Rx for pgsql-hackers@lists.postgresql.org; Thu, 08 Sep 2022 06:49:49 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amazon.com; i=@amazon.com; q=dns/txt; s=amazon201209; t=1662619783; x=1694155783; h=message-id:date:mime-version:subject:to:cc:references: from:in-reply-to; bh=GykhxDnHtcTO7VPvBemGTZpQ/9erMhYZN1zL11Ok8Lw=; b=lyMYd+fgt7vwRL034Prm5HPqXqRaF4TUqkvBNhbTxFlKfUt3aSdblvdL dw3S4fB0SO8Fe2x0X3rV10/DLjGD/oafYt8RJaoMa0G/+Ep6XT9FMEi6T tJuDpowA4RBKH7lUcF0e0d0m5qDjwc2R6U6AMhK6ojZAvPybOghxJDO9O U=; X-IronPort-AV: E=Sophos;i="5.93,299,1654560000"; d="scan'208,217";a="127839082" Received: from pdx4-co-svc-p1-lb2-vlan2.amazon.com (HELO email-inbound-relay-iad-1a-4ba5c7da.us-east-1.amazon.com) ([10.25.36.210]) by smtp-border-fw-80006.pdx80.corp.amazon.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 08 Sep 2022 06:49:17 +0000 Received: from EX13D03EUC003.ant.amazon.com (iad12-ws-svc-p26-lb9-vlan2.iad.amazon.com [10.40.163.34]) by email-inbound-relay-iad-1a-4ba5c7da.us-east-1.amazon.com (Postfix) with ESMTPS id 33ADA9528F; Thu, 8 Sep 2022 06:49:15 +0000 (UTC) Received: from [192.168.1.123] (10.43.165.87) by EX13D03EUC003.ant.amazon.com (10.43.164.192) with Microsoft SMTP Server (TLS) id 15.0.1497.38; Thu, 8 Sep 2022 06:49:14 +0000 Content-Type: multipart/alternative; boundary="------------wBKaXbfQw3fvcGX0bJ6z2VgM" Message-ID: <95c702fa-61a1-1bc1-7313-4f2b46fdaf94@amazon.com> Date: Thu, 8 Sep 2022 08:49:13 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.2.1 Subject: Re: [PATCH] Query Jumbling for CALL and SET utility statements Content-Language: en-US To: Michael Paquier , Jeremy Schneider CC: PostgreSQL Hackers , Pavel Stehule , Andres Freund , "Imseih (AWS), Sami" References: <36e5bffe-e989-194f-85c8-06e7bc88e6f7@amazon.com> <20220831160839.wseeotr7rckucpmv@awork3.anarazel.de> <46ca04f9-1e37-c862-9a28-c5dffaee412f@amazon.com> <20220831190604.l2luuhj3xkau7dvk@awork3.anarazel.de> <09c04aba-7f12-e524-20f7-3f92c1479fdf@amazon.com> <9aee54f2-5cc1-5b64-1f73-6961932e7bd2@amazon.com> From: "Drouvot, Bertrand" In-Reply-To: X-Originating-IP: [10.43.165.87] X-ClientProxiedBy: EX13D05EUC001.ant.amazon.com (10.43.164.118) To EX13D03EUC003.ant.amazon.com (10.43.164.192) List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk --------------wBKaXbfQw3fvcGX0bJ6z2VgM Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 8bit Hi, On 9/8/22 7:23 AM, Michael Paquier wrote: > On Wed, Sep 07, 2022 at 06:19:42PM -0700, Jeremy Schneider wrote: >> I didn't fully debug yet, but here's the backtrace on my 14.4 build with >> the patch Thanks Jeremy for reporting the issue! > What happens on HEAD? That would be the target branch for a new > feature. Just tested and i can see the same issue on HEAD. Issue is on stmt->name being NULL here: Breakpoint 2, JumbleExpr (jstate=0x55d60e769e30, node=0x55d60e769b60) at queryjumble.c:364 364             if (node == NULL) (gdb) n 368             check_stack_depth(); (gdb) 374             APP_JUMB(node->type); (gdb) 376             switch (nodeTag(node)) (gdb) 398                                     VariableSetStmt *stmt = (VariableSetStmt *) node; (gdb) n 400 APP_JUMB_STRING(stmt->name); (gdb) p stmt->name $1 = 0x0 I'll have a closer look. Regards, -- Bertrand Drouvot PostgreSQL Contributors Team RDS Open Source Databases Amazon Web Services:https://aws.amazon.com --------------wBKaXbfQw3fvcGX0bJ6z2VgM Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: 8bit

Hi,

On 9/8/22 7:23 AM, Michael Paquier wrote:
On Wed, Sep 07, 2022 at 06:19:42PM -0700, Jeremy Schneider wrote:

I didn't fully debug yet, but here's the backtrace on my 14.4 build with
the patch

Thanks Jeremy for reporting the issue!

What happens on HEAD?  That would be the target branch for a new
feature.

Just tested and i can see the same issue on HEAD.

Issue is on stmt->name being NULL here:

Breakpoint 2, JumbleExpr (jstate=0x55d60e769e30, node=0x55d60e769b60) at queryjumble.c:364
364             if (node == NULL)
(gdb) n
368             check_stack_depth();
(gdb)
374             APP_JUMB(node->type);
(gdb)
376             switch (nodeTag(node))
(gdb)
398                                     VariableSetStmt *stmt = (VariableSetStmt *) node;
(gdb) n
400                                     APP_JUMB_STRING(stmt->name);
(gdb) p stmt->name
$1 = 0x0

I'll have a closer look.

Regards,

-- 
Bertrand Drouvot
PostgreSQL Contributors Team
RDS Open Source Databases
Amazon Web Services: https://aws.amazon.com
--------------wBKaXbfQw3fvcGX0bJ6z2VgM--