Message-ID: <95e3c93f-3b74-41c4-a7f7-63c7ae456a88@uni-muenster.de>
Date: Thu, 5 Feb 2026 12:53:22 +0100
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: Truncate logs by max_log_size
To: =?UTF-8?Q?=C3=81lvaro_Herrera?= <alvherre@kurilemu.de>
Cc: Fujii Masao <masao.fujii@gmail.com>,
 Fujii Masao <masao.fujii@oss.nttdata.com>,
 Kirill Gavrilov <diphantxm@gmail.com>, Kirill Reshke
 <reshkekirill@gmail.com>, "Andrey M. Borodin" <x4mmm@yandex-team.ru>,
 Euler Taveira <euler@eulerto.com>, pgsql-hackers@lists.postgresql.org
References: <202602051012.qer26xklakqb@alvherre.pgsql>
Content-Language: de-DE, en-GB
From: Jim Jones <jim.jones@uni-muenster.de>
In-Reply-To: <202602051012.qer26xklakqb@alvherre.pgsql>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
Archived-At: <https://www.postgresql.org/message-id/95e3c93f-3b74-41c4-a7f7-63c7ae456a88%40uni-muenster.de>
Precedence: bulk


On 05/02/2026 11:22, Álvaro Herrera wrote:
> My only comment at this point is that the proposed GUC name is not
> great.  I think it should be something like log_statement_max_length, or
> something like that.  Reading just the thread subject, people would
> imagine this is about the size of the log file.

+1 for log_statement_max_length

> 
> Another point is that the current patch does strlen() twice on each
> query.  It might be better to do away with need_truncate_query_log() and
> have a single routine that both determines whether the truncation is
> needed and returns the truncated query if it is.  If it returns NULL
> then caller assumes it's not needed.

I'll take a look at this.

Another thing that we could adjust is the default/disable value: I
personally find 0 to disable the feature a bit confusing. 0 might be
interpreted as "log 0 bytes", and the user ends up with the full
statement logged. What about -1?

Best, Jim