Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1t9eLl-00BTre-KA for pgsql-hackers@arkaria.postgresql.org; Sat, 09 Nov 2024 05:49:33 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.94.2) (envelope-from ) id 1t9eLj-00GXHF-2o for pgsql-hackers@arkaria.postgresql.org; Sat, 09 Nov 2024 05:49:31 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1t9eIW-00GRLF-61 for pgsql-hackers@lists.postgresql.org; Sat, 09 Nov 2024 05:46:12 +0000 Received: from oss.nttdata.com ([49.212.34.109]) by magus.postgresql.org with esmtps (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1t9eIR-000yIl-Uz; Sat, 09 Nov 2024 05:46:12 +0000 Received: from [172.20.10.7] (unknown [183.74.204.232]) by oss.nttdata.com (Postfix) with ESMTPSA id A526261B92; Sat, 9 Nov 2024 14:46:05 +0900 (JST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.11 at oss.nttdata.com Content-Type: multipart/mixed; boundary="------------AEgHPc8c4zdQgYHK1lFycaQR" Message-ID: <95f1100e-e59b-41b7-a406-f865c2e69db7@oss.nttdata.com> Date: Sat, 9 Nov 2024 14:46:00 +0900 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: Fix for Extra Parenthesis in pgbench progress message To: Tatsuo Ishii Cc: btogiwarayuushi@oss.nttdata.com, pgsql-hackers@postgresql.org References: <0f7ac0fa-f26b-49dc-b9a0-d35c29ace3a5@oss.nttdata.com> <20241107.104143.1498084100859794666.ishii@postgresql.org> <85fe426d-248a-47f7-8784-22af811ee572@oss.nttdata.com> <20241108.114713.484828673471024549.ishii@postgresql.org> Content-Language: en-US From: Fujii Masao In-Reply-To: <20241108.114713.484828673471024549.ishii@postgresql.org> List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk This is a multi-part message in MIME format. --------------AEgHPc8c4zdQgYHK1lFycaQR Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 2024/11/08 11:47, Tatsuo Ishii wrote: > I think you need to adjust > > fprintf(stderr, "%*c\r", chars - 1, ' '); /* Clear the current line */ > > to: > > fprintf(stderr, "%*c\r", chars, ' '); /* Clear the current line */ > > since now chars does not consider the EOL char. By clearing chars - 1, > the closing parenthesis will be left on the screen. You're right! I've updated the patch and attached v4. About the back-patch: initially, there were concerns it might be too invasive, as you told upthread. However, after our discussion, I think the latest version is straightforward enough, and I'm okay with back-patching it. Thoughts? Since the minor release freeze is already in effect, if we commit this patch, we'll need to wait until the next minor releases are out next week before the commit and back-patch. Regards, -- Fujii Masao Advanced Computing Technology Center Research and Development Headquarters NTT DATA CORPORATION --------------AEgHPc8c4zdQgYHK1lFycaQR Content-Type: text/plain; charset=UTF-8; name="v4-0001-pgbench-Ensure-previous-progress-message-is-fully.patch" Content-Disposition: attachment; filename*0="v4-0001-pgbench-Ensure-previous-progress-message-is-fully.pa"; filename*1="tch" Content-Transfer-Encoding: base64 RnJvbSBiNTU1NDdhNWRiNzA0YTI0ZGQ2ZDJmOGQwMTkxOGY0MjA2MjY3MDVjIE1vbiBTZXAg MTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBGdWppaSBNYXNhbyA8ZnVqaWlAcG9zdGdyZXNxbC5v cmc+CkRhdGU6IEZyaSwgOCBOb3YgMjAyNCAwMDozNDo1NSArMDkwMApTdWJqZWN0OiBbUEFU Q0ggdjRdIHBnYmVuY2g6IEVuc3VyZSBwcmV2aW91cyBwcm9ncmVzcyBtZXNzYWdlIGlzIGZ1 bGx5IGNsZWFyZWQKIHdoZW4gdXBkYXRpbmcuCgpEdXJpbmcgcGdiZW5jaCdzIHRhYmxlIGlu aXRpYWxpemF0aW9uLCBwcm9ncmVzcyB1cGRhdGVzIGNvdWxkIGRpc3BsYXkKbGVmdG92ZXIg Y2hhcmFjdGVycyBmcm9tIHRoZSBwcmV2aW91cyBtZXNzYWdlIGlmIHRoZSBuZXcgbWVzc2Fn ZQp3YXMgc2hvcnRlci4gVGhpcyBjb21taXQgcmVzb2x2ZXMgdGhlIGlzc3VlIGJ5IGFwcGVu ZGluZyBzcGFjZXMgdG8KdGhlIGN1cnJlbnQgbWVzc2FnZSB0byBmdWxseSBvdmVyd3JpdGUg YW55IHJlbWFpbmluZyBjaGFyYWN0ZXJzIGZyb20KdGhlIHByZXZpb3VzIGxpbmUuCgpCYWNr LXBhdGNoIHRvIGFsbCB0aGUgc3VwcG9ydGVkIHZlcnNpb25zLgoKQXV0aG9yOiBZdXNoaSBP Z2l3YXJhLCBUYXRzdW8gSXNoaWksIEZ1amlpIE1hc2FvClJldmlld2VkLWJ5OiBUYXRzdW8g SXNoaWksIEZ1amlpIE1hc2FvCkRpc2N1c3Npb246IGh0dHBzOi8vcG9zdGdyLmVzL20vOWE5 YjhiOTViNmE3MDk4NzdhZTQ4YWQ1YjBjNTliYjlAb3NzLm50dGRhdGEuY29tCi0tLQogc3Jj L2Jpbi9wZ2JlbmNoL3BnYmVuY2guYyB8IDIxICsrKysrKysrKysrKysrKystLS0tLQogMSBm aWxlIGNoYW5nZWQsIDE2IGluc2VydGlvbnMoKyksIDUgZGVsZXRpb25zKC0pCgpkaWZmIC0t Z2l0IGEvc3JjL2Jpbi9wZ2JlbmNoL3BnYmVuY2guYyBiL3NyYy9iaW4vcGdiZW5jaC9wZ2Jl bmNoLmMKaW5kZXggYmEyNDdmM2Y4NS4uODVlN2I2OGJhYSAxMDA2NDQKLS0tIGEvc3JjL2Jp bi9wZ2JlbmNoL3BnYmVuY2guYworKysgYi9zcmMvYmluL3BnYmVuY2gvcGdiZW5jaC5jCkBA IC00OTQ0LDYgKzQ5NDQsNyBAQCBpbml0UG9wdWxhdGVUYWJsZShQR2Nvbm4gKmNvbiwgY29u c3QgY2hhciAqdGFibGUsIGludDY0IGJhc2UsCiAJaW50CQkJbjsKIAlpbnQ2NAkJazsKIAlp bnQJCQljaGFycyA9IDA7CisJaW50CQkJcHJldl9jaGFycyA9IDA7CiAJUEdyZXN1bHQgICAq cmVzOwogCVBRRXhwQnVmZmVyRGF0YSBzcWw7CiAJY2hhcgkJY29weV9zdGF0ZW1lbnRbMjU2 XTsKQEAgLTUwMDQsMTAgKzUwMDUsMTAgQEAgaW5pdFBvcHVsYXRlVGFibGUoUEdjb25uICpj b24sIGNvbnN0IGNoYXIgKnRhYmxlLCBpbnQ2NCBiYXNlLAogCQkJZG91YmxlCQllbGFwc2Vk X3NlYyA9IFBHX1RJTUVfR0VUX0RPVUJMRShwZ190aW1lX25vdygpIC0gc3RhcnQpOwogCQkJ ZG91YmxlCQlyZW1haW5pbmdfc2VjID0gKChkb3VibGUpIHRvdGFsIC0gaikgKiBlbGFwc2Vk X3NlYyAvIGo7CiAKLQkJCWNoYXJzID0gZnByaW50ZihzdGRlcnIsIElOVDY0X0ZPUk1BVCAi IG9mICIgSU5UNjRfRk9STUFUICIgdHVwbGVzICglZCUlKSBvZiAlcyBkb25lIChlbGFwc2Vk ICUuMmYgcywgcmVtYWluaW5nICUuMmYgcyklYyIsCisJCQljaGFycyA9IGZwcmludGYoc3Rk ZXJyLCBJTlQ2NF9GT1JNQVQgIiBvZiAiIElOVDY0X0ZPUk1BVCAiIHR1cGxlcyAoJWQlJSkg b2YgJXMgZG9uZSAoZWxhcHNlZCAlLjJmIHMsIHJlbWFpbmluZyAlLjJmIHMpIiwKIAkJCQkJ CQlqLCB0b3RhbCwKIAkJCQkJCQkoaW50KSAoKGogKiAxMDApIC8gdG90YWwpLAotCQkJCQkJ CXRhYmxlLCBlbGFwc2VkX3NlYywgcmVtYWluaW5nX3NlYywgZW9sKTsKKwkJCQkJCQl0YWJs ZSwgZWxhcHNlZF9zZWMsIHJlbWFpbmluZ19zZWMpOwogCQl9CiAJCS8qIGxldCdzIG5vdCBj YWxsIHRoZSB0aW1pbmcgZm9yIGVhY2ggcm93LCBidXQgb25seSBlYWNoIDEwMCByb3dzICov CiAJCWVsc2UgaWYgKHVzZV9xdWlldCAmJiAoaiAlIDEwMCA9PSAwKSkKQEAgLTUwMTgsMTkg KzUwMTksMjkgQEAgaW5pdFBvcHVsYXRlVGFibGUoUEdjb25uICpjb24sIGNvbnN0IGNoYXIg KnRhYmxlLCBpbnQ2NCBiYXNlLAogCQkJLyogaGF2ZSB3ZSByZWFjaGVkIHRoZSBuZXh0IGlu dGVydmFsIChvciBlbmQpPyAqLwogCQkJaWYgKChqID09IHRvdGFsKSB8fCAoZWxhcHNlZF9z ZWMgPj0gbG9nX2ludGVydmFsICogTE9HX1NURVBfU0VDT05EUykpCiAJCQl7Ci0JCQkJY2hh cnMgPSBmcHJpbnRmKHN0ZGVyciwgSU5UNjRfRk9STUFUICIgb2YgIiBJTlQ2NF9GT1JNQVQg IiB0dXBsZXMgKCVkJSUpIG9mICVzIGRvbmUgKGVsYXBzZWQgJS4yZiBzLCByZW1haW5pbmcg JS4yZiBzKSVjIiwKKwkJCQljaGFycyA9IGZwcmludGYoc3RkZXJyLCBJTlQ2NF9GT1JNQVQg IiBvZiAiIElOVDY0X0ZPUk1BVCAiIHR1cGxlcyAoJWQlJSkgb2YgJXMgZG9uZSAoZWxhcHNl ZCAlLjJmIHMsIHJlbWFpbmluZyAlLjJmIHMpIiwKIAkJCQkJCQkJaiwgdG90YWwsCiAJCQkJ CQkJCShpbnQpICgoaiAqIDEwMCkgLyB0b3RhbCksCi0JCQkJCQkJCXRhYmxlLCBlbGFwc2Vk X3NlYywgcmVtYWluaW5nX3NlYywgZW9sKTsKKwkJCQkJCQkJdGFibGUsIGVsYXBzZWRfc2Vj LCByZW1haW5pbmdfc2VjKTsKIAogCQkJCS8qIHNraXAgdG8gdGhlIG5leHQgaW50ZXJ2YWwg Ki8KIAkJCQlsb2dfaW50ZXJ2YWwgPSAoaW50KSBjZWlsKGVsYXBzZWRfc2VjIC8gTE9HX1NU RVBfU0VDT05EUyk7CiAJCQl9CiAJCX0KKworCQkvKgorCQkgKiBJZiB0aGUgcHJldmlvdXMg cHJvZ3Jlc3MgbWVzc2FnZSBpcyBsb25nZXIgdGhhbiB0aGUgY3VycmVudCBvbmUsCisJCSAq IGFkZCBzcGFjZXMgdG8gdGhlIGN1cnJlbnQgbGluZSB0byBmdWxseSBvdmVyd3JpdGUgYW55 IHJlbWFpbmluZworCQkgKiBjaGFyYWN0ZXJzIGZyb20gdGhlIHByZXZpb3VzIG1lc3NhZ2Uu CisJCSAqLworCQlpZiAocHJldl9jaGFycyA+IGNoYXJzKQorCQkJZnByaW50ZihzdGRlcnIs ICIlKmMiLCBwcmV2X2NoYXJzIC0gY2hhcnMsICcgJyk7CisJCWZwdXRjKGVvbCwgc3RkZXJy KTsKKwkJcHJldl9jaGFycyA9IGNoYXJzOwogCX0KIAogCWlmIChjaGFycyAhPSAwICYmIGVv bCAhPSAnXG4nKQotCQlmcHJpbnRmKHN0ZGVyciwgIiUqY1xyIiwgY2hhcnMgLSAxLCAnICcp OwkvKiBDbGVhciB0aGUgY3VycmVudCBsaW5lICovCisJCWZwcmludGYoc3RkZXJyLCAiJSpj XHIiLCBjaGFycywgJyAnKTsJLyogQ2xlYXIgdGhlIGN1cnJlbnQgbGluZSAqLwogCiAJaWYg KFBRcHV0bGluZShjb24sICJcXC5cbiIpKQogCQlwZ19mYXRhbCgidmVyeSBsYXN0IFBRcHV0 bGluZSBmYWlsZWQiKTsKLS0gCjIuNDcuMAoK --------------AEgHPc8c4zdQgYHK1lFycaQR--