From: Tom Lane <tgl@sss.pgh.pa.us>
To: Andrew Dunstan <andrew@dunslane.net>
cc: Jelte Fennema <postgres@jeltef.nl>,
        "shiy.fnst@fujitsu.com" <shiy.fnst@fujitsu.com>,
        Robert Haas <robertmhaas@gmail.com>,
        Justin Pryzby <pryzby@telsasoft.com>,
        Andres Freund <andres@anarazel.de>, Noah Misch <noah@leadboat.com>,
        Peter Geoghegan <pg@bowt.ie>, Bruce Momjian <bruce@momjian.us>,
        Magnus Hagander <magnus@hagander.net>,
        Alvaro Herrera <alvherre@2ndquadrant.com>,
        Stephen Frost <sfrost@snowman.net>, Jesse Zhang <sbjesse@gmail.com>,
        "pgsql-hackers@postgresql.org" <pgsql-hackers@postgresql.org>
Subject: Re: run pgindent on a regular basis / scripted manner
In-reply-to: <22af2c75-73a6-beab-e376-0e56cbe9a97d@dunslane.net>
References: <CAH2-Wzm0niYBPcN6eX3PzHABfj0dE3fwifo5bdturvMp=9FGqw@mail.gmail.com> <2009472.1675532231@sss.pgh.pa.us> <CA+TgmoY59Ksso81RNLArNxj0a7xaqV_F_u7gSMHbgdc2kG5Vpw@mail.gmail.com> <ef4c7196-24b0-9fe9-1b5e-3ec8a5c34c7b@dunslane.net> <CA+TgmoYTg4avVbkzhhQi3Z-HoxsAvtD=tZiSdWZU9avF_2ouZA@mail.gmail.com> <3d67bc80-4de2-5ba8-e272-e4ad2e59ba04@dunslane.net> <4ac8f263-f1bb-faa5-a307-1fffe00f0e3e@dunslane.net> <CAGECzQRJrcoxozHh=BRTdLrirFui-3nvdRZru7GGa4F9HJV2Rw@mail.gmail.com> <b8f18576-afc0-d961-b33b-c0fa2e63edeb@dunslane.net> <0f074818-b01a-799f-3c74-5fb5deab1d23@dunslane.net> <CAGECzQSUYmfTwEWcVfwb4d=vf=M7RYJjq6ie0YPTUhP+YFcEww@mail.gmail.com> <1d66447e-a77b-ca0d-90a0-782800e85383@dunslane.net> <TYAPR01MB6315B86619944D4A6B56842DFDDE9@TYAPR01MB6315.jpnprd01.prod.outlook.com> <CAGECzQT44xN-zcTQ0+OxLpWa9nONxmEaYxQpaWM+My+A4o72PA@mail.gmail.com> <390e7b04-11f3-f715-7a7d-d1a9077fbea8@dunslane.net> <00885533-! ff96-2a95-7911-329c873b3029@dunslane.net> <842819.1676219054@sss.pgh.pa!
 .us> <22af2c75-73a6-beab-e376-0e56cbe9a97d@dunslane.net>
Comments: In-reply-to Andrew Dunstan <andrew@dunslane.net>
	message dated "Sun, 12 Feb 2023 15:41:56 -0500"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <961093.1676236415.1@sss.pgh.pa.us>
Date: Sun, 12 Feb 2023 16:13:35 -0500
Message-ID: <961094.1676236415@sss.pgh.pa.us>
Archived-At: <https://www.postgresql.org/message-id/961094.1676236415%40sss.pgh.pa.us>
Precedence: bulk

Andrew Dunstan <andrew@dunslane.net> writes:
> On 2023-02-12 Su 11:24, Tom Lane wrote:
>> It seems like "indent the whole tree" is about to become a minority
>> use-case.  Maybe instead of continuing to privilege that case, we
>> should say that it's invoked by some new switch like --all-files,
>> and without that only the stuff identified by command-line arguments
>> gets processed.

> I don't think we need --all-files. The attached gets rid of the build 
> and code-base cruft, which is now in any case obsolete given we've put 
> pg_bsd_indent in our code base. So the way to spell this instead of 
> "pgindent --all-files" would be "pgindent ."

Ah, of course.

> I added a warning if there are no files at all specified.

LGTM.

			regards, tom lane